Bug 1189880

Summary:	Grammar issue, "unentitle" not a word.
Product:	Red Hat Enterprise Linux 6	Reporter:	John Sefler <jsefler>
Component:	subscription-manager	Assignee:	Chris "Ceiu" Rog <crog>
Status:	CLOSED ERRATA	QA Contact:	Jan Stavel <jstavel>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	6.8	CC:	crog, csnyder, dgoodwin, jstavel
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-05-10 20:35:58 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1209535

Description John Sefler 2015-02-05 17:36:13 UTC

Description of problem:
Similar to bug 1149098, the word "unentitle" is not recognized by dictionary.com.

It is used in the following two msgids...

[root@jsefler-os7 ~]# msgunfmt --no-wrap /usr/share/locale/fr/LC_MESSAGES/rhsm.mo | grep "unentitle" -B1

msgid "Could not unentitle system on legacy server.  "
--

msgid "state to leave system in on legacy server (not available in hosted environments; default is 'unentitle')"


These two strings are used in the context of the sat5to6 tool which employs rhn-channel tooling whose help message reports options:
  -c CHANNEL, --channel=CHANNEL
                        name of channel you want to (un)subscribe
  -a, --add             subscribe to channel
  -r, --remove          unsubscribe from channel

Therefore I suggest re-wording the subscription-manager msgids to...

msgid "Could not remove channels from system on legacy server.  "

msgid "state to leave system in on legacy server (not available in hosted environments; default is 'unsubscribed')"


Additional note:
If these string changes are implemented, it appears to also affect the --registration-state and valid_states = ["keep", "unentitle", "purge"] in migrate.py


Version-Release number of selected component (if applicable):
[root@jsefler-os7 ~]# rpm -q subscription-manager
subscription-manager-1.13.19-1.el7.x86_64

Comment 1 Chris "Ceiu" Rog 2015-06-04 15:02:22 UTC

commit 599f217a4cf06248720fa0a30bd08b0b4ecc0f18
Author: Chris Rog <crog>
Date:   Wed Apr 8 10:33:03 2015 -0400

    1189880: Removed the non-word "unentitle" from error messages
    
    - Removed the two instances of "unentitle" from error messages output
      when revoking a system's entitlement fails.
    - The term still exists as a system state and option.

Comment 4 Jan Stavel 2016-02-08 18:29:00 UTC

Red Hat Enterprise Linux Client release 6.7 (Santiago)
----------------------------
server type                      Red Hat Subscription Management
subscription management server   0.9.51.15-1
subscription management rules    5.15.1
subscription-manager             1.16.8-1.el6
python-rhsm                      1.16.6-1.el6
----------------------------     ----------------------------
Product                          68.pem
----------------------------     ----------------------------
Entitlement                      5795330892602082507.pem
----------------------------     ----------------------------

[root@localhost entitlement]# msgunfmt --no-wrap /usr/share/locale/fr/LC_MESSAGES/rhsm.mo | grep "unentitle" -B1

[root@localhost entitlement]# echo $?
1

Comment 5 John Sefler 2016-02-08 19:52:33 UTC

[root@jsefler-6 ~]# rpm -q --whatprovides /usr/share/locale/fr/LC_MESSAGES/rhsm.mo
subscription-manager-1.16.8-1.el6.x86_64


The new msgids have been changed to the following...

[root@jsefler-6 ~]# msgunfmt --no-wrap /usr/share/locale/fr/LC_MESSAGES/rhsm.mo | grep "on legacy server"
msgid "Could not remove system entitlement on legacy server.  "
msgid "state to leave system in on legacy server (default is '%s')"


Notice that "unentitle system" has been changed to "remove system entitlement" in the first msgid

Notice that string substitution is now being used in the second msgid where "unentitle" will remain as a system state as indicated in comment 1

Comment 7 errata-xmlrpc 2016-05-10 20:35:58 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-0797.html