Bug 1190046

Summary:	Review Request: averia-fonts - non-commercial font with OFL license
Product:	[Fedora] Fedora	Reporter:	Carlos Morel-Riquelme <empateinfinito>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fonts-bugs, i18n-bugs, package-review, panemade
Target Milestone:	---	Flags:	panemade: fedora-review?
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-03-03 16:57:32 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Carlos Morel-Riquelme 2015-02-06 07:34:21 UTC

Spec URL: https://empateinfinito.fedorapeople.org/font/averia-fonts/averia-fonts.spec

SRPM URL: https://empateinfinito.fedorapeople.org/font/averia-fonts/averia-fonts-0.1-1.20120214.fc21.src.rpm

Description: Averia is a free-to-use non-commercial font with OFL license.

Fedora Account System Username:empateinfinito

FE-NEEDSPONSOR

Comment 1 Parag AN(पराग) 2015-02-06 16:26:04 UTC

Review:

+ Mock build is successful for F22(x86_64)

+ rpmlint output on all generated rpm looks good
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

+ Source verified with upstream as (sha356sum)
upstream source: 16cfec294d7364513e026ac2ff82ac30395ce33dcd4eb2fb559f109193166a1b
srpm source: 16cfec294d7364513e026ac2ff82ac30395ce33dcd4eb2fb559f109193166a1b

+ License "OFL" is valid and included in source files.

+ fontconfig file looks good

+ font metadata information is present

Suggestions:
1) Please properly truncate description lines to 80 characters whereaver possible. It should look like this
%description
Avería is a Unicode typeface family created from the average of all fonts on the
computer of the creator, Dan Sayers. The process is described at
http://iotic.com/averia/. All metrics are the result of an averaging process.

2) Try to have summary, description unique to packaged font.
Summary: Averia font family

3) use oflb as foundry

4) From the FONTLOG.txt it looks like you can use version as 1.01

5) $ appstream-util validate averia.metainfo.xml
averia.metainfo.xml: FAILED:
• markup-invalid : <id> does not have correct extension for kind
• tag-missing : <extends> is not present
• style-invalid : <summary> requires sentence case
• style-invalid : <p> cannot contain a hyperlink
• style-invalid : Not enough <p> tags for a good description
Validation of files failed

So fix 3rd and 4th message from above.

6) fontconfig need to be fixed as this is just "serif" font.

don't forget to increase the release number and add corresponding changes in changlog or just say "fixed as per review comments" like in changelog.

Comment 2 Parag AN(पराग) 2015-02-06 17:16:54 UTC

Just realized this font fits in fontconfig priority level 61-64. Other existing oflb LGC fonts are at 63 level. Choose 61 or higher maybe 63.

│ 61-64  │ Low priority LGC fonts                                             │

Comment 3 Carlos Morel-Riquelme 2015-02-09 10:11:44 UTC

spec: https://empateinfinito.fedorapeople.org/font/oflb-averia-fonts/oflb-averia-fonts.spec

srpm: https://empateinfinito.fedorapeople.org/font/oflb-averia-fonts/oflb-averia-fonts-1.01-1.20120214.fc21.src.rpm

Comment 4 Parag AN(पराग) 2015-03-03 16:57:32 UTC

FAS user empateinfinito moved to new FAS account name iddnna