Bug 1190048

Summary:	Review Request: pecita-fonts - non-commercial font with OFL license
Product:	[Fedora] Fedora	Reporter:	Carlos Morel-Riquelme <empateinfinito>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fonts-bugs, i18n-bugs, package-review, packager, panemade
Target Milestone:	---	Flags:	panemade: fedora-review?
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-03-03 16:57:33 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Carlos Morel-Riquelme 2015-02-06 07:37:52 UTC

Spec URL: https://empateinfinito.fedorapeople.org/font/pecita-fonts/pecita-fonts.spec

SRPM URL: https://empateinfinito.fedorapeople.org/font/pecita-fonts/pecita-fonts-0.1-1.20140527.fc21.src.rpm

Description: Pecita is a typeface that mimics handwriting
The use of complex features makes this possible
The OpenType features Localized form substitution, Superscript ,
Subscript, Small Capitals, Standard Ligatures and Contextual Alternates
are implemented.

Fedora Account System Username: empateinfinito

FE-NEEDSPONSOR

Comment 1 Parag AN(पराग) 2015-02-06 17:00:40 UTC

Review:

+ Mock build is successful for F22(x86_64)

+ rpmlint output on all generated rpm looks good
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

+ Source verified with upstream as (sha356sum)
upstream source: 5e0783209552d6a6d3f58b2fa8c191d8331fe60a29ed17576d6bdd5614a6eb2c
srpm source: 5e0783209552d6a6d3f58b2fa8c191d8331fe60a29ed17576d6bdd5614a6eb2c

+ License "OFL" is valid and included in source files.

+ fontconfig file looks good

+ font metadata information is present

Suggestions:
1) For Handwriting category font we use "cursive" name so change sans-serif to cursive in fontconfig file

2) version 4.3 is embedded in font metainfo so let's use that

3) $ appstream-util validate pecita.metainfo.xml 
pecita.metainfo.xml: FAILED:
• markup-invalid        : <id> does not have correct extension for kind
• tag-missing           : <extends> is not present
• style-invalid         : <summary> requires sentence case
• style-invalid         : <p> cannot contain a hyperlink
• style-invalid         : <p> does not end in '.|:|!'
• style-invalid         : Not enough <p> tags for a good description
Validation of files failed

=> fix messages 3,4,5 from above in metainfo xml file

4) Create wiki page for this font as given in your other font package review.

5) use oflb as prefix foundry

Comment 2 Parag AN(पराग) 2015-02-06 17:16:54 UTC

Just realized this font fits in fontconfig priority level 61-64. Other existing oflb LGC fonts are at 63 level. Choose 61 or higher maybe 63.

│ 61-64  │ Low priority LGC fonts                                             │

Comment 3 Carlos Morel-Riquelme 2015-02-09 10:11:50 UTC

spec: https://empateinfinito.fedorapeople.org/font/oflb-pecita-fonts/oflb-pecita-fonts.spec

srpm: https://empateinfinito.fedorapeople.org/font/oflb-pecita-fonts/oflb-pecita-fonts-4.3-1.20140527.fc21.src.rpm

Comment 4 Parag AN(पराग) 2015-03-03 16:57:33 UTC

FAS user empateinfinito moved to new FAS account name iddnna