Bug 1190054

Summary:	Changes lost when editing LDAP Host Names
Product:	Red Hat CloudForms Management Engine	Reporter:	Allan Topp <atopp>
Component:	UI - OPS	Assignee:	Milan Zázrivec <mzazrivec>
Status:	CLOSED ERRATA	QA Contact:	Milan Falešník <mfalesni>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	5.3.0	CC:	jhardy, mfalesni, mfeifer, obarenbo, ssainkar, xlecauch
Target Milestone:	GA
Target Release:	5.4.0
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	5.4.0.0.11	Doc Type:	Bug Fix
Doc Text:	In the previous version, attempting to change the three values under LDAP Host Names and pressing Save, CloudForms dropped the last change. This was because code was deleting from an array for LDAP Settings while iterating through it. With this release, code was updated to fix LDAP authentication settings and the issue is now resolved. Changes to LDAP settings are now correctly saved.	Story Points:	---
Clone Of:
Clones:	1190826 (view as bug list)		Environment:
Last Closed:	2015-06-16 12:49:22 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1110527, 1190826

Description Allan Topp 2015-02-06 08:06:50 UTC

Description of problem:

We use LDAP authentication for our CloudForms appliances, configured via Configure - Configuration - Settings - [appliance] - Authentication.

Changing the three values under LDAP Host Names and pressing Save, we noticed that CloudForms seems to drop the last change.

Two examples:

1. Before editing, all three fields were populated with three different hostnames:

dc1dccorp01.corplab.intuit.net
dc2dccorp01.corplab.intuit.net
itdccorp01.corplab.intuit.net

We removed the 2nd and 3rd hostname and pressed save. Afterwards, instead of only listing dc1dccorp01, the fields had this content:

dc1dccorp01.corplab.intuit.net
itdccorp01.corplab.intuit.net
[empty]

The second line which we deleted should have been empty, instead of having the content of the previous third line.

See attached screenshot 1.

2. Before editing, the fields had this content:

qdcldap.corp.intuit.net
[empty]
[empty]

We changed the first line to "corp.intuit.net", added "qdcldap.corp.intuit.net" in the second line, and clicked Save.

Afterwards, the lines had this content:

corp.intuit.net
[empty]
[empty]

The content of the second line which we entered was lost.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 3 Milan Zázrivec 2015-02-09 12:00:24 UTC

https://github.com/ManageIQ/manageiq/pull/1613

Comment 4 CFME Bot 2015-02-09 14:21:05 UTC

New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/d2e3be729de222b024391505a119d17cd37b44d9

commit d2e3be729de222b024391505a119d17cd37b44d9
Author:     Milan Zazrivec <mzazrivec>
AuthorDate: Mon Feb 9 12:58:02 2015 +0100
Commit:     Milan Zazrivec <mzazrivec>
CommitDate: Mon Feb 9 12:58:51 2015 +0100

    Fix LDAP Authentication settings
    
    We cannot delete from an array while iterating through it.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1190054

 vmdb/app/controllers/ops_controller/settings/common.rb | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

Comment 5 Milan Zázrivec 2015-02-16 12:47:57 UTC

One more fix is needed here: https://github.com/ManageIQ/manageiq/pull/1704

Comment 7 Milan Falešník 2015-03-13 10:14:51 UTC

Verified in 5.4.0.0.11, no such problems happen during editing LDAP hosts.

Comment 9 errata-xmlrpc 2015-06-16 12:49:22 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-1100.html