Bug 1190055 (massif-visualizer)
| Summary: | Review Request: massif-visualizer - Visualizer for Massif heap memory profiler data files | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Lubomir Rintel <lkundrak> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | kevin, lrintel, package-review, rdieter, zbyszek |
| Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-02-11 10:13:58 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 656997 | ||
|
Description
Lubomir Rintel
2015-02-06 08:14:10 UTC
SPEC: http://v3.sk/~lkundrak/SPECS/massif-visualizer.spec SRPM: http://v3.sk/~lkundrak/SRPMS/massif-visualizer-0.4.0-2.fc21.src.rpm Issues: ======= - update-desktop-database is invoked in %post and %postun if package contains desktop file(s) with a MimeType: entry. Note: desktop file(s) with MimeType entry in massif-visualizer See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop- database - The license is GPLv2+. The sources might be mixed license, but the resulting binary can only be under GPL, so there's no need to make things complicated. - Please add an appdata file [https://fedoraproject.org/wiki/Packaging:AppData]. I suggest you use appstream-util validate (w/o -relax) while developing it, but leave validate-relax in the spec file. Thank you (In reply to Zbigniew Jędrzejewski-Szmek from comment #2) > Issues: > ======= > - update-desktop-database is invoked in %post and %postun if package contains > desktop file(s) with a MimeType: entry. > Note: desktop file(s) with MimeType entry in massif-visualizer > See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop- > database Fixed. > - The license is GPLv2+. The sources might be mixed license, but the > resulting binary can only be under GPL, so there's no need to make things > complicated. Fixed. > - Please add an appdata file > [https://fedoraproject.org/wiki/Packaging:AppData]. > I suggest you use appstream-util validate (w/o -relax) while developing it, > but leave validate-relax in the spec file. Seems like it's SHOULD now. Given massif-visualizer targets hackers who are likely able to install the tool in a different way than GNOME software I don't believe it's worth patching the appdata file now. I've contacted upstream and asked them to add the appdata file, offering help if they need any. Could we do without the appdata file now and assume upstream is going to include it in a later version anyway? SPEC: http://v3.sk/~lkundrak/SPECS/massif-visualizer.spec SRPM: http://v3.sk/~lkundrak/SRPMS/massif-visualizer-0.4.0-3.fc21.src.rpm (In reply to Lubomir Rintel from comment #3) > > - Please add an appdata file > > [https://fedoraproject.org/wiki/Packaging:AppData]. > > I suggest you use appstream-util validate (w/o -relax) while developing it, > > but leave validate-relax in the spec file. > > Seems like it's SHOULD now. Given massif-visualizer targets hackers who are > likely able to install the tool in a different way than GNOME software I > don't believe it's worth patching the appdata file now. > > I've contacted upstream and asked them to add the appdata file, offering > help if they need any. Could we do without the appdata file now and assume > upstream is going to include it in a later version anyway? Makes sense. > SPEC: http://v3.sk/~lkundrak/SPECS/massif-visualizer.spec > SRPM: http://v3.sk/~lkundrak/SRPMS/massif-visualizer-0.4.0-3.fc21.src.rpm fedora-review has nothing interesting to say. The only thing is mime datebase snippets: they are different than those on http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#mimeinfo. Is this on purpose? Rpmlint ------- Checking: massif-visualizer-0.4.0-3.fc22.x86_64.rpm massif-visualizer-0.4.0-3.fc22.src.rpm massif-visualizer.x86_64: W: spelling-error Summary(en_US) profiler -> profile, profiles, profiled massif-visualizer.x86_64: W: spelling-error %description -l en_US pid -> peed, dip, pud massif-visualizer.x86_64: W: spelling-error %description -l en_US Gzip -> Zip, G zip, Grip massif-visualizer.x86_64: W: no-manual-page-for-binary massif-visualizer massif-visualizer.src: W: spelling-error Summary(en_US) profiler -> profile, profiles, profiled massif-visualizer.src: W: spelling-error %description -l en_US pid -> peed, dip, pud massif-visualizer.src: W: spelling-error %description -l en_US Gzip -> Zip, G zip, Grip 2 packages and 0 specfiles checked; 0 errors, 7 warnings. Package is APPROVED. Thank you! New Package SCM Request ======================= Package Name: massif-visualizer Short Description: Visualizer for Massif heap memory profiler data files Upstream URL: https://projects.kde.org/massif-visualizer Owners: lkundrak Branches: f20 f21 el6 epel7 Git done (by process-git-requests). Imported and built. Thank you! |