Bug 1190211

Summary: FATAL -- : Error caught: [ActionController::RoutingError] No route matches {:action=>"dialog_load", :controller=>"ems_infra"}
Product: Red Hat CloudForms Management Engine Reporter: Kevin Morey <kmorey>
Component: UI - OPSAssignee: Dan Clarizio <dclarizi>
Status: CLOSED ERRATA QA Contact: Dave Johnson <dajohnso>
Severity: high Docs Contact:
Priority: high    
Version: 5.3.0CC: david.costakos, jhardy, mfeifer, obarenbo, sshveta, xlecauch
Target Milestone: GA   
Target Release: 5.4.0   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: 5.4.0.0.11 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1190300 (view as bug list) Environment:
Last Closed: 2015-06-16 12:49:27 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1190300    

Description Kevin Morey 2015-02-06 16:35:01 UTC
Description of problem:
Buttons with services dialogs attached to providers throws an error with a missing route.

Version-Release number of selected component (if applicable):
5.3.2.6

How reproducible:
always

Steps to Reproduce:
1. create a button on provider
2. give the button a dialog (any will do)
3. attempt to click on the button while on a provider summary page

Actual results:
routing error is displayed on the UI

Expected results:
expected the service dialog to appear

Additional info:
[----] I, [2015-02-06T16:29:49.034925 #2496:e53030]  INFO -- : Started POST "/ems_infra/button/360000000000004" for 127.0.0.1 at 2015-02-06 11:29:49 -0500
[----] I, [2015-02-06T16:29:49.038054 #2496:e53030]  INFO -- : Processing by EmsInfraController#button as JS
[----] I, [2015-02-06T16:29:49.038139 #2496:e53030]  INFO -- :   Parameters: {"button_id"=>"360000000000009", "cls"=>"EmsVmware", "desc"=>"InspectMe", "id"=>"360000000000004", "pressed"=>"custom_button"}
[----] F, [2015-02-06T16:29:49.134051 #2496:e53030] FATAL -- : Error caught: [ActionController::RoutingError] No route matches {:action=>"dialog_load", :controller=>"ems_infra"}
/opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/action_dispatch/routing/route_set.rb:540:in `raise_routing_error'
/opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/action_dispatch/routing/route_set.rb:536:in `rescue in generate'
/opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/action_dispatch/routing/route_set.rb:528:in `generate'
/opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/action_dispatch/routing/route_set.rb:569:in `generate'
/opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/action_dispatch/routing/route_set.rb:594:in `url_for'
/opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/action_dispatch/routing/url_for.rb:148:in `url_for'
/opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/action_view/helpers/url_helper.rb:107:in `url_for'
/opt/rh/ruby193/root/usr/share/gems/gems/prototype-rails-3.2.1/lib/action_view/helpers/prototype_helper.rb:437:in `redirect_to'
/var/www/miq/vmdb/app/controllers/application_controller/dialog_runner.rb:219:in `block in dialog_initialize'
/opt/rh/ruby193/root/usr/share/gems/gems/prototype-rails-3.2.1/lib/action_view/helpers/prototype_helper.rb:152:in `instance_exec'
/opt/rh/ruby193/root/usr/share/gems/gems/prototype-rails-3.2.1/lib/action_view/helpers/prototype_helper.rb:152:in `block in initialize'
/opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/action_view/helpers/capture_helper.rb:187:in `with_output_buffer'
/opt/rh/ruby193/root/usr/share/gems/gems/haml-4.0.5/lib/haml/helpers/action_view_xss_mods.rb:5:in `with_output_buffer_with_haml_xss'
/opt/rh/ruby193/root/usr/share/gems/gems/prototype-rails-3.2.1/lib/action_view/helpers/prototype_helper.rb:151:in `initialize'
/opt/rh/ruby193/root/usr/share/gems/gems/prototype-rails-3.2.1/lib/prototype-rails/renderers.rb:7:in `new'
/opt/rh/ruby193/root/usr/share/gems/gems/prototype-rails-3.2.1/lib/prototype-rails/renderers.rb:7:in `block in <module:Renderers>'
/opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/action_controller/metal/renderers.rb:35:in `block in _handle_render_options'
/opt/rh/ruby193/root/usr/share/ruby/set.rb:222:in `block in each'
/opt/rh/ruby193/root/usr/share/ruby/set.rb:222:in `each_key'
/opt/rh/ruby193/root/usr/share/ruby/set.rb:222:in `each'
/opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/action_controller/metal/renderers.rb:32:in `_handle_render_options'
/opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/action_controller/metal/renderers.rb:28:in `render_to_body'
/opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/action_controller/metal/compatibility.rb:50:in `render_to_body'
/opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/abstract_controller/rendering.rb:88:in `render'
/opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/action_controller/metal/rendering.rb:16:in `render'
/opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/action_controller/metal/instrumentation.rb:40:in `block (2 levels) in render'
/opt/rh/ruby193/root/usr/share/gems/gems/activesupport-3.2.17/lib/active_support/core_ext/benchmark.rb:5:in `block in ms'
/opt/rh/ruby193/root/usr/share/ruby/benchmark.rb:295:in `realtime'
/opt/rh/ruby193/root/usr/share/gems/gems/activesupport-3.2.17/lib/active_support/core_ext/benchmark.rb:5:in `ms'
/opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/action_controller/metal/instrumentation.rb:40:in `block in render'
/opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/action_controller/metal/instrumentation.rb:83:in `cleanup_view_runtime'
/opt/rh/ruby193/root/usr/share/gems/gems/activerecord-3.2.17/lib/active_record/railties/controller_runtime.rb:24:in `cleanup_view_runtime'
/opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/action_controller/metal/instrumentation.rb:39:in `render'
/var/www/miq/vmdb/app/controllers/application_controller/dialog_runner.rb:218:in `dialog_initialize'
/var/www/miq/vmdb/app/controllers/application_controller/buttons.rb:302:in `custom_buttons'
/var/www/miq/vmdb/app/controllers/ems_common.rb:401:in `button'
/opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/action_controller/metal/implicit_render.rb:4:in `send_action'
/opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/abstract_controller/base.rb:167:in `process_action'
/opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/action_controller/metal/rendering.rb:10:in `process_action'
/opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/abstract_controller/callbacks.rb:18:in `block in process_action'
/opt/rh/ruby193/root/usr/share/gems/gems/activesupport-3.2.17/lib/active_support/callbacks.rb:513:in `_run__2094303924702088293__process_action__4120782226523820582__callbacks'
/opt/rh/ruby193/root/usr/share/gems/gems/activesupport-3.2.17/lib/active_support/callbacks.rb:405:in `__run_callback'
/opt/rh/ruby193/root/usr/share/gems/gems/activesupport-3.2.17/lib/active_support/callbacks.rb:385:in `_run_process_action_callbacks'
/opt/rh/ruby193/root/usr/share/gems/gems/activesupport-3.2.17/lib/active_support/callbacks.rb:81:in `run_callbacks'
/opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/abstract_controller/callbacks.rb:17:in `process_action'
/opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/action_controller/metal/rescue.rb:29:in `process_action'
/opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/action_controller/metal/instrumentation.rb:30:in `block in process_action'
/opt/rh/ruby193/root/usr/share/gems/gems/activesupport-3.2.17/lib/active_support/notifications.rb:123:in `block in instrument'
/opt/rh/ruby193/root/usr/share/gems/gems/activesupport-3.2.17/lib/active_support/notifications/instrumenter.rb:20:in `instrument'
/opt/rh/ruby193/root/usr/share/gems/gems/activesupport-3.2.17/lib/active_support/notifications.rb:123:in `instrument'
/opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/action_controller/metal/instrumentation.rb:29:in `process_action'
/opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/action_controller/metal/params_wrapper.rb:207:in `process_action'
/opt/rh/ruby193/root/usr/share/gems/gems/activerecord-3.2.17/lib/active_record/railties/controller_runtime.rb:18:in `process_action'
/opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/abstract_controller/base.rb:121:in `process'
/opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/abstract_controller/rendering.rb:45:in `process'
/opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/action_controller/metal.rb:203:in `dispatch'
/opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/action_controller/metal/rack_delegation.rb:14:in `dispatch'
/opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/action_controller/metal.rb:246:in `block in action'
/opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/action_dispatch/routing/route_set.rb:73:in `call'
/opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/action_dispatch/routing/route_set.rb:73:in `dispatch'
/opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/action_dispatch/routing/route_set.rb:36:in `call'
/opt/rh/ruby193/root/usr/share/gems/gems/journey-1.0.4/lib/journey/router.rb:68:in `block in call'
/opt/rh/ruby193/root/usr/share/gems/gems/journey-1.0.4/lib/journey/router.rb:56:in `each'
/opt/rh/ruby193/root/usr/share/gems/gems/journey-1.0.4/lib/journey/router.rb:56:in `call'
/opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/action_dispatch/routing/route_set.rb:608:in `call'
/opt/rh/ruby193/root/usr/share/gems/gems/rack-cache-1.2/lib/rack/cache/context.rb:136:in `forward'
/opt/rh/ruby193/root/usr/share/gems/gems/rack-cache-1.2/lib/rack/cache/context.rb:143:in `pass'
/opt/rh/ruby193/root/usr/share/gems/gems/rack-cache-1.2/lib/rack/cache/context.rb:155:in `invalidate'
/opt/rh/ruby193/root/usr/share/gems/gems/rack-cache-1.2/lib/rack/cache/context.rb:71:in `call!'
/opt/rh/ruby193/root/usr/share/gems/gems/rack-cache-1.2/lib/rack/cache/context.rb:51:in `call'
/opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/action_dispatch/middleware/best_standards_support.rb:17:in `call'
/opt/rh/ruby193/root/usr/share/gems/gems/rack-1.4.5/lib/rack/etag.rb:23:in `call'
/opt/rh/ruby193/root/usr/share/gems/gems/rack-1.4.5/lib/rack/conditionalget.rb:35:in `call'
/opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/action_dispatch/middleware/head.rb:14:in `call'
/opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/action_dispatch/middleware/params_parser.rb:21:in `call'
/opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/action_dispatch/middleware/flash.rb:242:in `call'
/opt/rh/ruby193/root/usr/share/gems/gems/rack-1.4.5/lib/rack/session/abstract/id.rb:210:in `context'
/opt/rh/ruby193/root/usr/share/gems/gems/rack-1.4.5/lib/rack/session/abstract/id.rb:205:in `call'
/opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/action_dispatch/middleware/cookies.rb:341:in `call'
/opt/rh/ruby193/root/usr/share/gems/gems/activerecord-3.2.17/lib/active_record/query_cache.rb:64:in `call'
/opt/rh/ruby193/root/usr/share/gems/gems/activerecord-3.2.17/lib/active_record/connection_adapters/abstract/connection_pool.rb:479:in `call'
/opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/action_dispatch/middleware/callbacks.rb:28:in `block in call'
/opt/rh/ruby193/root/usr/share/gems/gems/activesupport-3.2.17/lib/active_support/callbacks.rb:405:in `_run__829269622377087261__call__2416397144724110994__callbacks'
/opt/rh/ruby193/root/usr/share/gems/gems/activesupport-3.2.17/lib/active_support/callbacks.rb:405:in `__run_callback'
/opt/rh/ruby193/root/usr/share/gems/gems/activesupport-3.2.17/lib/active_support/callbacks.rb:385:in `_run_call_callbacks'
/opt/rh/ruby193/root/usr/share/gems/gems/activesupport-3.2.17/lib/active_support/callbacks.rb:81:in `run_callbacks'
/opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/action_dispatch/middleware/callbacks.rb:27:in `call'
/opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/action_dispatch/middleware/remote_ip.rb:31:in `call'
/opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/action_dispatch/middleware/debug_exceptions.rb:16:in `call'
/opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/action_dispatch/middleware/show_exceptions.rb:56:in `call'
/opt/rh/ruby193/root/usr/share/gems/gems/railties-3.2.17/lib/rails/rack/logger.rb:32:in `call_app'
/opt/rh/ruby193/root/usr/share/gems/gems/railties-3.2.17/lib/rails/rack/logger.rb:18:in `call'
/opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/action_dispatch/middleware/request_id.rb:22:in `call'
/opt/rh/ruby193/root/usr/share/gems/gems/rack-1.4.5/lib/rack/methodoverride.rb:21:in `call'
/opt/rh/ruby193/root/usr/share/gems/gems/rack-1.4.5/lib/rack/runtime.rb:17:in `call'
/opt/rh/ruby193/root/usr/share/gems/gems/activesupport-3.2.17/lib/active_support/cache/strategy/local_cache.rb:72:in `call'
/opt/rh/ruby193/root/usr/share/gems/gems/rack-1.4.5/lib/rack/lock.rb:15:in `call'
/opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.17/lib/action_dispatch/middleware/static.rb:63:in `call'
/opt/rh/ruby193/root/usr/share/gems/gems/railties-3.2.17/lib/rails/engine.rb:484:in `call'
/opt/rh/ruby193/root/usr/share/gems/gems/railties-3.2.17/lib/rails/application.rb:231:in `call'
/opt/rh/ruby193/root/usr/share/gems/gems/rack-1.4.5/lib/rack/content_length.rb:14:in `call'
/opt/rh/ruby193/root/usr/share/gems/gems/railties-3.2.17/lib/rails/rack/log_tailer.rb:17:in `call'
/opt/rh/ruby193/root/usr/share/gems/gems/thin-1.3.1/lib/thin/connection.rb:80:in `block in pre_process'
/opt/rh/ruby193/root/usr/share/gems/gems/thin-1.3.1/lib/thin/connection.rb:78:in `catch'
/opt/rh/ruby193/root/usr/share/gems/gems/thin-1.3.1/lib/thin/connection.rb:78:in `pre_process'
/opt/rh/ruby193/root/usr/share/gems/gems/thin-1.3.1/lib/thin/connection.rb:53:in `process'
/opt/rh/ruby193/root/usr/share/gems/gems/thin-1.3.1/lib/thin/connection.rb:38:in `receive_data'
/opt/rh/ruby193/root/usr/share/gems/gems/eventmachine-1.0.0/lib/eventmachine.rb:187:in `run_machine'
/opt/rh/ruby193/root/usr/share/gems/gems/eventmachine-1.0.0/lib/eventmachine.rb:187:in `run'
/opt/rh/ruby193/root/usr/share/gems/gems/thin-1.3.1/lib/thin/backends/base.rb:61:in `start'
/opt/rh/ruby193/root/usr/share/gems/gems/thin-1.3.1/lib/thin/server.rb:159:in `start'
/opt/rh/ruby193/root/usr/share/gems/gems/rack-1.4.5/lib/rack/handler/thin.rb:13:in `run'
/opt/rh/ruby193/root/usr/share/gems/gems/rack-1.4.5/lib/rack/server.rb:268:in `start'
/opt/rh/ruby193/root/usr/share/gems/gems/railties-3.2.17/lib/rails/commands/server.rb:70:in `start'
/opt/rh/ruby193/root/usr/share/gems/gems/railties-3.2.17/lib/rails/commands.rb:55:in `block in <top (required)>'
/opt/rh/ruby193/root/usr/share/gems/gems/railties-3.2.17/lib/rails/commands.rb:50:in `tap'
/opt/rh/ruby193/root/usr/share/gems/gems/railties-3.2.17/lib/rails/commands.rb:50:in `<top (required)>'
script/rails:6:in `require'
script/rails:6:in `<main>'
[----] I, [2015-02-06T16:29:49.144227 #2496:e53030]  INFO -- :   Rendered layouts/_exception_contents.html.erb (0.6ms)
[----] I, [2015-02-06T16:29:49.144912 #2496:e53030]  INFO -- : Completed 200 OK in 106.7ms (Views: 10.4ms | ActiveRecord: 0.0ms)

Comment 3 CFME Bot 2015-02-09 20:55:47 UTC
New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/542b4677b59258dd62503dbba3cf61a4b26049ed

commit 542b4677b59258dd62503dbba3cf61a4b26049ed
Author:     Dan Clarizio <dclarizi>
AuthorDate: Fri Feb 6 15:55:08 2015 -0800
Commit:     Dan Clarizio <dclarizi>
CommitDate: Mon Feb 9 12:51:05 2015 -0800

    Clean up the allowed routes for all of the controllers that run dialogs
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1190211
    https://bugzilla.redhat.com/show_bug.cgi?id=1190300

 vmdb/config/routes.rb                              | 67 ++++++++--------------
 vmdb/spec/routing/catalog_routing_spec.rb          |  3 -
 vmdb/spec/routing/ems_cloud_routing_spec.rb        |  1 +
 vmdb/spec/routing/ems_cluster_routing_spec.rb      |  6 ++
 vmdb/spec/routing/ems_infra_routing_spec.rb        |  2 +
 vmdb/spec/routing/host_routing_spec.rb             | 12 ----
 vmdb/spec/routing/service_routing_spec.rb          | 14 -----
 .../shared_examples/dialog_runner_examples.rb      |  2 +
 vmdb/spec/routing/storage_routing_spec.rb          |  6 ++
 9 files changed, 42 insertions(+), 71 deletions(-)

Comment 4 CFME Bot 2015-02-09 22:00:50 UTC
New commit detected on cfme/5.3.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=d3dd48e2f7c5c6a16d5aef64effc5699e696c59c

commit d3dd48e2f7c5c6a16d5aef64effc5699e696c59c
Author:     Dan Clarizio <dclarizi>
AuthorDate: Mon Feb 9 13:58:49 2015 -0800
Commit:     Dan Clarizio <dclarizi>
CommitDate: Mon Feb 9 13:58:49 2015 -0800

    Clean up the allowed routes for all of the controllers that run dialogs
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1190211
    https://bugzilla.redhat.com/show_bug.cgi?id=1190300

 vmdb/config/routes.rb                         | 16 +++++++++++++++-
 vmdb/spec/routing/ems_cloud_routing_spec.rb   |  3 +++
 vmdb/spec/routing/ems_cluster_routing_spec.rb | 24 ++++++++++++++++++++++++
 vmdb/spec/routing/ems_infra_routing_spec.rb   |  4 ++++
 vmdb/spec/routing/storage_routing_spec.rb     | 18 ++++++++++++++++++
 5 files changed, 64 insertions(+), 1 deletion(-)

Comment 6 Shveta 2015-03-12 23:25:31 UTC
Fixed.
Verified in 5.4.0.0.11.20150309201930_8b6a235

Comment 8 errata-xmlrpc 2015-06-16 12:49:27 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-1100.html