Bug 1190323

Summary: On 'Discovery_rule page, host limit should be marked as mandatory variable and validation error needs to be rephrased
Product: Red Hat Satellite Reporter: Sachin Ghai <sghai>
Component: WebUIAssignee: orabin
WebUI sub component: Foreman QA Contact: Sachin Ghai <sghai>
Status: CLOSED ERRATA Docs Contact:
Severity: medium    
Priority: unspecified CC: bkearney, jmontleo
Version: 6.1.0Keywords: Triaged
Target Milestone: Unspecified   
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
URL: http://projects.theforeman.org/issues/9366
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-08-12 05:23:58 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1193977    
Attachments:
Description Flags
host limit is not marked as mandatory variable with (*).Also, If I set the host_limit blank, UI raises error "is not a number". which is misleading. none

Description Sachin Ghai 2015-02-07 07:40:21 UTC
Created attachment 989128 [details]
host limit is not marked as mandatory variable with (*).Also, If I set the host_limit blank, UI raises error "is not a number". which is misleading.

Description of problem:
On 'Discovery_rule page, host limit should be marked as mandatory variable with (*). 

If I set the host_limit blank, UI raises error "is not a number".
which is misleading. I set the host_limit blank, so Ideally UI should raise error: Host_limit can't be blank.

In short Host_limit should be consistent with Priority field.

Version-Release number of selected component (if applicable):
Satellite-6.1.0-RHEL-6-20150205.0
Sat6.1 Beta snap1 compose3

How reproducible:
always

Steps to Reproduce:
1. create a  discovery rule with blank host_limit
2.
3.

Actual results:
 host limit is not marked as mandatory variable with (*). 

If I set the host_limit blank, UI raises error "is not a number".
which is misleading. 

Expected results:
Host limit should be marked as mandatory variable with (*). 

If I set the host_limit blank, so Ideally UI should raise error: Host_limit can't be blank.

Additional info:

Comment 2 Bryan Kearney 2015-02-23 15:05:00 UTC
Upstream bug assigned to orabin

Comment 3 Bryan Kearney 2015-02-23 15:05:01 UTC
Upstream bug assigned to orabin

Comment 4 Bryan Kearney 2015-03-16 14:05:04 UTC
Moving to POST since upstream bug http://projects.theforeman.org/issues/9366 has been closed
-------------
Ori Rabin
Applied in changeset commit:foreman_discovery|4c104cf6b66cf35931153e7d5643f6defd5d96a3.

Comment 7 Sachin Ghai 2015-04-08 09:52:15 UTC
Verified with snap11/rc5 (Satellite-6.1.0-RHEL-7-20150407.1).

Now if user leaves the host limit blank then UI auto sets the limit to '0' '0'== unlimited. Moving this to verified.

Comment 8 Bryan Kearney 2015-08-11 13:26:27 UTC
This bug is slated to be released with Satellite 6.1.

Comment 9 errata-xmlrpc 2015-08-12 05:23:58 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2015:1592