Bug 1190450

Summary: SCM build fails with "CRITICAL: No package specified to rebuild command."
Product: [Fedora] Fedora Reporter: Matt McCutchen <matt>
Component: mockAssignee: Clark Williams <williams>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 20CC: andy, eric, haim, jdisnard, john, mbaudier, mebrown, msimacek, msuchy, praiskup, rbonser, williams, xavier
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: mock-1.2.10-1.el7 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-05-01 16:51:01 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Fix none

Description Matt McCutchen 2015-02-08 01:09:56 UTC
Created attachment 989304 [details]
Fix

Description of problem:
Mock SCM builds fail because the do_buildsrpm function does not return the path to the SRPM to be passed to do_rebuild.  The attached patch fixes the problem.

Version-Release number of selected component (if applicable):
mock-1.2.4-1.fc20.noarch

How reproducible:
Always

Steps to Reproduce:
1. In /etc/mock/site-defaults.cfg, uncomment the git_get line and replace "localhost" with "pkgs.fedoraproject.org".
2. mock -r fedora-20-x86_64 --scm-enable --scm-option package=basesystem --resultdir=$PWD/basesystem.mockresult

Actual results:
[...]
Finish: buildsrpm
INFO: Done(/tmp/tmp_i8GfQ.mock-scm.basesystem/basesystem/basesystem.spec) Config(fedora-20-x86_64) 4 minutes 41 seconds
INFO: Results and/or logs in: /home/user/test/mock-scm/basesystem.mockresult
INFO: Cleaning up build root ('cleanup_on_success=True')
Start: clean chroot
Finish: clean chroot
CRITICAL: No package specified to rebuild command.

Expected results:
Successful build.

Comment 1 Andy Thompson 2015-03-21 15:44:44 UTC
I was able to reproduce the bug. It was introduced as part of git commit c16d4a528bc7b4eae8dc7bbb23ba333d2c431b06, where the original before refactoring returned a result. The patch Matt attached has fixed it for me.

Comment 2 Eric Schnoebelen 2015-03-26 20:17:09 UTC
I have also encountered this.  My bug, with patch, is https://bugzilla.redhat.com/show_bug.cgi?id=1202574

Comment 3 Clark Williams 2015-04-16 20:36:37 UTC
*** Bug 1202574 has been marked as a duplicate of this bug. ***

Comment 4 Miroslav Suchý 2015-04-23 14:39:24 UTC
Fixed in commit:
* 4a1c59e Return the SRPM name from do_buildsrpm (required for SCM builds) [1190450]

Comment 5 Fedora Update System 2015-04-29 13:16:45 UTC
mock-1.2.8-1.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/mock-1.2.8-1.fc22

Comment 6 Fedora Update System 2015-04-29 13:17:09 UTC
mock-1.2.8-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/mock-1.2.8-1.fc21

Comment 7 Fedora Update System 2015-04-29 13:18:17 UTC
mock-1.2.8-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/mock-1.2.8-1.fc20

Comment 8 Fedora Update System 2015-04-29 13:19:14 UTC
mock-1.2.8-1.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/mock-1.2.8-1.el7

Comment 9 Fedora Update System 2015-04-29 13:25:55 UTC
mock-1.2.8-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/mock-1.2.8-1.el6

Comment 10 Fedora Update System 2015-04-29 19:18:56 UTC
Package mock-1.2.8-1.el7:
* should fix your issue,
* was pushed to the Fedora EPEL 7 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=epel-testing mock-1.2.8-1.el7'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-EPEL-2015-6057/mock-1.2.8-1.el7
then log in and leave karma (feedback).

Comment 11 Fedora Update System 2015-05-01 16:51:01 UTC
mock-1.2.8-1.fc22 has been pushed to the Fedora 22 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 12 Fedora Update System 2015-05-02 18:08:40 UTC
mock-1.2.8-1.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2015-05-12 20:47:20 UTC
mock-1.2.8-1.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2015-06-04 11:41:50 UTC
mock-1.2.10-1.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/mock-1.2.10-1.el7

Comment 15 Fedora Update System 2015-06-04 11:42:31 UTC
mock-1.2.10-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/mock-1.2.10-1.el6

Comment 16 Fedora Update System 2015-06-20 21:10:01 UTC
mock-1.2.10-1.el6 has been pushed to the Fedora EPEL 6 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 17 Fedora Update System 2015-06-20 21:13:13 UTC
mock-1.2.10-1.el7 has been pushed to the Fedora EPEL 7 stable repository.  If problems still persist, please make note of it in this bug report.