Bug 1190742
| Summary: | [vdsm] live snapshot creation fails on block storage with unsupported configuration: source for disk 'vda' is not a regular file; refusing to generate external snapshot name | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Virtualization Manager | Reporter: | Amador Pahim <asegundo> |
| Component: | vdsm | Assignee: | Adam Litke <alitke> |
| Status: | CLOSED ERRATA | QA Contact: | Aharon Canan <acanan> |
| Severity: | urgent | Docs Contact: | |
| Priority: | urgent | ||
| Version: | 3.4.4 | CC: | adahms, alitke, amureini, asegundo, bazulay, bmcclain, ebenahar, eblake, ecohen, eedri, fdeutsch, gklein, iheim, jentrena, jraju, lpeer, lsurette, mgoldboi, michal.skrivanek, mkalinin, mtessun, ogofen, pablo.iranzo, pkrempa, rbalakri, rhodain, sherold, tdosek, tnisan, yeylon, ylavi |
| Target Milestone: | --- | Keywords: | Regression, ZStream |
| Target Release: | 3.4.5-1 | Flags: | ylavi:
Triaged+
|
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | storage | ||
| Fixed In Version: | vdsm-4.14.18-7.el6ev | Doc Type: | Bug Fix |
| Doc Text: |
This update fixes an issue that prevented the creation of live snapshots on block storage devices with Red Hat Enterprise Linux hosts version 6.5 and 6.6. Virtual machines that have encountered this issue in Red Hat Enterprise Virtualization 3.4.5 must be restarted for the fix to take effect.
|
Story Points: | --- |
| Clone Of: | 1115126 | Environment: | |
| Last Closed: | 2015-03-15 20:24:17 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | Storage | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1115126 | ||
| Bug Blocks: | 1119691 | ||
Amador, this is a request to backport to 3.4.z stream? 3.5 contains the mentioned patch. Did you misreport the version? Seems so since we already have it on 3.5 and on master, moving to 3.4.6 (In reply to Michal Skrivanek from comment #3) > Amador, > this is a request to backport to 3.4.z stream? > 3.5 contains the mentioned patch. Did you misreport the version? Yes, it's intended to 3.4.z. I don't have such flag available... thank you for fixing. (added 3.5 and 3.6 for verification, no code change needed) *** Bug 1190571 has been marked as a duplicate of this bug. *** yes. bronce, can you add the new version please? Live snapshot succeeds succeeds, along with live storage migration. Tested on both block and file storage. Also, an attempt to create a live snapshot/perform LSM for a VM that had such failure before, will fail with 'The base volume doesn't exist' error. A workaround for that is to restart the VM. Verified using rhev 3.4.5-1 av14.3 vdsm-4.14.18-7.el6ev.x86_64 libvirt-0.10.2-46.el6_6.1.x86_64 qemu-kvm-rhev-0.12.1.2-2.448.el6.x86_64 Tested also using RHEL 7.0 vdsm-4.14.18-7.el7ev.x86_64 libvirt-1.1.1-29.el7_0.7.x86_64 qemu-kvm-rhev-1.5.3-60.el7_0.11.x86_64 |
vdsm-4.14.18-6.el6ev.x86_64 is facing this issue: ------------------------------------------------ /usr/share/vdsm/vm.py vdsm-4.14.18-4.el6ev.x86_64 ... def _diskSnapshot(vmDev, newPath): """Libvirt snapshot XML""" disk = XMLElement('disk', name=vmDev, snapshot='external') disk.appendChildWithArgs('source', file=newPath) return disk ... vdsm-4.14.18-6.el6ev.x86_64 ... def _diskSnapshot(vmDev, newPath, sourceType): """Libvirt snapshot XML""" disk = XMLElement('disk', name=vmDev, snapshot='external', type=sourceType) if sourceType == 'block': args = {'dev': newPath} elif sourceType == 'file': args = {'file': newPath} args['type'] = sourceType disk.appendChildWithArgs('source', **args) return disk ... ------------------------------------------------ Please backport http://gerrit.ovirt.org/#/c/29567/ -- apahim