Bug 1190826
Summary: | Changes lost when editing LDAP Host Names | ||
---|---|---|---|
Product: | Red Hat CloudForms Management Engine | Reporter: | Milan Zázrivec <mzazrivec> |
Component: | UI - OPS | Assignee: | Milan Zázrivec <mzazrivec> |
Status: | CLOSED ERRATA | QA Contact: | Jan Krocil <jkrocil> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | 5.3.0 | CC: | atopp, bmoss, dajohnso, jhardy, jkrocil, jprause, mfeifer, obarenbo, xlecauch |
Target Milestone: | GA | Keywords: | ZStream |
Target Release: | 5.3.3 | ||
Hardware: | x86_64 | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: |
When making changes to LDAP Host Names in the CFME UI using Configure -> Configuration -> Settings -> Server -> Authentication, the last change is not saved. Depending on the changes, this caused LDAP authentication to fail. The code has been updated not to delete from an array while iterating through it. LDAP Authentication changes are now saved successfully.
|
Story Points: | --- |
Clone Of: | 1190054 | Environment: | |
Last Closed: | 2015-02-25 16:13:03 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 1190054 | ||
Bug Blocks: |
Comment 1
Milan Zázrivec
2015-02-09 16:56:41 UTC
New commit detected on cfme/5.3.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=c2e94acb9d325f6f1eed9d906c6dbffc086f17af commit c2e94acb9d325f6f1eed9d906c6dbffc086f17af Author: Milan Zazrivec <mzazrivec> AuthorDate: Mon Feb 9 12:58:02 2015 +0100 Commit: Milan Zazrivec <mzazrivec> CommitDate: Mon Feb 9 17:55:57 2015 +0100 Fix LDAP Authentication settings We cannot delete from an array while iterating through it. https://bugzilla.redhat.com/show_bug.cgi?id=1190826 (cherry picked from commit d2e3be729de222b024391505a119d17cd37b44d9) Conflicts: vmdb/app/controllers/ops_controller/settings/common.rb vmdb/app/controllers/ops_controller/settings/common.rb | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) Couldn't verify in 5.3.3.1 - 5.3.3.1.20150210145146_14d1c48. The code fix is present in 5.3.z, but the LDAP host fields are still acting very strange and unpredictable (old values coming back into the fields). The problematic scenario here is: 1. fill in all ldap servers, e.g. lap01, lap02, ldap03 2. hit save 3. delete ldap02 4. delete ldap03 5. hit save 6. see that ldap01 and ldap03 are in place Fix for the problem described one comment earlier: https://github.com/ManageIQ/manageiq/pull/1704 New commit detected on manageiq/master: https://github.com/ManageIQ/manageiq/commit/0db93617170e5d4f0a00b91053c7632ca474a013 commit 0db93617170e5d4f0a00b91053c7632ca474a013 Author: Milan Zazrivec <mzazrivec> AuthorDate: Mon Feb 16 13:43:28 2015 +0100 Commit: Milan Zazrivec <mzazrivec> CommitDate: Mon Feb 16 13:43:28 2015 +0100 Fix configuration of LDAP authentication The buggy scenario was: 1. Configure LDAP authentication, fill in all three fields for LDAP host names, e.g. ldap01, ldap02, ldap03 2. Hit save button 3. Delete ldap02 4. Delete ldap03 5. Hit save button 6. ldap01 and ldap03 would show in the list https://bugzilla.redhat.com/show_bug.cgi?id=1190826 vmdb/app/controllers/ops_controller/settings/common.rb | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) cfme.git 5.3.z: 740ebb1b9153445904bdbef56a97449c06a04665 New commit detected on cfme/5.3.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=740ebb1b9153445904bdbef56a97449c06a04665 commit 740ebb1b9153445904bdbef56a97449c06a04665 Author: Milan Zazrivec <mzazrivec> AuthorDate: Mon Feb 16 13:43:28 2015 +0100 Commit: Milan Zazrivec <mzazrivec> CommitDate: Tue Feb 17 11:06:45 2015 +0100 Fix configuration of LDAP authentication The buggy scenario was: 1. Configure LDAP authentication, fill in all three fields for LDAP host names, e.g. ldap01, ldap02, ldap03 2. Hit save button 3. Delete ldap02 4. Delete ldap03 5. Hit save button 6. ldap01 and ldap03 would show in the list https://bugzilla.redhat.com/show_bug.cgi?id=1190826 (cherry picked from commit 0db93617170e5d4f0a00b91053c7632ca474a013) Conflicts: vmdb/app/controllers/ops_controller/settings/common.rb vmdb/app/controllers/ops_controller/settings/common.rb | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Milan: Can you cherry-pick this into the 5.3.3 branch. The branch is open. New commit detected on cfme/5.3.3: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=25d1f2031cdb38da8759a11e28044f342ab24ca4 commit 25d1f2031cdb38da8759a11e28044f342ab24ca4 Author: Milan Zazrivec <mzazrivec> AuthorDate: Mon Feb 16 13:43:28 2015 +0100 Commit: Milan Zazrivec <mzazrivec> CommitDate: Tue Feb 17 16:59:54 2015 +0100 Fix configuration of LDAP authentication The buggy scenario was: 1. Configure LDAP authentication, fill in all three fields for LDAP host names, e.g. ldap01, ldap02, ldap03 2. Hit save button 3. Delete ldap02 4. Delete ldap03 5. Hit save button 6. ldap01 and ldap03 would show in the list https://bugzilla.redhat.com/show_bug.cgi?id=1190826 (cherry picked from commit 0db93617170e5d4f0a00b91053c7632ca474a013) Conflicts: vmdb/app/controllers/ops_controller/settings/common.rb (cherry picked from commit 740ebb1b9153445904bdbef56a97449c06a04665) vmdb/app/controllers/ops_controller/settings/common.rb | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Verified - fixed in 5.3.3.2 (5.3.3.2.20150217120931_a465215). Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2015-0261.html |