Bug 1191112
Summary: | RFE: Indicate that <tab> is used to navigate | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Pierre-YvesChibon <pingou> | ||||
Component: | powertop | Assignee: | Jaroslav Škarvada <jskarvad> | ||||
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | unspecified | Docs Contact: | |||||
Priority: | unspecified | ||||||
Version: | rawhide | CC: | jskarvad, metherid | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2015-02-11 20:15:44 UTC | Type: | Bug | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
Pierre-YvesChibon
2015-02-10 13:32:21 UTC
Offer a fix upstream: https://github.com/fenrus75/powertop/pull/19 Thanks for the report and patch. Please also add "Shift + Tab". I will apply your patch downstream. (In reply to Jaroslav Škarvada from comment #2) > Please also add "Shift + Tab". > I.e: + mvwprintw(bottom_line, 0,0, _("<ESC> Exit | <TAB> / <Shift + TAB> Navigate |")); or similarly. Updated on github. Btw, are you on the upstream mailing-list? It seems to be the place to submit patches but I am not subscribed and do not feel like doing so just for a patch. (In reply to Pierre-YvesChibon from comment #4) > Updated on github. > Thanks. > Btw, are you on the upstream mailing-list? > Yes. > It seems to be the place to submit patches but I am not subscribed and do > not feel like doing so just for a patch. > In the past Arjan also merged pull requests from github without problem, I don't know whether Alexandra do the same. But no problem, I will forward your patch there. At least it will get more attention. IIRC it was also possible to send to the list without registration (moderated). Created attachment 990432 [details] Proposed patch (In reply to Pierre-YvesChibon from comment #4) I think the patch can be still improved. This mod could ease the translation, please update the pull request. I haven't sent the patch upstream yet, feel free to send it yourself, or let me know if you need forward. Thanks for the change, I had started with something like this but I was not sure the two `%s` were valid (and how to specify the two arguments), so instead I used the same approach as elsewhere in the code: src/tuning/tuning.cpp: create_tab("Tunables", _("Tunables"), w, _(" <ESC> Exit | <Enter> Toggle tunable | <r> Window refresh")); Shall I just incorporate your changes into a commit in my branch, or do you want to send me a git format-patch (thus keeping the attribution to you :)) (In reply to Pierre-YvesChibon from comment #7) > Thanks for the change, I had started with something like this but I was not > sure the two `%s` were valid (and how to specify the two arguments), so > instead I used the same approach as elsewhere in the code: > > src/tuning/tuning.cpp: create_tab("Tunables", _("Tunables"), w, _(" <ESC> > Exit | <Enter> Toggle tunable | <r> Window refresh")); Of course, the coding style of the project is probably inconsistent (as usually :), but the proposed change is definitely better for translators. (In reply to Pierre-YvesChibon from comment #8) > Shall I just incorporate your changes into a commit in my branch, or do you > want to send me a git format-patch (thus keeping the attribution to you :)) Just incorporate the change. I send dozens patches daily to different projects, so no need to attribute simple improvement of UI improving one-liner (or nearly one-liner :) Thanks, pull-request updated! :) Upstream is asking on github for the patch to be sent to the list. Is this something you could do? (In reply to Pierre-YvesChibon from comment #12) > Upstream is asking on github for the patch to be sent to the list. Is this > something you could do? NP, forwarded. Thanks! |