Bug 1191514
| Summary: | Missing storage related VDSM error codes | ||
|---|---|---|---|
| Product: | [oVirt] vdsm | Reporter: | David Caro <dcaroest> |
| Component: | General | Assignee: | Amit Aviram <aaviram> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Aharon Canan <acanan> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | --- | CC: | aaviram, acanan, amureini, bazulay, bugs, danken, eedri, gklein, lsurette, mgoldboi, rbalakri, sabose, sbonazzo, srevivo, ykaul, ylavi |
| Target Milestone: | ovirt-4.0.0-alpha | Keywords: | AutomationBlocker, Reopened |
| Target Release: | 4.17.999 | Flags: | ylavi:
ovirt-4.0.0?
ylavi: planning_ack+ rule-engine: devel_ack+ rule-engine: testing_ack? |
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | ovirt 4.0.0 alpha1 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-07-19 13:09:42 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | Storage | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
David Caro
2015-02-11 12:27:06 UTC
more info can be found on the ci job: http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6447/console From the jenkins job desc: The purpose of this jenkins job is verify each error code reported by VDSM has a correlated message on the engine side, else we get the 'Unexpected error'. The missing error code should be added to: ovirt-engine/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java and the error message to: ovirt-engine/backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties If a specific VDSM error code should not be reported by VDSM and needed to be ignored, we can add it to the 'ignored list' of the jenkins job. Referenced patches cover the missing error codes in this bug. Job seems to be failing with - 15:53:03 missing error code: [ 2 ] from: 15:53:04 Build step 'Execute shell' marked build as failure Seems like a different issue? Bug tickets that are moved to testing must have target release set to make sure tester knows what to test. Please set the correct target release before moving to ON_QA. Bug tickets that are moved to testing must have target release set to make sure tester knows what to test. Please set the correct target release before moving to ON_QA. first the job needs to be fixed, then we can verify. http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6524/console Danken, who can look at the error? 09:41:16 > /usr/bin/git clean -fdx # timeout=10 09:41:16 No emails were triggered. 09:41:16 [vdsm_master_verify-error-codes_merged] $ /bin/sh /tmp/hudson7178255801835765072.sh 09:41:16 /home/jenkins/workspace/vdsm_master_verify-error-codes_merged/ovirt-engine/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java does not exist I believe the files has been renamed to backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineError.java in commit 091009d. job still fails on: http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6525/console 11:27:03 Ignored error codes: 701 4100 4101 4102 4103 4104 4105 4106 4107 4111 4112 4113 4114 4115 4116 4117 4118 4119 4120 4121 4123 4124 4126 4129 4130 4132 4133 4134 4136 4141 4143 4147 4400 4401 4402 4403 4405 4137 4138 4140 4144 4145 4146 4148 4150 4152 4153 11:27:04 missing error code: [ 900 ] from: /home/jenkins/workspace/vdsm_master_verify-error-codes_merged/vdsm/vdsm/storage/storage_exception.py: code = 900 11:27:04 missing error code: [ 4577 ] from: /home/jenkins/workspace/vdsm_master_verify-error-codes_merged/vdsm/vdsm/gluster/exception.py: code = 4577 11:27:04 missing error code: [ 4578 ] from: /home/jenkins/workspace/vdsm_master_verify-error-codes_merged/vdsm/vdsm/gluster/exception.py: code = 4578 11:27:04 missing error code: [ 4579 ] from: /home/jenkins/workspace/vdsm_master_verify-error-codes_merged/vdsm/vdsm/gluster/exception.py: code = 4579 The three new gluster codes, and most probably the storage one, should be added to Engine. Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release. Three gluster codes are already added. Allon can you move to ON_QA if storage code is merged This bug is not marked for z-stream, yet the milestone is for a z-stream version, therefore the milestone has been reset. Please set the correct milestone or add the z-stream flag. (In reply to Sahina Bose from comment #17) > Three gluster codes are already added. > Allon can you move to ON_QA if storage code is merged The patch for the missing storage error (900) has been merged to master and ovirt-engine-3.6. branches., setting to MODIFIED. When a 3.6.3 build is made, the build process should automatically move it to ON_QA. good news! job passed: http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6553/console not sure if the bug should move to VERIFIED. we still skip these codes: Ignored error codes: 701 4100 4101 4102 4103 4104 4105 4106 4107 4111 4112 4113 4114 4115 4116 4117 4118 4119 4120 4121 4123 4124 4126 4129 4130 4132 4133 4134 4136 4141 4143 4147 4400 4401 4402 4403 4405 4137 4138 4140 4144 4145 4146 4148 4150 4152 4153 (In reply to Eyal Edri from comment #20) > good news! > job passed: > http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6553/ > console > > not sure if the bug should move to VERIFIED. > > we still skip these codes: > Ignored error codes: 701 4100 4101 4102 4103 4104 4105 4106 4107 4111 4112 > 4113 4114 4115 4116 4117 4118 4119 4120 4121 4123 4124 4126 4129 4130 4132 > 4133 4134 4136 4141 4143 4147 4400 4401 4402 4403 4405 4137 4138 4140 4144 > 4145 4146 4148 4150 4152 4153 Allon? Job was disabled due to errors http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/ current missing: 08:29:49 missing error code: [ 481 ] from: /home/jenkins/workspace/vdsm_master_verify-error-codes_merged/vdsm/vdsm/storage/storage_exception.py: code = 481 08:29:49 missing error code: [ 482 ] from: /home/jenkins/workspace/vdsm_master_verify-error-codes_merged/vdsm/vdsm/storage/storage_exception.py: code = 482 08:29:49 missing error code: [ 483 ] from: /home/jenkins/workspace/vdsm_master_verify-error-codes_merged/vdsm/vdsm/storage/storage_exception.py: code = 483 Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release. (In reply to Eyal Edri from comment #23) > Job was disabled due to errors > http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/ > > current missing: > > 08:29:49 missing error code: [ 481 ] from: > /home/jenkins/workspace/vdsm_master_verify-error-codes_merged/vdsm/vdsm/ > storage/storage_exception.py: code = 481 > 08:29:49 missing error code: [ 482 ] from: > /home/jenkins/workspace/vdsm_master_verify-error-codes_merged/vdsm/vdsm/ > storage/storage_exception.py: code = 482 > 08:29:49 missing error code: [ 483 ] from: > /home/jenkins/workspace/vdsm_master_verify-error-codes_merged/vdsm/vdsm/ > storage/storage_exception.py: code = 483 These are new image-upload related issues - Amit, please add these to the engine. Regardless, I think it's time to dump this job. It just adds noise to the dev. process instead of finding actual useful issues. Allon, If this job has no value to the product, we can remove it, let me know. For now it was disabled until fixed. This fix was already merged in https://gerrit.ovirt.org/#/c/53204/ at Feb8 Just to verify, the job was tested again: http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6659/console From my side you can enable this test, if you decide it should be added to the tests flow. Allon - Do you think we are ok based on comment #27 ? I have no way to verify anyway. Eyal - does it work for you now? (In reply to Aharon Canan from comment #29) > Allon - > > Do you think we are ok based on comment #27 ? I have no way to verify anyway. > > Eyal - > does it work for you now? If the CI doesn't complain about this, we can CLOSE CURRENTRELEASE, IMO. http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/ job is stable, so +1 on closing. based on Comment #30 and #31 Closing. |