Bug 1192039

Summary:	Retirement Entry Point not invoked upon Service Retirement
Product:	Red Hat CloudForms Management Engine	Reporter:	Krain Arnold <krain>
Component:	Automate	Assignee:	mkanoor
Status:	CLOSED ERRATA	QA Contact:	Dave Johnson <dajohnso>
Severity:	high	Docs Contact:
Priority:	high
Version:	5.3.0	CC:	jhardy, jmarc, mfeifer, mkanoor, obarenbo, snansi, sshveta, xlecauch
Target Milestone:	GA
Target Release:	5.4.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:	This version of CloudForms Management Engine adds the ability to add additional disks to an instance while provisioning. This has been implemented by adding a clone_options key into the hash of task options, that gets merged into the parameters passed to the provider. This will allow the user to construct the keys and values required to define new disks as well as override or set other keys if needed.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-06-16 12:50:34 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1139277

Description Krain Arnold 2015-02-12 13:29:06 UTC

Description of problem:
If a catalog item is created with a Retirement entry point as per the Lifecycle and Automation Guide, the default retirement entry point is still invoked.

Version-Release number of selected component (if applicable):
all releases

How reproducible:
100%

Steps to Reproduce:
1.Create a catalog item and configure a Retirement Entry Point named anything but Default (/Service/Retirement/StateMachines/ServiceRetirement/custom_instance)
2.Retire the Service


Actual results:
the /Service/Retirement/StateMachines/ServiceRetirement/Default is invoked regardless of the value in the Retirement Entry Point of the Catalog

Expected results:
The Retirement Entry Point that was entered when the catalog was created (/Service/Retirement/StateMachines/ServiceRetirement/custom_instance) should be invoked.

Additional info:
You are able to copy and override the Default Instance and make changes to it, which will be executed, but if the instance is named anything but Default, the Default instance will be invoked.

Comment 2 CFME Bot 2015-03-11 21:36:12 UTC

New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/28418f8a64a8fd69c4cb6a54ebaf92f4c210796e

commit 28418f8a64a8fd69c4cb6a54ebaf92f4c210796e
Author:     Madhu Kanoor <mkanoor>
AuthorDate: Tue Mar 10 11:13:31 2015 -0400
Commit:     Madhu Kanoor <mkanoor>
CommitDate: Wed Mar 11 12:15:24 2015 -0400

    Service Retirement Entry Point
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1192039
    
    Allows for customers to change the Automate state machine that
    gets called during Service Retirment. If one is not specified we
    default to /Service/Retirement/StateMachines/ServiceRetirement/Default

 .../__methods__/get_retirement_entrypoint.rb       | 22 ++++++++--------------
 .../System/Event.class/request_service_retire.yaml |  4 +++-
 2 files changed, 11 insertions(+), 15 deletions(-)

Comment 4 mkanoor 2015-04-02 14:05:39 UTC

Dave,
The retirement model is different between 5.4 and 5.3 so it won't be a straight cherry pick, we would have to make a specific patch for 5.3 if its needed.
Please let me know if this needs to be fixed in 5.3?
Thanks,
Madhu

Comment 6 Shveta 2015-04-20 22:39:04 UTC

retirement_entrypoint: /Default/Service/Retirement/StateMachines/ServiceRetirement/custome_instance 

is executed .
Verified in 5.4.0.0.19.20150410165622_ad23806

Comment 8 errata-xmlrpc 2015-06-16 12:50:34 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-1100.html