Bug 1193210

Summary:	Review Request: sxc - Simple XML Compiler
Product:	[Fedora] Fedora	Reporter:	gil cattaneo <puntogil>
Component:	Package Review	Assignee:	Paulo Andrade <paulo.cesar.pereira.de.andrade>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, paulo.cesar.pereira.de.andrade
Target Milestone:	---	Flags:	paulo.cesar.pereira.de.andrade: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-12-03 20:21:04 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description gil cattaneo 2015-02-16 21:14:51 UTC

Spec URL: https://gil.fedorapeople.org/sxc.spec
SRPM URL: https://gil.fedorapeople.org/sxc-0.8-1.fc20.src.rpm
Description:
SXC (Simple XML Compiler) allows you to created optimized parsers and
writers for XML. Through a declarative API you're able to tell SXC
what type of XML to expect and what actions to associate with it.

Fedora Account System Username: gil

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=8954096

Comment 1 gil cattaneo 2015-11-10 16:42:54 UTC

Spec URL: https://gil.fedorapeople.org/sxc.spec
SRPM URL: https://gil.fedorapeople.org/sxc-0.8-1.fc23.src.rpm

Comment 2 Upstream Release Monitoring 2015-11-10 16:47:26 UTC

gil's scratch build of sxc-0.8-1.fc23.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11776097

Comment 3 Paulo Andrade 2015-11-23 15:52:58 UTC

I will review this package in exchange for review of
https://bugzilla.redhat.com/show_bug.cgi?id=1278140

Comment 4 Paulo Andrade 2015-11-23 18:43:58 UTC

Hi Gil,

  There are files under Apache and BSD license, so,
license probably should be changed to:
CDDL and ASL 2.0 and BSD
See for example:
sxc-sxc-0.8/sxc-runtime/src/main/java/org/metatype/sxc/util/Base64.java
sxc-sxc-0.8/sxc-xpath/src/test/java/org/metatype/sxc/xpath/StreaxPerformance.java

  Please comment about:
# https://gil.fedorapeople.org/dependency-report-plugin-1.0.3-1.fc19.src.rpm
# BuildRequires: mvn(org.codehaus.swizzle:dependency-report-plugin)
Does it mean it is an optional build requires dependency?

  An issue I see in most mvn related packages is
every subpackage having a %license line, because there
is no clean information about a single common subpackage
that all others require. It looks weird that every
subpackage have the line:
%license LICENSE.txt

Please correct the license tag before pushing to git,
otherwise I consider the package approved.

Comment 5 gil cattaneo 2015-11-23 22:16:56 UTC

(In reply to Paulo Andrade from comment #4)
> Hi Gil,

Hi Paulo,

>   There are files under Apache and BSD license, so,
> license probably should be changed to:
> CDDL and ASL 2.0 and BSD
> See for example:
> sxc-sxc-0.8/sxc-runtime/src/main/java/org/metatype/sxc/util/Base64.java
> sxc-sxc-0.8/sxc-xpath/src/test/java/org/metatype/sxc/xpath/StreaxPerformance.
> java

The last one is a should be consider as test resources, and not interested in the end of the package license.
Added for the sub packages sxc-runtime and sxc-javadoc license field CDDL and ASL 2.0

>   Please comment about:
> # https://gil.fedorapeople.org/dependency-report-plugin-1.0.3-1.fc19.src.rpm
> # BuildRequires: mvn(org.codehaus.swizzle:dependency-report-plugin)
> Does it mean it is an optional build requires dependency?

yes, should be consider as optional. Done

>   An issue I see in most mvn related packages is
> every subpackage having a %license line, because there
> is no clean information about a single common subpackage
> that all others require. It looks weird that every
> subpackage have the line:
> %license LICENSE.txt
> 
> Please correct the license tag before pushing to git,
> otherwise I consider the package approved.

Thanks for your quick review

Spec URL: https://gil.fedorapeople.org/sxc.spec
SRPM URL: https://gil.fedorapeople.org/sxc-0.8-1.fc23.src.rpm

Comment 6 gil cattaneo 2015-11-23 22:31:37 UTC

Request for new package:
https://admin.fedoraproject.org/pkgdb/package/requests/1784
https://admin.fedoraproject.org/pkgdb/package/requests/1785

Comment 7 Gwyn Ciesla 2015-11-24 01:12:43 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/sxc

Comment 8 Fedora Update System 2015-11-24 19:35:12 UTC

sxc-0.8-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-555d019d06

Comment 9 Fedora Update System 2015-11-26 02:54:52 UTC

sxc-0.8-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update sxc'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-555d019d06

Comment 10 Fedora Update System 2015-12-03 20:21:01 UTC

sxc-0.8-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.