Bug 1193237

Summary: Virt-builder fingerprint is required even when no check desired
Product: [Community] Virtualization Tools Reporter: James (purpleidea) <jshubin>
Component: libguestfsAssignee: Pino Toscano <ptoscano>
Status: CLOSED UPSTREAM QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: jshubin, ptoscano, rbalakri
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-02-18 14:29:51 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description James (purpleidea) 2015-02-16 23:13:47 UTC 
Description of problem:

I'm using virt-builder with a custom index. My fingerprint is:
EA0F 15A0 574D FC19 8F4A BEA2 A0E8 F3C0 2409 0D66

The following command works (as it should):

virt-builder --source index.asc --fingerprint 'EA0F 15A0 574D FC19 8F4A BEA2 A0E8 F3C0 2409 0D66' --list


and this one fails (as it should):

virt-builder --source index.asc --fingerprint 'BADD BADD BADD BADD BADD BADD BADD BADD BADD BADD' --list
virt-builder: error: could not import public key


This one works! (makes sense, although I'd think --fingerprint should be incompatible with --no-check-signature):

virt-builder --source index.asc --fingerprint 'BADD BADD BADD BADD BADD BADD BADD BADD BADD BADD' --no-check-signature --list


But unfortunately, this one fails, because no bogus sig was supplied.

$ virt-builder --source index.asc --no-check-signature --list
virt-builder: error: source and fingerprint lists are not the same length

When I would expect it to work...


Version-Release number of selected component (if applicable):
$ virt-builder --version
virt-builder 1.28.6


How reproducible:
100%

Additional info:
Not an urgent bug because you can fake it by supplying a fake fingerprint, but probably good to mention.
Comment 1 Pino Toscano 2015-02-17 15:36:03 UTC 
Patch posted:
  https://www.redhat.com/archives/libguestfs/2015-February/msg00161.html
Comment 2 Pino Toscano 2015-02-18 14:29:51 UTC 
Fixed with
https://github.com/libguestfs/libguestfs/commit/869b9fcf97d1084e06c16ec25df60d3bc58bfb0f
which is in libguestfs >= 1.29.27.