Bug 1193652

Summary: Report based on EVM Groups is not displaying correct tags
Product: Red Hat CloudForms Management Engine Reporter: Jared Deubel <jdeubel>
Component: UI - OPSAssignee: Martin Hradil <mhradil>
Status: CLOSED ERRATA QA Contact: Milan Falešník <mfalesni>
Severity: high Docs Contact:
Priority: high    
Version: 5.4.0CC: bascar, cpelland, dajohnso, hkataria, jdeubel, jhardy, jocarter, mfeifer, obarenbo, simaishi, xlecauch
Target Milestone: GA   
Target Release: 5.5.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.5.0.12 Doc Type: Bug Fix
Doc Text:
Previously, the report editor handled tags on entities incorrectly, which produced reports based on EVM groups that did not display the correct tags. This caused custom tags such as 'vms.managed.department' and 'miq_templates.managed.department' to be stripped to 'managed.department' form before being added to col_order. This fix allows tags on entities to be saved correctly by the report editor.
 Story Points: ---
Clone Of: Environment:
Last Closed: 2015-12-08 13:02:44 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Report none

Description Jared Deubel 2015-02-17 20:10:06 UTC 
Tagging a bunch of VMs with the wrong department so I removed the tag and added the correct department tag to these VMs.  The report I am running still does not show any VMs that I have tagged with the new department tag.  

If I do a filter under Infrastructure, VMs and filter by this newly created tag and 139 VMs show up but those VMs never show up in my report.  

The report is based on EVM groups and I have tagged all groups with the the appropriate department as well as all the VMs.   The department that is not showing up is
Operational Support Systems.Description of problem:


Version-Release number of selected component (if applicable):
5.2.x

How reproducible:


Steps to Reproduce:
1. Import report based on EVM Groups (attached to this case)
2. Tag a groups
3. Run report

Actual results:


Expected results:
To see all of the tagged groups shown in that report

Additional info:
Comment 1 Jared Deubel 2015-02-17 20:11:49 UTC 
Created attachment 992871 [details]
Report
Comment 12 Harpreet Kataria 2015-11-16 19:32:26 UTC 
MR: http://gitlab.cloudforms.lab.eng.rdu2.redhat.com/cloudforms/cfme/merge_requests/471
Comment 13 Harpreet Kataria 2015-11-16 19:33:03 UTC 
Please ignore comment #12
Comment 14 CFME Bot 2015-11-23 16:34:20 UTC 
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/4d5599b35ad6bb188f2a4110ff85f3b2da123bea

commit 4d5599b35ad6bb188f2a4110ff85f3b2da123bea
Author:     Martin Hradil <mhradil>
AuthorDate: Fri Mar 6 16:28:16 2015 +0000
Commit:     Martin Hradil <mhradil>
CommitDate: Wed Nov 18 16:36:08 2015 +0000

    Report editor - handle tags on entities
    
    in add_field_to_col_order(rpt, field), we should differentiate between 'managed.department' and 'vms.managed.department' (and others)
    previously any custom tag got stripped to the 'manager.department' form before being added to col_order
    
    Now saving
    
        - managed.department
        - vms.managed.department
        - miq_templates.managed.department
    
    , etc.
    
    (Depends on further changes, editing such report now yields a NoMethodError (nil.include?))
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1193652

 app/controllers/report_controller/reports/editor.rb | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)
Comment 15 CFME Bot 2015-11-23 16:34:27 UTC 
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/ed6260f2e8d4a421c2439579035ad33c905371db

commit ed6260f2e8d4a421c2439579035ad33c905371db
Author:     Martin Hradil <mhradil>
AuthorDate: Mon Mar 9 18:34:33 2015 +0000
Commit:     Martin Hradil <mhradil>
CommitDate: Wed Nov 18 16:42:55 2015 +0000

    Report editor - handle saved tags on entities
    
    find_includes can handle tags like vms.managed.department, correctly returns data understandeable by the UI
    
    (needs testing)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1193652

 .../report_controller/reports/editor.rb            | 58 ++++++++++++++--------
 1 file changed, 36 insertions(+), 22 deletions(-)
Comment 17 CFME Bot 2015-11-23 18:08:18 UTC 
New commit detected on cfme/5.5.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=5fa8a58835bd550a14e7317904ab24c03e08bbd6

commit 5fa8a58835bd550a14e7317904ab24c03e08bbd6
Author:     Martin Hradil <mhradil>
AuthorDate: Mon Mar 9 18:34:33 2015 +0000
Commit:     Martin Hradil <mhradil>
CommitDate: Mon Nov 23 16:32:05 2015 +0000

    Report editor - handle saved tags on entities
    
    find_includes can handle tags like vms.managed.department, correctly returns data understandeable by the UI
    
    (needs testing)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1193652
    (cherry picked from commit ed6260f2e8d4a421c2439579035ad33c905371db)

 .../report_controller/reports/editor.rb            | 58 ++++++++++++++--------
 1 file changed, 36 insertions(+), 22 deletions(-)
Comment 18 CFME Bot 2015-11-23 18:08:25 UTC 
New commit detected on cfme/5.5.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=1542d8e9cdbca5f981cdef53f2277e202fbb4664

commit 1542d8e9cdbca5f981cdef53f2277e202fbb4664
Author:     Martin Hradil <mhradil>
AuthorDate: Fri Mar 6 16:28:16 2015 +0000
Commit:     Martin Hradil <mhradil>
CommitDate: Mon Nov 23 16:31:25 2015 +0000

    Report editor - handle tags on entities
    
    in add_field_to_col_order(rpt, field), we should differentiate between 'managed.department' and 'vms.managed.department' (and others)
    previously any custom tag got stripped to the 'manager.department' form before being added to col_order
    
    Now saving
    
        - managed.department
        - vms.managed.department
        - miq_templates.managed.department
    
    , etc.
    
    (Depends on further changes, editing such report now yields a NoMethodError (nil.include?))
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1193652
    (cherry picked from commit 4d5599b35ad6bb188f2a4110ff85f3b2da123bea)

 app/controllers/report_controller/reports/editor.rb | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)
Comment 19 CFME Bot 2015-11-23 18:08:32 UTC 
New commit detected on cfme/5.5.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=823d32f2b0f7ac13b252cc59368cad985b464cf5

commit 823d32f2b0f7ac13b252cc59368cad985b464cf5
Merge: 39293bb 7a99eea
Author:     Harpreet Kataria <hkataria>
AuthorDate: Mon Nov 23 12:45:53 2015 -0500
Commit:     Harpreet Kataria <hkataria>
CommitDate: Mon Nov 23 12:45:53 2015 -0500

    Merge branch 'bz1193652-report-editor' into '5.5.z'
    
    Report editor - handle tags on entitites
    
    https://github.com/ManageIQ/manageiq/pull/3117
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1193652
    
    clean cherry pick
    
    See merge request !519

 .../report_controller/reports/editor.rb            | 76 +++++++++++++---------
 1 file changed, 47 insertions(+), 29 deletions(-)
Comment 21 Milan Falešník 2015-11-26 14:26:20 UTC 
Verified in 5.5.0.12

kudos @mhradil.
Comment 23 errata-xmlrpc 2015-12-08 13:02:44 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2015:2551