Bug 1194275

Summary: [Snapshot]: Glusterd crashed during snap restore after adding a new node without hostname resolution
Product: [Red Hat Storage] Red Hat Gluster Storage Reporter: shilpa <smanjara>
Component: snapshotAssignee: Avra Sengupta <asengupt>
Status: CLOSED ERRATA QA Contact: senaik
Severity: unspecified Docs Contact:
Priority: high    
Version: rhgs-3.0CC: amainkar, amukherj, asengupt, rhs-bugs, rjoseph, sasundar, smanjara, storage-qa-internal, vagarwal
Target Milestone: ---Keywords: ZStream
Target Release: RHGS 3.0.4   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.6.0.47-1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1194538 (view as bug list) Environment:
Last Closed: 2015-03-26 06:36:14 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1182947, 1194538    

Comment 5 Atin Mukherjee 2015-02-20 05:08:13 UTC
Shilpa,

Could you attach the core file?

Comment 7 Avra Sengupta 2015-02-20 06:02:05 UTC
This issue is already RCA'd. In the glusterd restore path, if we fail to stop the brick, we fail restore. But the check in the out: section of the function makes a wrong ret check, which causes us to access a NULL new_volinfo thereby causing the crash. Will send the fix for this.

Comment 8 Avra Sengupta 2015-02-20 07:35:15 UTC
Upstream fix at http://review.gluster.org/9719

Comment 9 Avra Sengupta 2015-02-24 08:03:22 UTC
Fixed with https://code.engineering.redhat.com/gerrit/42593

Comment 10 senaik 2015-02-27 09:27:38 UTC
Version : glusterfs 3.6.0.47

Retried the steps by making the newly added node not resolve the hostnames of the existing nodes in the cluster and snapshot restore fails as expected. There is no crash seen. 

Marking the bug as 'Verified'

Comment 12 errata-xmlrpc 2015-03-26 06:36:14 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-0682.html