Bug 1194620
| Summary: | User shouldn't be allowed to create an interface with same identifier of any existing one | ||
|---|---|---|---|
| Product: | Red Hat Satellite | Reporter: | Sachin Ghai <sghai> |
| Component: | WebUI | Assignee: | Marek Hulan <mhulan> |
| WebUI sub component: | Foreman | QA Contact: | Sachin Ghai <sghai> |
| Status: | CLOSED CURRENTRELEASE | Docs Contact: | |
| Severity: | medium | ||
| Priority: | unspecified | CC: | bkearney, dlobatog, jcallaha |
| Version: | 6.1.0 | Keywords: | Triaged |
| Target Milestone: | Unspecified | ||
| Target Release: | Unused | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | http://projects.theforeman.org/issues/9618 | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-08-12 13:55:54 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1193987 | ||
| Attachments: | |||
Created redmine issue http://projects.theforeman.org/issues/9618 from this bug Moving to POST since upstream bug http://projects.theforeman.org/issues/9618 has been closed ------------- Marek Hulán Applied in changeset commit:f2d5f95539b5070f5c7aba37196c45346140357d. Created attachment 1007460 [details]
Multiple interfaces with same identifier
FailedQA on Satellite-6.1.0-RHEL-7-20150324.0
I was able to create multiple interfaces with the same identifier name.
moving back to POST, I think you tested it too early (it wasn't MODIFIED yet) It was moved to POST. Let me know when it should be good to test. I'd say when it's set to MODIFIED? Failed QA in Satellite 6.1 Snap 3. I was able to create interfaces with duplicate names. See attached screenshot. Created attachment 1025133 [details]
Duplicate interface names
I think you didn't hit the submit button. You can add interfaces through modal window that are not valid, it's the same as if you enter something into text field. It's just prepares the host form and it's not instantly validated until sent to server. When you hit the blue submit button then it sends the data to server and validation is performed. Please re-verify and let me know if you have any questions. I was trying to reproduce this issue with snap4 c2. Now what happens when you define two interfaces with same identifier while creating a new host and submit the "new_host", the form neither submitted nor raises any error. however production.log filled with error: 2015-05-15 16:38:01 [I] Failed to save: Interfaces some of interfaces are invalid Created attachment 1025811 [details]
defined two interfaces with same identifier
Merged as 9515e3edea13e45b6a30c4138eb703f40f51f858 Verified with sat6.1 GA snap5 Now UI throws proper validation error if user tries to create an interface with an existing identifier name. Thanks for fixing this issue. Created attachment 1028681 [details]
error on creating an interface with an existing identifier name
This bug is slated to be released with Satellite 6.1. This bug was fixed in version 6.1.1 of Satellite which was released on 12 August, 2015. |
Description of problem: I created an alias interface and define eth0 in identifier, Form was submitted without any validation error and UI accepted it. Ideally UI should raise a validation error as you can't create two interfaces with same identifier here is the snippet from provisioning template: -- # primary interface real=`ip -o link | grep 52:54:00:34:ac:fb | awk '{print $2;}' | sed s/://` cat << EOF > /etc/sysconfig/network-scripts/ifcfg-$real BOOTPROTO="dhcp" DEVICE="$real" HWADDR="52:54:00:34:ac:fb" ONBOOT=yes EOF # eth0 interface real=`ip -o link | grep 52:54:00:34:ac:fb | awk '{print $2;}' | sed s/:$//` real=`echo eth0 | sed s/eth0/$real/` cat << EOF > /etc/sysconfig/network-scripts/ifcfg-$real BOOTPROTO="none" IPADDR="192.168.100.122" NETMASK="255.255.255.248" DEVICE="$real" ONBOOT=yes PEERDNS=no PEERROUTES=no EOF --- Version-Release number of selected component (if applicable): sat6.1 beta snap3 Satellite-6.1.0-RHEL-6-20150217.0 How reproducible: always Steps to Reproduce: 1. create a new host and add an interface with same identifier as of existing one 2. 3. Actual results: no validation error Expected results: validation error should be raised on form submation Additional info: