Bug 1194993
| Summary: | Review Request: nodejs-colors0 - Get colors in your Node.js console | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Piotr Popieluch <piotr1212> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jsmith.fedora, package-review, rbean, tchollingsworth |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-02-23 15:17:32 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 956806, 1191212, 1194994 | ||
|
Description
Piotr Popieluch
2015-02-21 18:47:51 UTC
When we introduce parallel-installable library packages of any language in Fedora, we typically package the older version as a separate SRPM, and leave the unversioned name for the latest version of the package. The other multiply versioned nodejs-* packages follow this general rule-of-thumb, e.g. uglify-js (2)/uglify-js1 and nodejs-nan (1)/nodejs-nan0. I'd prefer it if this package would be consistent with the other two multiply versioned packages, and have nodejs-colors (1) and nodejs-colors0. You can then have nodejs-colors0 `Obsoletes: nodejs-colors < 1` for a smooth transition. (In reply to Piotr Popieluch from comment #0) > I have symlinked colors 0.6.3 to /usr/lib/node_modules/colors to not break > packages in released Fedora releases. Should I move and point the symlink to > the new package for f22 and Rawhide? Yes, please always keep the version the same in released Fedoras and move the symlink to the newest version in unreleased versions. Thank you for the quick response. I was in doubt of the version name and decided to name the new one *1 to prevent a package rename. But you are right, I will update the packages tomorrow to be consistent. Updates specs: - packaged older version as new package: nodejs-colors0 = 0.6.2 - updated current version to 1.0.3 - added conditionals for symlinks: o f22 + rawhide + rhel 7 symlink to 1.0.3 o release fedora's and rhel symlink to 0.6.2 - added %pretrans script which moves the module if the directory isn't a symlink. - added 'Obsoletes: nodejs-colors < 1' to nodejs-colors0 0.6.2 Spec URL: https://piotrp.fedorapeople.org/nodejs-colors/nodejs-colors0.spec SRPM URL: https://piotrp.fedorapeople.org/nodejs-colors/nodejs-colors0-0.6.2-1.fc21.src.rpm 1.0.3 Spec URL: https://piotrp.fedorapeople.org/nodejs-colors/nodejs-colors.spec SRPM URL: https://piotrp.fedorapeople.org/nodejs-colors/nodejs-colors-1.0.3-1.fc21.src.rpm I've tested some update scenarios on f21 and on rawhide which seems to work fine. Only thing I don't understand: when I install a package which depends on 0.6 dnf wants to install both modules, I would expect it to install only nodejs-colors0 (this was on f21). Everything in Fedora has been updated to use npm(colors) >= 1, so I'm closing this as WONTFIX. |