Bug 1195555 (ghc-tabular)

Summary: Review Request: ghc-tabular - Two-dimensional data tables with rendering functions
Product: [Fedora] Fedora Reporter: Ben Boeckel <fedora>
Component: Package ReviewAssignee: Jens Petersen <petersen>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: haskell-devel, package-review
Target Milestone: ---Flags: petersen: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: ghc-wizards-1.0.1-1.fc22 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-03-13 16:58:02 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1142928    

Description Ben Boeckel 2015-02-24 04:30:28 UTC
Spec URL: http://mathstuf.fedorapeople.org//ghc-tabular.spec
SRPM URL: http://mathstuf.fedorapeople.org//ghc-tabular-0.2.2.6-1.fc23.src.rpm

Description:
Tabular provides a Haskell representation of two-dimensional data tables, the
kind that you might find in a spreadsheet or or a research report. It also
comes with some default rendering functions for turning those tables into ASCII
art, simple text with an arbitrary delimiter, CSV, HTML or LaTeX.

Comment 1 Ben Boeckel 2015-02-24 04:31:45 UTC
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9047635

Comment 2 Ben Boeckel 2015-02-24 04:38:37 UTC
Better scratch build (files replaced): http://koji.fedoraproject.org/koji/taskinfo?taskID=9047683

Comment 3 Jens Petersen 2015-02-26 08:32:26 UTC
cblrpm diff output:

--- ghc-tabular.spec	2015-02-24 13:34:33.000000000 +0900
+++ ghc-tabular.spec.cblrpm	2015-02-26 17:30:37.399281724 +0900
@@ -25,6 +25,17 @@
 comes with some default rendering functions for turning those tables into ASCII
 art, simple text with an arbitrary delimiter, CSV, HTML or LaTeX.
 
+Below is an example of the kind of output this library produces. The tabular
+package can group rows and columns, each group having one of three separators
+(no line, single line, double line) between its members.
+
+> || memtest 1 | memtest 2 || time test | time test 2 >
+====++===========+===========++=============+============ > A 1 || hog |
+terrible || slow | slower > A 2 || pig | not bad || fast | slowest >
+----++-----------+-----------++-------------+------------ > B 1 || good | awful
+|| intolerable | bearable > B 2 || better | no chance || crawling | amazing > B
+3 || meh | well... || worst ever | ok.
+
 
 %package devel
 Summary:        Haskell %{pkg_name} library development files
@@ -48,7 +59,6 @@
 
 %install
 %ghc_lib_install
-mv %{buildroot}%{_datadir}/%{pkg_name}-%{version} %{buildroot}%{_datadir}/%{name}
 
 
 %post devel
@@ -65,10 +75,8 @@
 
 %files devel -f %{name}-devel.files
 %doc example
-%{_datadir}/%{name}
 
 
 %changelog
-* Tue Feb 24 2015 Fedora Haskell SIG <haskell.org> - 0.2.2.6-1
-- spec file generated by cabal-rpm-0.9.3
-- move examples to more Fedora-acceptable location
+* Thu Feb 26 2015 Fedora Haskell SIG <haskell.org> - 0.2.2.6-1
+- spec file generated by cabal-rpm-0.9.3.50

Comment 4 Jens Petersen 2015-02-26 08:48:11 UTC
Your spec file and srpm are out of sync. :(

|> mv %{buildroot}%{_datadir}/%{pkg_name}-%{version} %{buildroot}%{_datadir}/%{name}

There is already:

%doc example

so no need to duplicate the samples in datadir, so please remove datadir/example.

Otherwise this looks good to me.

- License is BSD.
- Standard Haskell packaging.

Package is APPROVED, but please fix above when importing.

Comment 5 Ben Boeckel 2015-02-27 04:33:45 UTC
(In reply to Jens Petersen from comment #4)
> Your spec file and srpm are out of sync. :(

Oh, oops. Forgot to post the link to -2 of the srpm.

> |> mv %{buildroot}%{_datadir}/%{pkg_name}-%{version}
> %{buildroot}%{_datadir}/%{name}
> 
> There is already:
> 
> %doc example

Indeed. Now using rm rather than mv locally which will be used for upload.

Comment 6 Ben Boeckel 2015-02-27 04:37:21 UTC
New Package SCM Request
=======================
Package Name: ghc-tabular
Short Description: Two-dimensional data tables with rendering functions
Upstream URL: http://hub.darcs.net/kowey/tabular
Owners: mathstuf petersen
Branches: f20 f21 f22
InitialCC: haskell-sig

Comment 7 Gwyn Ciesla 2015-02-27 13:49:52 UTC
Git done (by process-git-requests).

Comment 8 Fedora Update System 2015-02-28 09:46:55 UTC
hledger-0.23.2-1.fc22,ghc-wizards-1.0.1-1.fc22,ghc-control-monad-free-0.6.1-3.fc22,ghc-tabular-0.2.2.7-2.fc22,ghc-prelude-extras-0.4-2.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/hledger-0.23.2-1.fc22,ghc-wizards-1.0.1-1.fc22,ghc-control-monad-free-0.6.1-3.fc22,ghc-tabular-0.2.2.7-2.fc22,ghc-prelude-extras-0.4-2.fc22

Comment 9 Fedora Update System 2015-02-28 16:41:53 UTC
Package ghc-wizards-1.0.1-1.fc22, ghc-tabular-0.2.2.7-2.fc22, hledger-0.23.2-1.fc22, ghc-control-monad-free-0.6.1-3.fc22, ghc-prelude-extras-0.4-2.fc22:
* should fix your issue,
* was pushed to the Fedora 22 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing ghc-wizards-1.0.1-1.fc22 ghc-tabular-0.2.2.7-2.fc22 hledger-0.23.2-1.fc22 ghc-control-monad-free-0.6.1-3.fc22 ghc-prelude-extras-0.4-2.fc22'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-2880/hledger-0.23.2-1.fc22,ghc-wizards-1.0.1-1.fc22,ghc-control-monad-free-0.6.1-3.fc22,ghc-tabular-0.2.2.7-2.fc22,ghc-prelude-extras-0.4-2.fc22
then log in and leave karma (feedback).

Comment 10 Fedora Update System 2015-03-04 21:08:55 UTC
Package ghc-wizards-1.0.1-1.fc22, ghc-tabular-0.2.2.7-2.fc22, ghc-control-monad-free-0.6.1-3.fc22, ghc-prelude-extras-0.4-2.fc22, ghc-shakespeare-text-1.1.0-3.fc22, hledger-0.24-1.fc22, ghc-hledger-lib-0.24-1.fc22:
* should fix your issue,
* was pushed to the Fedora 22 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing ghc-wizards-1.0.1-1.fc22 ghc-tabular-0.2.2.7-2.fc22 ghc-control-monad-free-0.6.1-3.fc22 ghc-prelude-extras-0.4-2.fc22 ghc-shakespeare-text-1.1.0-3.fc22 hledger-0.24-1.fc22 ghc-hledger-lib-0.24-1.fc22'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-2880/hledger-0.24-1.fc22,ghc-hledger-lib-0.24-1.fc22,ghc-wizards-1.0.1-1.fc22,ghc-control-monad-free-0.6.1-3.fc22,ghc-tabular-0.2.2.7-2.fc22,ghc-prelude-extras-0.4-2.fc22,ghc-shakespeare-text-1.1.0-3.fc22
then log in and leave karma (feedback).

Comment 11 Fedora Update System 2015-03-13 16:58:02 UTC
ghc-wizards-1.0.1-1.fc22, ghc-tabular-0.2.2.7-2.fc22, ghc-control-monad-free-0.6.1-3.fc22, ghc-prelude-extras-0.4-2.fc22, ghc-shakespeare-text-1.1.0-3.fc22, hledger-0.24-1.fc22, ghc-hledger-lib-0.24-1.fc22 has been pushed to the Fedora 22 stable repository.  If problems still persist, please make note of it in this bug report.