Bug 1195628

Summary: Editing interface in modal window resets compute resource NIC attributes
Product: Red Hat Satellite Reporter: Tomas Strachota <tstrachota>
Component: ProvisioningAssignee: Tomas Strachota <tstrachota>
Status: CLOSED ERRATA QA Contact: Tazim Kolhar <tkolhar>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 6.0.4CC: bbuckingham, cwelton, jmontleo, tkolhar, tstrachota
Target Milestone: UnspecifiedKeywords: Triaged
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
URL: http://projects.theforeman.org/issues/9325
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-08-12 05:27:10 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
compute resource libvirt
none
Add interface none

Description Tomas Strachota 2015-02-24 08:29:39 UTC
It seems that when I edit interface of host deployed on libvirt in modal window it resets compute resource attributes. It seems to take default from compute profile. I think it stores values correctly, it just does not sync them to form in modal window when I re-edit the interface.

Comment 1 Tomas Strachota 2015-02-24 08:29:41 UTC
Created from redmine issue http://projects.theforeman.org/issues/9325

Comment 2 Tomas Strachota 2015-02-24 08:36:37 UTC
Upstream fix has been merged into Foreman:

commit b18aa5307b9fc407bbd469ca6442553ce012eb78
Author: Tomas Strachota <tstrachota>
Date:   Mon Feb 23 15:47:33 2015 +0000

    Fixes #9325 - preserve compute resource attrs after NIC modal is closed

Comment 7 Tazim Kolhar 2015-04-21 10:21:17 UTC
hi

please provide verification steps

thanks

Comment 8 Tomas Strachota 2015-04-21 13:51:49 UTC
The reproducer is:
1. On the New host page, select a compute resource that allows for creating interfaces (e.g. libvirt)
2. Go to the the Interfaces tab and edit the first interface in a modal window
3. At the very bottom of the modal window there's a section named by the compute resource. Edit any of the fields in that section.
4. Close the modal, reopen it and check whether the fields you changed have the desired values.

Comment 9 Tazim Kolhar 2015-04-22 07:18:06 UTC
VERIFIED:

# rpm -qa | grep foreman
qe-sat6-rhel71.usersys.redhat.com-foreman-client-1.0-1.noarch
qe-sat6-rhel71.usersys.redhat.com-foreman-proxy-1.0-1.noarch
ruby193-rubygem-foreman_docker-1.2.0.7-1.el7sat.noarch
rubygem-hammer_cli_foreman_discovery-0.0.1.4-1.el7sat.noarch
ruby193-rubygem-foreman-redhat_access-0.1.0-1.el7sat.noarch
foreman-compute-1.7.2.15-1.el7sat.noarch
foreman-vmware-1.7.2.15-1.el7sat.noarch
ruby193-rubygem-foreman_discovery-2.0.0.9-1.el7sat.noarch
rubygem-hammer_cli_foreman_bootdisk-0.1.2.5-1.el7sat.noarch
ruby193-rubygem-foreman_gutterball-0.0.1.9-1.el7sat.noarch
foreman-1.7.2.15-1.el7sat.noarch
foreman-ovirt-1.7.2.15-1.el7sat.noarch
rubygem-hammer_cli_foreman-0.1.4.7-1.el7sat.noarch
foreman-proxy-1.7.2.4-1.el7sat.noarch
qe-sat6-rhel71.usersys.redhat.com-foreman-proxy-client-1.0-1.noarch
foreman-postgresql-1.7.2.15-1.el7sat.noarch
ruby193-rubygem-foreman_hooks-0.3.7-2.el7sat.noarch
foreman-selinux-1.7.2.13-1.el7sat.noarch
foreman-gce-1.7.2.15-1.el7sat.noarch
ruby193-rubygem-foreman-tasks-0.6.12.3-1.el7sat.noarch
rubygem-hammer_cli_foreman_tasks-0.0.3.3-1.el7sat.noarch
foreman-debug-1.7.2.15-1.el7sat.noarch
foreman-libvirt-1.7.2.15-1.el7sat.noarch
ruby193-rubygem-foreman_bootdisk-4.0.2.10-1.el7sat.noarch

steps :

log to sat6 ui 
navigate to compute resource (interface libvirt)
edit the first interface in the modal window
edit for example description
close the window
reopen it . the fields changed retain their values

Screenshot attached:

Comment 10 Tazim Kolhar 2015-04-22 07:18:49 UTC
Created attachment 1017292 [details]
compute resource libvirt

Comment 11 Tomas Strachota 2015-04-22 13:36:36 UTC
Since the problem was on the "New host" page and the verification steps with the screenshot seem to be taken on "Compute resources" page, I request a re-verification, please.
Thank you!

Comment 12 Tazim Kolhar 2015-04-23 11:03:17 UTC
VERIFIED :

# rpm -qa  | grep foreman
foreman-libvirt-1.7.2.15-1.el6_6sat.noarch
ruby193-rubygem-foreman-tasks-0.6.12.3-1.el6_6sat.noarch
foreman-postgresql-1.7.2.15-1.el6_6sat.noarch
ruby193-rubygem-foreman_docker-1.2.0.7-1.el6_6sat.noarch
ruby193-rubygem-foreman_gutterball-0.0.1.9-1.el6_6sat.noarch
rubygem-hammer_cli_foreman_discovery-0.0.1.4-1.el6_6sat.noarch
foreman-debug-1.7.2.15-1.el6_6sat.noarch
foreman-compute-1.7.2.15-1.el6_6sat.noarch
foreman-gce-1.7.2.15-1.el6_6sat.noarch
ruby193-rubygem-foreman_bootdisk-4.0.2.10-1.el6_6sat.noarch
rubygem-hammer_cli_foreman_tasks-0.0.3.3-1.el6_6sat.noarch
foreman-proxy-1.7.2.4-1.el6_6sat.noarch
dhcp207-193.lab.eng.pnq.redhat.com-foreman-client-1.0-1.noarch
dhcp207-193.lab.eng.pnq.redhat.com-foreman-proxy-1.0-2.noarch
foreman-1.7.2.15-1.el6_6sat.noarch
foreman-vmware-1.7.2.15-1.el6_6sat.noarch
ruby193-rubygem-foreman-redhat_access-0.1.0-1.el6_6sat.noarch
rubygem-hammer_cli_foreman-0.1.4.7-1.el6_6sat.noarch
dhcp207-193.lab.eng.pnq.redhat.com-foreman-proxy-client-1.0-1.noarch
foreman-selinux-1.7.2.13-1.el6_6sat.noarch
ruby193-rubygem-foreman_hooks-0.3.7-2.el6_6sat.noarch
rubygem-hammer_cli_foreman_bootdisk-0.1.2.5-1.el6_6sat.noarch
ruby193-rubygem-foreman_openscap-0.3.2.5-1.el6_6sat.noarch
foreman-ovirt-1.7.2.15-1.el6_6sat.noarch
ruby193-rubygem-foreman_discovery-2.0.0.9-1.el6_6sat.noarch
puppet-foreman_scap_client-0.3.3-6.el6_6sat.noarch

On the New host page,
Go to the the Interfaces tab and edit the first interface in a modal window
Close the modal, reopen it and check whether the fields you changed have the desired values.

screenshot attached

Comment 13 Tazim Kolhar 2015-04-23 11:05:06 UTC
Adding the irc chat for ready reference

tstrachota> tkolhar, hi there
<tstrachota> tkolhar, I didn't meant to select compute resource from a combo box on the very first tab
<tstrachota> tkolhar, sorry, again: I meant to select compute resource from a combo box on the very first tab
<tstrachota> I stopped typing in the middle of sentence and finished differently:)
<tstrachota> tkolhar, than check the modal window on the "Network" tab, please
<tkolhar> tstrachota, hi 
<tkolhar> tstrachota, on Network tab
<tkolhar> tstrachota, update some value ?
<tstrachota> tkolhar, there's "+ Add interface" button
<tkolhar> tstrachota, yeah clicked
<tkolhar> tstrachota, now update any value
<tstrachota> tkolhar, yep
<tstrachota> tkolhar, afair it was combo box issue
<tkolhar> tstrachota, ok it got updated 
<tkolhar> tstrachota, so is it done
<tstrachota> good, verified then
<tkolhar> tstrachota, At the very bottom of the modal window there's a section named by the compute resource. Edit any of the fields in that section.
<tkolhar> tstrachota, i didn't get this step
<tstrachota> tkolhar, disregard this part, please. I forgot we didn't cherry-pick this bit into 6.1
<tkolhar> tstrachota, ah thanks becoz i was looking for compute resource in the interface tab
<tkolhar> tstrachota, thanks

Comment 14 Tazim Kolhar 2015-04-23 11:06:01 UTC
Created attachment 1017902 [details]
Add interface

Comment 15 Bryan Kearney 2015-08-11 13:24:09 UTC
This bug is slated to be released with Satellite 6.1.

Comment 16 errata-xmlrpc 2015-08-12 05:27:10 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2015:1592