Bug 1195672

Summary: [host-deploy] missing -t parameter to mktemp
Product: [Retired] oVirt Reporter: Moti Asayag <masayag>
Component: ovirt-engine-coreAssignee: Alon Bar-Lev <alonbl>
Status: CLOSED CURRENTRELEASE QA Contact: Gonza <grafuls>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 3.5CC: alonbl, bazulay, bugs, dougsland, ecohen, gklein, iheim, lsurette, mgoldboi, oourfali, ovirt-bugs, rbalakri, yeylon
Target Milestone: ---   
Target Release: 3.5.2   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: infra
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-04-29 06:17:44 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Infra RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1193058    

Description Moti Asayag 2015-02-24 11:18:23 UTC 
Description of problem:
When approving ovirt-node within ovirt-engine (built from commit 63331de64205b730d2232283fff270fafc47a635), the approval process failed to complete the ovirt-node registration with the described error below (see additional info).

Version-Release number of selected component (if applicable):
oVirt Node Hypervisor 3.5 (0.999.201502191713.el7.centos)


How reproducible:
tested with the image created by http://jenkins.ovirt.org/job/ovirt-node_master_create-iso-el7_merged/25/

Steps to Reproduce:
1. Register ovirt-node into ovirt-engine
2. Click 'Approve'

Actual results:
The approval process fails with the error below.

Expected results:
Approval process should end successfully.

Additional info:
2015-02-23 14:39:33,931 INFO  [org.ovirt.engine.core.bll.ApproveVdsCommand] (org.ovirt.thread.pool-8-thread-4) [6a8643a1] Running command: ApproveVdsCommand internal: false. Entities affected :  ID: 9b12f855-6503-41fd-92bb-f7bfc5346cc1 Type: VDSAction group CREATE_HOST with role type ADMIN
2015-02-23 14:39:33,942 INFO  [org.ovirt.engine.core.bll.InstallVdsInternalCommand] (org.ovirt.thread.pool-8-thread-4) [6a8643a1] Before Installation host 9b12f855-6503-41fd-92bb-f7bfc5346cc1, ovirt-node
2015-02-23 14:39:33,954 INFO  [org.ovirt.engine.core.vdsbroker.SetVdsStatusVDSCommand] (org.ovirt.thread.pool-8-thread-4) [6a8643a1] START, SetVdsStatusVDSCommand(HostName = ovirt-node, HostId = 9b12f855-6503-41fd-92bb-f7bfc5346cc1, status=Installing, nonOperationalReason=NONE, stopSpmFailureLogged=false), log id: 7f634cbe
2015-02-23 14:39:33,970 INFO  [org.ovirt.engine.core.vdsbroker.SetVdsStatusVDSCommand] (org.ovirt.thread.pool-8-thread-4) [6a8643a1] FINISH, SetVdsStatusVDSCommand, log id: 7f634cbe
2015-02-23 14:39:34,208 INFO  [org.ovirt.engine.core.bll.InstallerMessages] (org.ovirt.thread.pool-8-thread-4) [6a8643a1] Installation '10.35.7.148': Connected to host 10.35.7.148 with SSH key fingerprint: ec:23:68:92:33:61:e6:52:d5:aa:9d:2d:b8:02:58:5d
2015-02-23 14:39:34,223 INFO  [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (org.ovirt.thread.pool-8-thread-4) [6a8643a1] Correlation ID: 6a8643a1, Call Stack: null, Custom Event ID: -1, Message: Installing Host ovirt-node. Connected to host 10.35.7.148 with SSH key fingerprint: ec:23:68:92:33:61:e6:52:d5:aa:9d:2d:b8:02:58:5d.
2015-02-23 14:39:34,257 INFO  [org.ovirt.engine.core.bll.VdsDeploy] (org.ovirt.thread.pool-8-thread-4) [6a8643a1] Installation of 10.35.7.148. Executing command via SSH umask 0077; MYTMP="$(TMPDIR="${OVIRT_TMPDIR}" mktemp -d ovirt-XXXXXXXXXX)"; trap "chmod -R u+rwX \"${MYTMP}\" > /dev/null 2>&1; rm -fr \"${MYTMP}\" > /dev/null 2>&1" 0; tar --warning=no-timestamp -C "${MYTMP}" -x &&  "${MYTMP}"/setup DIALOG/dialect=str:machine DIALOG/customization=bool:True < /home/masayag/ovirt-engine-master/var/cache/ovirt-engine/ovirt-host-deploy.tar
2015-02-23 14:39:34,265 INFO  [org.ovirt.engine.core.uutils.ssh.SSHDialog] (org.ovirt.thread.pool-8-thread-4) [6a8643a1] SSH execute 'root.7.148' 'umask 0077; MYTMP="$(TMPDIR="${OVIRT_TMPDIR}" mktemp -d ovirt-XXXXXXXXXX)"; trap "chmod -R u+rwX \"${MYTMP}\" > /dev/null 2>&1; rm -fr \"${MYTMP}\" > /dev/null 2>&1" 0; tar --warning=no-timestamp -C "${MYTMP}" -x &&  "${MYTMP}"/setup DIALOG/dialect=str:machine DIALOG/customization=bool:True'
2015-02-23 14:39:34,427 ERROR [org.ovirt.engine.core.bll.VdsDeploy] (VdsDeploy) [6a8643a1] Error during deploy dialog: java.io.IOException: Unexpected connection termination
        at org.ovirt.otopi.dialog.MachineDialogParser.nextEvent(MachineDialogParser.java:388) [otopi.jar:]
        at org.ovirt.otopi.dialog.MachineDialogParser.nextEvent(MachineDialogParser.java:405) [otopi.jar:]
        at org.ovirt.engine.core.bll.VdsDeploy._threadMain(VdsDeploy.java:828) [bll.jar:]
        at org.ovirt.engine.core.bll.VdsDeploy.access$2000(VdsDeploy.java:87) [bll.jar:]
        at org.ovirt.engine.core.bll.VdsDeploy$51.run(VdsDeploy.java:976) [bll.jar:]
        at java.lang.Thread.run(Thread.java:745) [rt.jar:1.7.0_71]

2015-02-23 14:39:34,429 ERROR [org.ovirt.engine.core.uutils.ssh.SSHDialog] (org.ovirt.thread.pool-8-thread-4) [6a8643a1] Swallowing exception as preferring stderr: java.io.IOException: Command returned failure code 2 during SSH session 'root.7.148'
        at org.ovirt.engine.core.uutils.ssh.SSHClient.executeCommand(SSHClient.java:527) [uutils.jar:]
        at org.ovirt.engine.core.uutils.ssh.SSHDialog.executeCommand(SSHDialog.java:312) [uutils.jar:]
        at org.ovirt.engine.core.bll.VdsDeploy.execute(VdsDeploy.java:1125) [bll.jar:]
        at org.ovirt.engine.core.bll.InstallVdsInternalCommand.installHost(InstallVdsInternalCommand.java:165) [bll.jar:]
        at org.ovirt.engine.core.bll.InstallVdsInternalCommand.executeCommand(InstallVdsInternalCommand.java:91) [bll.jar:]
        at org.ovirt.engine.core.bll.ApproveVdsCommand.executeCommand(ApproveVdsCommand.java:58) [bll.jar:]
        at org.ovirt.engine.core.bll.CommandBase.executeWithoutTransaction(CommandBase.java:1212) [bll.jar:]
        at org.ovirt.engine.core.bll.CommandBase.executeActionInTransactionScope(CommandBase.java:1350) [bll.jar:]
        at org.ovirt.engine.core.bll.CommandBase.runInTransaction(CommandBase.java:1978) [bll.jar:]
        at org.ovirt.engine.core.utils.transaction.TransactionSupport.executeInSuppressed(TransactionSupport.java:174) [utils.jar:]
        at org.ovirt.engine.core.utils.transaction.TransactionSupport.executeInScope(TransactionSupport.java:116) [utils.jar:]
        at org.ovirt.engine.core.bll.CommandBase.execute(CommandBase.java:1374) [bll.jar:]
        at org.ovirt.engine.core.bll.CommandBase.executeAction(CommandBase.java:367) [bll.jar:]
        at org.ovirt.engine.core.bll.MultipleActionsRunner.executeValidatedCommand(MultipleActionsRunner.java:194) [bll.jar:]
        at org.ovirt.engine.core.bll.MultipleActionsRunner.runCommands(MultipleActionsRunner.java:161) [bll.jar:]
        at org.ovirt.engine.core.bll.MultipleActionsRunner$2.run(MultipleActionsRunner.java:170) [bll.jar:]
        at org.ovirt.engine.core.utils.threadpool.ThreadPoolUtil$InternalWrapperRunnable.run(ThreadPoolUtil.java:92) [utils.jar:]
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) [rt.jar:1.7.0_71]
        at java.util.concurrent.FutureTask.run(FutureTask.java:262) [rt.jar:1.7.0_71]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) [rt.jar:1.7.0_71]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) [rt.jar:1.7.0_71]
        at java.lang.Thread.run(Thread.java:745) [rt.jar:1.7.0_71]

2015-02-23 14:39:34,437 ERROR [org.ovirt.engine.core.uutils.ssh.SSHDialog] (org.ovirt.thread.pool-8-thread-4) [6a8643a1] SSH error running command root.7.148:'umask 0077; MYTMP="$(TMPDIR="${OVIRT_TMPDIR}" mktemp -d ovirt-XXXXXXXXXX)"; trap "chmod -R u+rwX \"${MYTMP}\" > /dev/null 2>&1; rm -fr \"${MYTMP}\" > /dev/null 2>&1" 0; tar --warning=no-timestamp -C "${MYTMP}" -x &&  "${MYTMP}"/setup DIALOG/dialect=str:machine DIALOG/customization=bool:True': Unexpected error during execution: mktemp: failed to create directory via template ‘ovirt-XXXXXXXXXX’: Read-only file system
tar: : Cannot open: No such file or directory
tar: Error is not recoverable: exiting now
Comment 1 Alon Bar-Lev 2015-02-24 13:00:34 UTC 
this is master only
Comment 2 Alon Bar-Lev 2015-02-24 13:01:51 UTC 
we need to apply this anyway.
Comment 3 Gonza 2015-03-30 15:13:24 UTC 
I tried verifying this on the following version:
rhevm-3.5.1-0.1.el6ev.noarch

And from the logs I can see the mktemp command differs from the changes made on this patch:

Executing command via SSH umask 0077; MYTMP="$(TMPDIR="${OVIRT_TMPDIR}" mktemp -t ovirt-XXXXXXXXXX)"; trap "chmod -R u+rwX \"${MYTMP}\" > /dev/null 2>&1; rm -fr \"${MYTMP}\" > /dev/null 2>&1" 0; rm -fr "${MYTMP}" && mkdir "${MYTMP}" && tar --warning=no-timestamp -C "${MYTMP}" -x &&  "${MYTMP}"/setup DIALOG/dialect=str:machine DIALOG/customization=bool:True < /var/cache/ovirt-engine/ovirt-host-deploy.tar

Can we verify that this patch made it to rhevm-3.5.1?
Comment 4 Alon Bar-Lev 2015-03-30 16:35:11 UTC 
within your output:
---
mktemp -t ovirt-XXXXXXXXXX
---

which means that we are good.
Comment 5 Eyal Edri 2015-04-29 06:17:44 UTC 
ovirt 3.5.2 was GA'd. closing current release.