Bug 1196730
| Summary: | DNSSD TXT record doesn't include rejecting flag | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Marek Kašík <mkasik> |
| Component: | cups | Assignee: | Tim Waugh <twaugh> |
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 21 | CC: | jpopelka, twaugh |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-02-27 16:39:40 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Attachments: | |||
|
Description
Marek Kašík
2015-02-26 15:52:59 UTC
Created attachment 995703 [details]
Store CUPS_PRINTER_REJECTING also in "Type" field in printers.conf
This patch works better because the original type is still stored somewhere when I set the printer to accept jobs again.
It results in Accepting set to "Yes" and Type with the CUPS_PRINTER_REJECTING flag still set without this patch.
Created attachment 995960 [details]
Git-format patch against master
I think you mean something like this. The printers.conf file already stores the accepting state for each printer, and when constructing printer-type for IPP attributes the Type field is combined with the Accepting field. It wasn't happening when constructing printer-type for the DNS-SD TXT record though.
(In reply to Tim Waugh from comment #2) > Created attachment 995960 [details] > Git-format patch against master > > I think you mean something like this. The printers.conf file already stores > the accepting state for each printer, and when constructing printer-type for > IPP attributes the Type field is combined with the Accepting field. It > wasn't happening when constructing printer-type for the DNS-SD TXT record > though. Thank you, yes this is better solution. Just one observation, if I call "cupsreject/cupsaccept", the TXT record is not changed immediately so I run "cupsenable/cupsdisable" to ensure that the change is propagated to the TXT record. Would it be possible to update the TXT record when the accepting state changes? Created attachment 996048 [details]
Git-format patch against master
Try this.
Unfortunately, CUPS doesn't update the TXT record immediately with the patch. We probably need to do something like cupsdSetPrinterState() does here:
if (update)
cupsdRegisterPrinter(p);
which calls dnssdRegisterPrinter() which calls the dnssdBuildTxtRecord().
Created attachment 996090 [details]
Git-format patch against master
Ah, yes. OK, how about this one?
(In reply to Tim Waugh from comment #7) > Created attachment 996090 [details] > Git-format patch against master > > Ah, yes. OK, how about this one? Yes, this patch updates the rejecting flag immediately. Thank you very much. Rejected upstream. |