Bug 1196735
| Summary: | [performance] bad getVMList output creates unnecessary calls from Engine | |||
|---|---|---|---|---|
| Product: | Red Hat Enterprise Virtualization Manager | Reporter: | Omer Frenkel <ofrenkel> | |
| Component: | vdsm | Assignee: | Piotr Kliczewski <pkliczew> | |
| Status: | CLOSED ERRATA | QA Contact: | Eldad Marciano <emarcian> | |
| Severity: | urgent | Docs Contact: | ||
| Priority: | high | |||
| Version: | 3.5.0 | CC: | bazulay, bkorren, bugs, cshao, ecohen, eedri, emarcian, fdeutsch, fromani, gklein, hadong, huiwa, istein, lbopf, lpeer, lsurette, mgoldboi, michal.skrivanek, mkalinin, ofrenkel, pdwyer, rbalakri, rgolan, sherold, ycui, yeylon | |
| Target Milestone: | --- | Keywords: | ZStream | |
| Target Release: | 3.5.1 | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | infra | |||
| Fixed In Version: | Doc Type: | Known Issue | ||
| Doc Text: |
An unversioned hotfix of the communication protocol between the Red Hat Enterprise Virtualization Manager and virtualization hosts resulted in exceptions in engine-log, and caused the Manager to be unable to communicate with hosts. To avoid this, when using Manager to host communication via JSON-RPC (which is new in 3.5), you must update the Manager to the new version before updating the virtualization hosts. Any host using JSON-RPC can only be upgraded once the new engine release is running. Alternatively, configure the Manager to use XML-RPC instead.
|
Story Points: | --- | |
| Clone Of: | 1196327 | |||
| : | 1198248 1203305 (view as bug list) | Environment: | ||
| Last Closed: | 2015-04-28 18:52:13 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | Infra | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | 1196327, 1202360 | |||
| Bug Blocks: | 1193058, 1198248, 1203305 | |||
|
Description
Omer Frenkel
2015-02-26 15:58:49 UTC
micahl, please remove the rhevm-3.6.0? flag, otherwise this can't be built in distgit. vdsm side - all in build vt13.12 successfully installed with no crashes or abnormal behavior, and the following benchmark was taken. build vt13.7 vs build vt13.12 (both engine & host). use case: sampling 600sec 1 host 1 vm. results: build vt13.7 reproducing the bug. 19 - getAllVmStats 76 - list 76 - getVmStats ----------------------------- build vt13.12 fixing the bug. 20 - getAllVmStats 116 - list 0 - getVmStats (In reply to Eldad Marciano from comment #10) > build vt13.12 successfully installed with no crashes or abnormal behavior, > and the following benchmark was taken. > > build vt13.7 vs build vt13.12 (both engine & host). > > use case: > sampling 600sec 1 host 1 vm. > > > results: > > build vt13.7 reproducing the bug. > 19 - getAllVmStats > 76 - list > 76 - getVmStats > > ----------------------------- > build vt13.12 fixing the bug. > 20 - getAllVmStats > 116 - list > 0 - getVmStats build vt13.12 successfully installed with no crashes or abnormal behavior, and the following method statistics benchmark was taken. build vt13.7 vs build vt13.12 (both engine & host). use case: sampling 600sec 1 host 1 vm. method invocations count results: build vt13.7 reproducing the bug. 19 - getAllVmStats 76 - list 76 - getVmStats ----------------------------- build vt13.12 fixing the bug. 20 - getAllVmStats 116 - list 0 - getVmStats Failed QE as this fix has introduce a regression that is now documented in new BZ #1198680 the bug is now handled by infra *** Bug 1199387 has been marked as a duplicate of this bug. *** I've setup an VT13.11 engine with the latest vdsm build VT13.14, that should fix this issue. Now, I don't see the error that we saw when using VT13.12 build (Host moved to "ERROR" state) but I keep seeing this error in vdsm.log:
Thread-964::ERROR::2015-03-11 09:52:44,842::__init__::493::jsonrpc.JsonRpcServer::(_serveRequest) Internal server error
Traceback (most recent call last):
File "/usr/lib/python2.6/site-packages/yajsonrpc/__init__.py", line 488, in _serveRequest
res = method(**params)
File "/usr/share/vdsm/rpc/Bridge.py", line 278, in _dynamicMethod
ret = retfield(result)
File "/usr/share/vdsm/rpc/Bridge.py", line 341, in Host_getVMList_Ret
return [v['vmId'] for v in ret['vmList']]
TypeError: string indices must be integers, not str
Thread-964::DEBUG::2015-03-11 09:52:44,843::stompReactor::163::yajsonrpc.StompServer::(send) Sending response
Failed QA, Moved back to assigned based on comment #17 verified. build vt13.15 applied on engine & vdsm both. use case: sampling 500 sec 1 host 1 vm. method invocations count results: 16 - getAllVmStats 61 - list 0 - getVmStats reopening due to a problem in MOM which is being fixed in review 38679 see bug 1202360 for MOM change status, this one is kept open for corresponding vdsm spec file change in 38711 (and 38679) all merged to ovirt-3.5 this bug was missing from commit msg, probably due to the fact it was merged a while ago. please verify this is included in the 3.5.2 branch, and move to on_qa. (build_id: vt14.2) tested on top of vt14.3 , both engine and vdsm. 1 host, 1 vm duration 600 sec. profiler analysis results: 0 - getVmStats Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2015-0904.html |