Bug 1196959

Summary: [origin_platformexp_354] Can not enable htpasswd authentication
Product: OKD Reporter: weiwei jiang <wjiang>
Component: ContainersAssignee: Jordan Liggitt <jliggitt>
Status: CLOSED CURRENTRELEASE QA Contact: libra bugs <libra-bugs>
Severity: medium Docs Contact:
Priority: medium    
Version: 3.xCC: jliggitt, mmccomas, wsun
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-04-21 18:00:03 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description weiwei jiang 2015-02-27 07:30:11 UTC 
Description of problem:
Can not start openshift after set the necessary environment variables for htpasswd authentication
OPENSHIFT_OAUTH_HTPASSWD_FILE=/home/wjiang/git/origin/htpasswd
OPENSHIFT_OAUTH_PASSWORD_AUTH=htpasswd
OPENSHIFT_OAUTH_HANDLER=login
OPENSHIFT_OAUTH_REQUEST_HANDLERS=session,basicauth

the root reason is this PR(https://github.com/openshift/origin/pull/1156), and after this PR merged, pkg/cmd/server/origin_master.go#L156~188 lost htpasswd authentication config 

Version-Release number of selected component (if applicable):
# openshift version 
openshift v0.3.2-107-gc516f4c
kubernetes v0.10.0-503-gc977a45

How reproducible:
always

Steps to Reproduce:
1. generate htpasswd database
htpasswd -c /home/wjiang/git/origin/htpasswd admin 
2.set necessary environment variables for htpasswd authentication.
OPENSHIFT_OAUTH_HTPASSWD_FILE=/home/wjiang/git/origin/htpasswd
OPENSHIFT_OAUTH_PASSWORD_AUTH=htpasswd
OPENSHIFT_OAUTH_HANDLER=login
OPENSHIFT_OAUTH_REQUEST_HANDLERS=session,basicauth
3.start openshift 

Actual results:
F0227 14:44:44.314925   23209 auth.go:490] HTPasswdFile is required to support htpasswd auth


Expected results:
openshift can enable htpasswd authentication

Additional info:
Comment 1 Jordan Liggitt 2015-02-28 01:12:23 UTC 
Fixed in https://github.com/openshift/origin/pull/1185
Comment 2 weiwei jiang 2015-02-28 02:51:17 UTC 
Checked with 
# openshift version 
openshift v0.3.3-16-gf24c912
kubernetes v0.10.0-503-gc977a45
and the bug has been fixed.