Bug 1197640

Here is a koji scratch:

http://koji.fedoraproject.org/koji/taskinfo?taskID=9136335

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: There is no build directory. Running licensecheck on vanilla
     upstream sources. No licenses found. Please check the source files for
     licenses manually.
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 307200 bytes in 20 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[?]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: ghc-equivalence-0.2.5-1.fc23.x86_64.rpm
          ghc-equivalence-devel-0.2.5-1.fc23.x86_64.rpm
          ghc-equivalence-0.2.5-1.fc23.src.rpm
ghc-equivalence.x86_64: W: spelling-error %description -l en_US Tarjan -> Trajan, Tarzan, Tartan
ghc-equivalence.x86_64: W: spelling-error %description -l en_US monad -> nomad, gonad, Mona
ghc-equivalence.src: W: spelling-error %description -l en_US Tarjan -> Trajan, Tarzan, Tartan
ghc-equivalence.src: W: spelling-error %description -l en_US monad -> nomad, gonad, Mona
3 packages and 0 specfiles checked; 0 errors, 4 warnings.




Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:


Requires
--------
ghc-equivalence (rpmlib, GLIBC filtered):
    ghc(STMonadTrans-0.3.2-4951ce19136aa59e9eb3a679e24475a1)
    ghc(base-4.7.0.2-cb23b5265b6e147094c0cd9ac819acb1)
    ghc(containers-0.5.5.1-d7910f1cd81272c1f31ca9f71d0f206e)
    ghc(mtl-2.1.3.1-96f1a7910a7553352339ed05fb61c269)
    libHSSTMonadTrans-0.3.2-ghc7.8.4.so()(64bit)
    libHSarray-0.5.0.0-ghc7.8.4.so()(64bit)
    libHSbase-4.7.0.2-ghc7.8.4.so()(64bit)
    libHScontainers-0.5.5.1-ghc7.8.4.so()(64bit)
    libHSdeepseq-1.3.0.2-ghc7.8.4.so()(64bit)
    libHSghc-prim-0.3.1.0-ghc7.8.4.so()(64bit)
    libHSinteger-gmp-0.5.1.0-ghc7.8.4.so()(64bit)
    libHSmtl-2.1.3.1-ghc7.8.4.so()(64bit)
    libHStransformers-0.3.0.0-ghc7.8.4.so()(64bit)
    libc.so.6()(64bit)
    libgmp.so.10()(64bit)
    rtld(GNU_HASH)

ghc-equivalence-devel (rpmlib, GLIBC filtered):
    /bin/sh
    ghc(equivalence-0.2.5-778efa314f3e50015e477a7f09ec9721)
    ghc-compiler
    ghc-devel(STMonadTrans-0.3.2-4951ce19136aa59e9eb3a679e24475a1)
    ghc-devel(base-4.7.0.2-cb23b5265b6e147094c0cd9ac819acb1)
    ghc-devel(containers-0.5.5.1-d7910f1cd81272c1f31ca9f71d0f206e)
    ghc-devel(mtl-2.1.3.1-96f1a7910a7553352339ed05fb61c269)
    ghc-equivalence(x86-64)



Provides
--------
ghc-equivalence:
    ghc(equivalence-0.2.5-778efa314f3e50015e477a7f09ec9721)
    ghc-equivalence
    ghc-equivalence(x86-64)
    libHSequivalence-0.2.5-ghc7.8.4.so()(64bit)

ghc-equivalence-devel:
    ghc-devel(equivalence-0.2.5-778efa314f3e50015e477a7f09ec9721)
    ghc-equivalence-devel
    ghc-equivalence-devel(x86-64)
    ghc-equivalence-static



Unversioned so-files
--------------------
ghc-equivalence: /usr/lib64/ghc-7.8.4/equivalence-0.2.5/libHSequivalence-0.2.5-ghc7.8.4.so

Source checksums
----------------
https://hackage.haskell.org/package/equivalence-0.2.5/equivalence-0.2.5.tar.gz :
  CHECKSUM(SHA256) this package     : 03969a9a89bc90a4d282b33f37442060425229517c4c67fd2dd29e1cd04e9904
  CHECKSUM(SHA256) upstream package : 03969a9a89bc90a4d282b33f37442060425229517c4c67fd2dd29e1cd04e9904


Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64-bb-tmpfs --bug 1197640
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Haskell, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

Thanks Ben for the reviews!


New Package SCM Request
=======================
Package Name: ghc-equivalence
Short Description: Equivalence relations implemented with union-find
Upstream URL: https://hackage.haskell.org/package/equivalence
Owners: petersen
Branches: f22 f21 f20 epel7
InitialCC: haskell-sig

Git done (by process-git-requests).

ghc-equivalence-0.2.5-1.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/ghc-equivalence-0.2.5-1.fc22

ghc-equivalence-0.2.5-1.fc22 has been pushed to the Fedora 22 testing repository.

ghc-equivalence-0.2.5-1.fc22 has been pushed to the Fedora 22 stable repository.