Bug 1197668

Summary:	After failure to setupNetworks: restore-nets with unified persistence does not restore pre-vdsm ifcfg
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	rhev-integ
Component:	vdsm	Assignee:	Petr Horáček <phoracek>
Status:	CLOSED ERRATA	QA Contact:	Martin Pavlik <mpavlik>
Severity:	urgent	Docs Contact:
Priority:	urgent
Version:	3.5.0	CC:	adahms, anande, bazulay, bkorren, danken, ecohen, eedri, gregscott, gwatson, iheim, jhunsaker, jraju, kmazurek, ldelouw, lpeer, lsurette, lvernia, mgoldboi, mpavlik, myakove, nashok, nicolas, oourfali, phoracek, pzhukov, rbalakri, rhodain, rmercer, sherold, ukar, usurse, yeylon, ylavi
Target Milestone:	---	Keywords:	ZStream
Target Release:	3.5.0-2
Hardware:	x86_64
OS:	Linux
Whiteboard:	network
Fixed In Version:	vt13.12	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1188251	Environment:
Last Closed:	2015-03-06 20:24:46 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Network	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1188251, 1199012
Bug Blocks:	1197443

Comment 1 Eyal Edri 2015-03-03 08:56:33 UTC

danken, this patch is merged (15892), any other patch is pending or this is ready to move to MODIFIED?

Comment 3 Martin Pavlik 2015-03-05 10:21:40 UTC

verification blocked by bug 1199012

Comment 4 Martin Pavlik 2015-03-05 12:28:56 UTC

verifed @ vdsm-4.16.8.1-7.el6ev.x86_64

Steps:
1) manually configure bond0 on host
2) change MTU on rhevm network to 8000000
3) add the host from step 1 to setup
4) installation of the host succeeds, but the network configuration fails
5) pre-vdsm ifcfg files are rolled back


snippets of log

MainProcess|Thread-17::DEBUG::2015-03-05 12:07:42,418::ifcfg::450::root::(_persistentBackup) backing up ifcfg-eth0: #pre-vdsm
DEVICE=eth0
USERCTL=no
ONBOOT=yes
MASTER=bond0
SLAVE=yes
BOOTPROTO=none

MainProcess|Thread-17::DEBUG::2015-03-05 12:07:42,419::ifcfg::313::root::(writeBackupFile) Persistently backed up /var/lib/vdsm/netconfback/ifcfg-eth0 (until next 'set safe config')
MainProcess|Thread-17::DEBUG::2015-03-05 12:07:42,419::ifcfg::550::root::(writeConfFile) Writing to file /etc/sysconfig/network-scripts/ifcfg-eth0 configuration:
# Generated by VDSM version 4.16.8.1-7.el6ev
DEVICE=eth0
HWADDR=00:1a:4a:16:01:51
MASTER=bond0
SLAVE=yes
ONBOOT=yes
MTU=80000000
NM_CONTROLLED=no

MainProcess|Thread-17::DEBUG::2015-03-05 12:07:42,419::utils::739::root::(execCmd) /sbin/ip route show to 0.0.0.0/0 table all (cwd None)
MainProcess|Thread-17::DEBUG::2015-03-05 12:07:42,421::utils::759::root::(execCmd) SUCCESS: <err> = ''; <rc> = 0
MainProcess|Thread-17::DEBUG::2015-03-05 12:07:42,426::ifcfg::374::root::(_atomicBackup) Backed up /etc/sysconfig/network-scripts/ifcfg-eth1
MainProcess|Thread-17::DEBUG::2015-03-05 12:07:42,426::ifcfg::450::root::(_persistentBackup) backing up ifcfg-eth1: #pre-vdsm
DEVICE=eth1
USERCTL=no
ONBOOT=yes
MASTER=bond0
SLAVE=yes
BOOTPROTO=none
.
.
.
.
MainProcess|Thread-17::DEBUG::2015-03-05 12:07:42,426::ifcfg::313::root::(writeBackupFile) Persistently backed up /var/lib/vdsm/netconfback/ifcfg-eth1 (until next 'set safe config')
MainProcess|Thread-17::DEBUG::2015-03-05 12:07:42,426::ifcfg::550::root::(writeConfFile) Writing to file /etc/sysconfig/network-scripts/ifcfg-eth1 configuration:
# Generated by VDSM version 4.16.8.1-7.el6ev
DEVICE=eth1
HWADDR=00:1a:4a:16:01:53
MASTER=bond0
SLAVE=yes
ONBOOT=yes
MTU=80000000
NM_CONTROLLED=no
.
.
.
MainProcess|Thread-17::INFO::2015-03-05 12:09:43,716::api::687::setupNetworks::(setupNetworks) Connectivity check failed, rolling back
.
.
.
.
ainProcess|Thread-17::INFO::2015-03-05 12:09:44,019::ifcfg::391::root::(restoreAtomicBackup) Restored /etc/sysconfig/network-scripts/ifcfg-rhevm
MainProcess|Thread-17::INFO::2015-03-05 12:09:44,020::ifcfg::391::root::(restoreAtomicBackup) Restored /etc/sysconfig/network-scripts/ifcfg-eth1
MainProcess|Thread-17::INFO::2015-03-05 12:09:44,020::ifcfg::391::root::(restoreAtomicBackup) Restored /etc/sysconfig/network-scripts/ifcfg-eth0
MainProcess|Thread-17::INFO::2015-03-05 12:09:44,020::ifcfg::391::root::(restoreAtomicBackup) Restored /etc/sysconfig/network-scripts/ifcfg-bond0

Comment 6 errata-xmlrpc 2015-03-06 20:24:46 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-0649.html

Comment 13 Dan Kenigsberg 2015-03-13 09:58:29 UTC

Ulhas, Pavel: please note that this bug is NOT the same issue of the "vanishing bond" bug 1154399.

The our bug 1197668 is about rolling back to manually-configured ifcfg files in case of failure in setupNetworks. In 99% of the cases it is unrelated to rhev-h (where users do not edit ifcfg files manually), and as such, it is not planned to be released in a node image.