Bug 1197709 (f22-kde-theme)
| Summary: | Review Request: f22-kde-theme - Fedora Twenty Two KDE Theme | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Than Ngo <than> |
| Component: | Package Review | Assignee: | Jan Grulich <jgrulich> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 22 | CC: | jgrulich, jreznik, kevin, package-review, rdieter, satellitgo |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | jgrulich:
fedora-review+
gwync: fedora-cvs+ |
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | kde-settings-22-3.fc22.1 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-04-21 19:02:29 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 656997, 1135100 | ||
|
Description
Than Ngo
2015-03-02 13:06:40 UTC
KDM and KSplash themes are not needed for Fedora 22. Or as KDM can be enabled optionally, we can consider having it available. 1) As Jaroslav mentioned, KDM and KSplash themes are not needed
2) Spec file mentions Fedora Twenty One instead of Fedora Twenty Two
3) You should probably use %{_datadir} instead %{_kde4_appsdir}
(In reply to Jan Grulich from comment #2) > 3) You should probably use %{_datadir} instead %{_kde4_appsdir} the desktoptheme are installed under /usr/share/kde4/apps/desktopthem, is there any reason why we should use %{_datadir} instead %{_kde4_appsdir} ? Spec URL: https://than.fedorapeople.org/f22/f22-kde-theme.spec SRPM URL: https://than.fedorapeople.org/f22/f22-kde-theme-21.91-1.fc21.src.rpm 1,2,3 are fixed now. This was with KDE 4, Plasma 5 installs themes under /usr/share/plasma/desktoptheme/ Looks good now, approved. Thanks. New Package SCM Request ======================= Package Name: f22-kde-theme Short Description: Fedora Twenty Two KDE Theme Upstream URL: http://fedorahosted.org/fedora-kde-artwork/ Owners: than,rdieter,mbriza,jreznik,jgrulich,ltinkl,dvratil Branches: f22 InitialCC: Git done (by process-git-requests). it's imported. f22-kde-theme-21.91-1.fc22.1,kde-settings-22-2.fc22.2 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/f22-kde-theme-21.91-1.fc22.1,kde-settings-22-2.fc22.2 f22-kde-theme-21.91-1.fc22.1, kde-settings-22-3.fc22 has been pushed to the Fedora 22 stable repository. Reopening as f22-kde-theme and f22-backgrounds-kde are missing on the F22 Beta RC2 live image. Expected result: proper Fedora theme available in Fedora 22 KDE. kde-settings-22-3.fc22.1, plasma-workspace-5.2.2-6.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/FEDORA-2015-5161/kde-settings-22-3.fc22.1,plasma-workspace-5.2.2-6.fc22 kde-settings-22-3.fc22.1,plasma-workspace-5.2.2-6.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/kde-settings-22-3.fc22.1,plasma-workspace-5.2.2-6.fc22 Package kde-settings-22-3.fc22.1, plasma-workspace-5.2.2-6.fc22: * should fix your issue, * was pushed to the Fedora 22 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing kde-settings-22-3.fc22.1 plasma-workspace-5.2.2-6.fc22' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2015-6239/kde-settings-22-3.fc22.1,plasma-workspace-5.2.2-6.fc22 then log in and leave karma (feedback). kde-settings-22-3.fc22.1, plasma-workspace-5.2.2-6.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. |