Bug 1197917
Summary: | tests fail because alembic_version can be created in MyISAM if that is the server default | ||
---|---|---|---|
Product: | [Retired] Beaker | Reporter: | Dan Callaghan <dcallagh> |
Component: | general | Assignee: | Dan Callaghan <dcallagh> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Dan Callaghan <dcallagh> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 19 | CC: | aigao, asaha, dcallagh |
Target Milestone: | 20.2 | Keywords: | Patch |
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2015-07-14 08:04:51 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Dan Callaghan
2015-03-03 00:34:35 UTC
On second thought, we could also just relax the check in test_all_tables_use_innodb to ignore alembic_version. There is probably no harm in letting alembic_version be on MyISAM (or any other storage engine) since we don't rely on any ACID properties or high performance or anything for that table -- it is only read and written when beaker-init is invoked. This wasn't caught by the dogfood job, because it configures default-storage-engine=innodb. If we go with this option: (In reply to Dan Callaghan from comment #0) > or (in the worst case) update all > our docs to reflect the requirement that InnoDB be configured as the default > storage engine. then we can leave dogfood as is, but otherwise we should remove the default-storage-engine=innodb line from the dogfood job definition. So Alembic doesn't offer any way to customise the table definition for alembic_version, and it doesn't really seem worth patching it to allow that. As per comment 1 we can just leave alembic_version on MyISAM and make the test skip it. Patch to make setup leave the default storage engine unset: https://git.beaker-project.org/cgit/beaker-meta-tasks/commit/?id=dea42e012f4f47d2d4f902dfc9621ae4f3a48e3e Patch to make the tests ignore the MySQL storage engine for alembic_version: http://gerrit.beaker-project.org/4186 This bug fix is included in beaker-server-21.0-0.git.8.0ec1fde.el6eng which is currently available for download here: https://beaker-project.org/nightlies/develop/ As per comment 3 we decided not to actually worry about which storage engine is used for alembic_version, this bug is just about the test suite failure when MyISAM is used. So marking this VERIFIED based on the fact that the tests are passing with the above two patches. Beaker 20.2 has been released. |