Bug 1198239

Summary: blivet-gui doesn't allow resize of partitions
Product: [Fedora] Fedora Reporter: Peter Robinson <pbrobinson>
Component: blivet-guiAssignee: Vojtech Trefny <vtrefny>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 22CC: pbrobinson, vtrefny
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-03-25 08:53:46 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Screenshot of unresizable partition
none
blivet.log
none
program.log from prev run none

Description Peter Robinson 2015-03-03 15:47:57 UTC 
Created attachment 997570 [details]
Screenshot of unresizable partition

When running blivet-gui (blivet-gui-0.2.2-2.fc22) it doesn't appear to allow partition resizing. 

Also when run specifying a device (like below) it doesn't select by default or use the specified device exclusively.

Screen shot attached of unresizble partition with 12.74GB free on the sd card

# blivet-gui /dev/mmcblk0
/usr/lib/python2.7/site-packages/blivetgui/devicevisualization/device_canvas.py:260: PyGIDeprecationWarning: Using positional arguments with the GObject constructor has been deprecated. Please specify keyword(s) for "schema" or use a class specific constructor. See: https://wiki.gnome.org/PyGObject/InitializerDeprecations
  settings = Gio.Settings('org.gnome.desktop.interface')
/usr/lib64/python2.7/site-packages/gi/overrides/__init__.py:234: Warning: The property GSettings:schema is deprecated and shouldn't be used anymore. It will be removed in a future version.
  return super_init_func(self, **new_kwargs)
/usr/lib/python2.7/site-packages/blivetgui/list_partitions.py:772: PyGTKDeprecationWarning: The "buttons" argument must be a Gtk.ButtonsType enum value. Please use the "add_buttons" method for adding buttons. See: https://wiki.gnome.org/PyGObject/InitializerDeprecations
  self.kickstart_mode)
/usr/lib64/python2.7/site-packages/gi/overrides/Gtk.py:537: PyGTKDeprecationWarning: Using positional arguments with the GObject constructor has been deprecated. Please specify keyword(s) for "title, transient_for, flags, add_buttons" or use a class specific constructor. See: https://wiki.gnome.org/PyGObject/InitializerDeprecations
  self._init(*args, **new_kwargs)
/usr/lib64/python2.7/site-packages/gi/overrides/Gtk.py:567: Warning: The property GtkButton:use-stock is deprecated and shouldn't be used anymore. It will be removed in a future version.
  self.add_button(text, response)
/usr/lib64/python2.7/site-packages/gi/overrides/Gtk.py:567: Warning: The property GtkSettings:gtk-button-images is deprecated and shouldn't be used anymore. It will be removed in a future version.
  self.add_button(text, response)
/usr/lib/python2.7/site-packages/blivetgui/dialogs/add_dialog.py:160: PyGTKDeprecationWarning: Using positional arguments with the GObject constructor has been deprecated. Please specify keyword(s) for "value, lower, upper, step_increment, page_increment, page_size" or use a class specific constructor. See: https://wiki.gnome.org/PyGObject/InitializerDeprecations
  1, 10, 0))
/usr/lib/python2.7/site-packages/blivetgui/dialogs/add_dialog.py:206: PyGTKDeprecationWarning: Using positional arguments with the GObject constructor has been deprecated. Please specify keyword(s) for "value, lower, upper, step_increment, page_increment, page_size" or use a class specific constructor. See: https://wiki.gnome.org/PyGObject/InitializerDeprecations
  self.max_size.convertTo(size.parseUnits(unit, False)), 1, 10, 0))
#

PS it also needs an icon ;-)
Comment 1 Vojtech Trefny 2015-03-03 17:05:02 UTC 
(In reply to Peter Robinson from comment #0)
> Created attachment 997570 [details]
> Screenshot of unresizable partition
> 
> When running blivet-gui (blivet-gui-0.2.2-2.fc22) it doesn't appear to allow
> partition resizing. 
> 

It should let you resize partitions (and LVs) but it sometimes doesn't work, please run blivet-gui again (with the SD card) and attach /tmp/blivet.log and /tmp/program.log too, thanks.


> Also when run specifying a device (like below) it doesn't select by default
> or use the specified device exclusively.
> 

This is not implemented (see "blivet-gui --help" for list of available command-line options). But it look a good idea to implement this.

> PS it also needs an icon ;-)

I know, I need to ask somebody to create it for me. (I've tried to create something myself and it was terrible.)
Comment 2 Peter Robinson 2015-03-03 17:11:45 UTC 
Created attachment 997593 [details]
blivet.log

The blivet.log from previous run
Comment 3 Peter Robinson 2015-03-03 17:12:15 UTC 
Created attachment 997594 [details]
program.log from prev run
Comment 4 Peter Robinson 2015-03-03 17:14:16 UTC 
> It should let you resize partitions (and LVs) but it sometimes doesn't work,
> please run blivet-gui again (with the SD card) and attach /tmp/blivet.log
> and /tmp/program.log too, thanks.

Attached from previous run(s), not sure if it zeros out with each new run.

> This is not implemented (see "blivet-gui --help" for list of available
> command-line options). But it look a good idea to implement this.

Ah, was just assuming based on what I've usually done with other disk tools (parted/gparted)

> > PS it also needs an icon ;-)
> 
> I know, I need to ask somebody to create it for me. (I've tried to create
> something myself and it was terrible.)

:-D I'd ask one of the Fedora design people nicely :)
Comment 5 Vojtech Trefny 2015-03-04 15:40:22 UTC 
(In reply to Peter Robinson from comment #4)
> > It should let you resize partitions (and LVs) but it sometimes doesn't work,
> > please run blivet-gui again (with the SD card) and attach /tmp/blivet.log
> > and /tmp/program.log too, thanks.
> 
> Attached from previous run(s), not sure if it zeros out with each new run.
> 

Ok, according to program.log, filesystem on the /dev/mmcblk0p3 is corrupted, so it is not possible to resize it.

INFO:program: Running... e2fsck -f -p -C 0 /dev/mmcblk0p3
INFO:program: stdout:
INFO:program: _/: The filesystem size (according to the superblock) is 3681280 blocks
INFO:program: The physical size of the device is 341760 blocks
INFO:program: Either the superblock or the partition table is likely to be corrupt!

I've added a small patch to display reason why is not possible to resize the device -- https://vtrefny.fedorapeople.org/blivet-gui/blivet-gui_resize.png
Comment 6 Peter Robinson 2015-03-04 15:43:32 UTC 
> Ok, according to program.log, filesystem on the /dev/mmcblk0p3 is corrupted,
> so it is not possible to resize it.
> 
> INFO:program: Running... e2fsck -f -p -C 0 /dev/mmcblk0p3
> INFO:program: stdout:
> INFO:program: _/: The filesystem size (according to the superblock) is
> 3681280 blocks
> INFO:program: The physical size of the device is 341760 blocks
> INFO:program: Either the superblock or the partition table is likely to be
> corrupt!
> 
> I've added a small patch to display reason why is not possible to resize the
> device -- https://vtrefny.fedorapeople.org/blivet-gui/blivet-gui_resize.png

parted resized it without issues. Also might be useful to have something like "filesystem X isn't clean do you wish for us to fix this?" option too given it's a disk util after all :)
Comment 7 Fedora Update System 2015-03-13 16:59:53 UTC 
blivet-gui-0.2.3-1.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/blivet-gui-0.2.3-1.fc22
Comment 8 Fedora Update System 2015-03-19 18:39:32 UTC 
blivet-gui-0.2.3-1.fc22 has been pushed to the Fedora 22 stable repository.  If problems still persist, please make note of it in this bug report.