Bug 1198518

Summary: inaccurate description of getSecurityModel API
Product: Red Hat Enterprise Linux 7 Reporter: lcheng
Component: libvirt-pythonAssignee: Ján Tomko <jtomko>
Status: CLOSED ERRATA QA Contact: Virtualization Bugs <virt-bugs>
Severity: medium Docs Contact:
Priority: medium    
Version: 7.1CC: dyuan, honzhang, jdenemar, mzhan, weizhan
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: libvirt-python-1.2.14-1.el7 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-11-19 05:34:36 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description lcheng 2015-03-04 10:29:38 UTC
Description of problem:
Provided a error description about the api of getSecurityModel in libvirt-python. Actually, the getSecurityModel returns the security model of a hypervisor, not the securify model of the host.


Version-Release number of selected component (if applicable):
libvirt-1.2.8-16.el7_1.1.x86_64
libvirt-python-1.2.8-7.el7_1.1.x86_64


How reproducible:
100%


Steps:
1. In libvirt-python.
[root@localhost ~]# rpm -ql libvirt-python
/usr/lib64/python2.7/site-packages/libvirt.py
...

[root@localhost ~]# vim /usr/lib64/python2.7/site-packages/libvirt.py
...
    def getSecurityModel(self):
        """Extract information about the host security model """
...

2. In libvirt-docs. 
[root@localhost ~]# firefox /usr/share/doc/libvirt-docs-1.2.8/html/html/libvirt-libvirt.html
...
int	virNodeGetSecurityModel		(virConnectPtr conn,
					 virSecurityModelPtr secmodel)

Extract the security model of a hypervisor. The 'model' field in the @secmodel argument may be initialized to the empty string if the driver has not activated a security model.
...


Actual results :
As description.

Expected results :
Improve the description in libvirt-python.

Additional info:
[root@localhost ~]# vim /etc/libvirt/qemu.conf
...
# The default security driver is SELinux. If SELinux is disabled
# on the host, then the security driver will automatically disable
# itself. If you wish to disable QEMU SELinux security driver while
# leaving SELinux enabled for the host in general, then set this
# to 'none' instead.
...

Comment 2 Ján Tomko 2015-03-05 15:15:02 UTC
commit 713ed9d570df92b3ba029b4cbb3cd7a4c45bf1de
Author:     Ján Tomko <jtomko>
CommitDate: 2015-03-05 16:08:51 +0100

    Clarify description for virNodeGetSecurityModel
    
    s/host/hypervisor/ to match the wording used by the C binding.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1198518

git describe: v1.2.13-1-g713ed9d

Comment 4 hongming 2015-05-12 09:39:48 UTC
Verify it as follows. The result is expected. Move its status to VERIFIED.


# rpm -q libvirt-python
libvirt-python-1.2.15-1.el7.x86_64


# vim /usr/lib64/python2.7/site-packages/libvirt.py

3809     def getSecurityModel(self):
3810         """Extract information about the hypervisor security model """
3811         ret = libvirtmod.virNodeGetSecurityModel(self._o)
3812         if ret is None: raise libvirtError ('virNodeGetSecurityModel() failed', conn=self)
3813         return ret

Comment 6 errata-xmlrpc 2015-11-19 05:34:36 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-2203.html