Bug 1198735
| Summary: | applying an uploaded csv file leads leads to an incorrect redirection | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Felix Dewaleyne <fdewaley> | ||||
| Component: | UI - OPS | Assignee: | Martin Hradil <mhradil> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Nandini Chandra <nachandr> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | 5.3.0 | CC: | dclarizi, fdewaley, hkataria, jhardy, mfeifer, mhradil, mpovolny, nachandr, obarenbo, rananda, ssainkar | ||||
| Target Milestone: | GA | ||||||
| Target Release: | 5.4.0 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: |
In the previous version, after importing a csv file with tags to apply to VMs in configuration > configure > region[1] > import tags, clicking on "apply" leads to a page "The page you were looking for doesn't exist." This was because there were no GET routes for settings_import or settings_import_tags.
With this release, apply button POSTs when importing csv file for tagging, not GET. As a result, the import is now successful without an error.
|
Story Points: | --- | ||||
| Clone Of: | |||||||
| : | 1205219 (view as bug list) | Environment: | |||||
| Last Closed: | 2015-06-16 12:51:51 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1205219 | ||||||
| Attachments: |
|
||||||
|
Description
Felix Dewaleyne
2015-03-04 17:35:12 UTC
Ramesh, can you please try to reproduce this. Able to reproduce in 5.4.0.0.10.20150218155857_33bdc17. New commit detected on manageiq/master: https://github.com/ManageIQ/manageiq/commit/63c39513e0115f1a1b08d1889f71dfda233c1112 commit 63c39513e0115f1a1b08d1889f71dfda233c1112 Author: Martin Hradil <mhradil> AuthorDate: Mon Mar 9 14:23:33 2015 +0000 Commit: Martin Hradil <mhradil> CommitDate: Mon Mar 9 14:23:33 2015 +0000 Split AssetTagImport and ClassificationImport from miq_bulk_import.rb into their own files Prevents autoloader from failing to load ClassificationImport when referred to in session https://bugzilla.redhat.com/show_bug.cgi?id=1198735 vmdb/app/models/asset_tag_import.rb | 117 ++++++++++++++++ vmdb/app/models/classification_import.rb | 111 +++++++++++++++ vmdb/app/models/miq_bulk_import.rb | 230 ------------------------------- 3 files changed, 228 insertions(+), 230 deletions(-) create mode 100644 vmdb/app/models/asset_tag_import.rb create mode 100644 vmdb/app/models/classification_import.rb New commit detected on manageiq/master: https://github.com/ManageIQ/manageiq/commit/cf3c62c769913154adef69b04eea5dfe89d5bac3 commit cf3c62c769913154adef69b04eea5dfe89d5bac3 Author: Martin Hradil <mhradil> AuthorDate: Mon Mar 9 15:56:33 2015 +0000 Commit: Martin Hradil <mhradil> CommitDate: Mon Mar 9 15:56:33 2015 +0000 _x_edit_buttons - supoort apply_method - Apply needs to POST for settings_import* There are no GET routes for settings_import or settings_import_tags, thus the Apply button needs to POST in that case https://bugzilla.redhat.com/show_bug.cgi?id=1198735 vmdb/app/controllers/ops_controller.rb | 3 ++- vmdb/app/views/layouts/_x_edit_buttons.html.haml | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) Martin, can we cherry-pick this back to 5.3.z (5.3.4) please? New commit detected on cfme/5.3.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=962317f25c784f8df44afe4d010cada2adcd5189 commit 962317f25c784f8df44afe4d010cada2adcd5189 Author: Martin Hradil <mhradil> AuthorDate: Tue Mar 24 13:16:53 2015 +0000 Commit: Martin Hradil <mhradil> CommitDate: Tue Mar 24 13:16:53 2015 +0000 _x_edit_buttons - supoort apply_method - Apply needs to POST for settings_import* There are no GET routes for settings_import or settings_import_tags, thus the Apply button needs to POST in that case https://bugzilla.redhat.com/show_bug.cgi?id=1198735 (cherry-picked from cf3c62c769913154adef69b04eea5dfe89d5bac3, by hand because erb vs. haml) vmdb/app/controllers/ops_controller.rb | 1 + vmdb/app/views/layouts/_x_edit_buttons.html.erb | 2 ++ 2 files changed, 3 insertions(+) Dave, it's done (in 5.3.5, according to bz1205219). Verified that tags are correctly applied after importing a csv tag file. Used the uploaded file(tag.csv) for verification. Verified in 5.4.0.0.19.20150410165622_ad23806. Created attachment 1019402 [details]
tag file
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2015-1100.html |