Bug 1198963

Summary:	set errno if gf_strdup() failed
Product:	[Community] GlusterFS	Reporter:	Humble Chirammal <hchiramm>
Component:	libgfapi	Assignee:	bugs <bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Sudhir D <sdharane>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	mainline	CC:	bugs, gluster-bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	glusterfs-3.7.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-05-14 17:29:16 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Humble Chirammal 2015-03-05 08:18:51 UTC

Description of problem:

Return proper errno if gf_strdup() failed.

Version-Release number of selected component (if applicable):

GlusterFS 3.6.2

How reproducible:

N/A

Steps to Reproduce:

N/A

Actual results:

Currently the result of gf_strdup() is not checked and  missed to return ENOMEM if in case there was a failure.

Expected results:

It should return ENOMEM if there was a failure.

Additional info:

Comment 1 Anand Avati 2015-03-05 08:22:34 UTC

REVIEW: http://review.gluster.org/9807 (libgfapi : set errno if gf_strdup failed.) posted (#1) for review on master by Humble Devassy Chirammal (humble.devassy)

Comment 2 Anand Avati 2015-03-05 08:58:21 UTC

REVIEW: http://review.gluster.org/9807 (libgfapi : set errno if gf_strdup() failed.) posted (#2) for review on master by Humble Devassy Chirammal (humble.devassy)

Comment 3 Anand Avati 2015-03-05 09:32:00 UTC

REVIEW: http://review.gluster.org/9807 (libgfapi: set errno if gf_strdup() failed.) posted (#3) for review on master by Humble Devassy Chirammal (humble.devassy)

Comment 4 Anand Avati 2015-03-05 12:41:35 UTC

REVIEW: http://review.gluster.org/9807 (libgfapi : return  if gf_strdup failed.) posted (#4) for review on master by Humble Devassy Chirammal (humble.devassy)

Comment 5 Anand Avati 2015-03-30 13:34:38 UTC

REVIEW: http://review.gluster.org/9807 (libgfapi : return  if gf_strdup failed) posted (#5) for review on master by Humble Devassy Chirammal (humble.devassy)

Comment 6 Anand Avati 2015-04-01 10:55:49 UTC

COMMIT: http://review.gluster.org/9807 committed in master by Niels de Vos (ndevos) 
------
commit 07bd6c320c75c39b599929039d028fbc497d4322
Author: Humble Devassy Chirammal <hchiramm>
Date:   Mon Mar 30 18:59:52 2015 +0530

    libgfapi : return  if gf_strdup failed
    
    Change-Id: Ic8ad48b8118a8505ebbab2e9084007acca7226e9
    BUG: 1198963
    Signed-off-by: Humble Devassy Chirammal <hchiramm>
    Reviewed-on: http://review.gluster.org/9807
    Reviewed-by: Niels de Vos <ndevos>
    Tested-by: Gluster Build System <jenkins.com>

Comment 7 Niels de Vos 2015-05-14 17:29:16 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 8 Niels de Vos 2015-05-14 17:35:52 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 9 Niels de Vos 2015-05-14 17:38:14 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 10 Niels de Vos 2015-05-14 17:46:13 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user