Bug 1199073

Summary: creating a resource name colliding with an existing group/clone/master ID needs better error message
Product: Red Hat Enterprise Linux 7 Reporter: Radek Steiger <rsteiger>
Component: pcsAssignee: Tomas Jelinek <tojeline>
Status: CLOSED ERRATA QA Contact: cluster-qe <cluster-qe>
Severity: unspecified Docs Contact:
Priority: medium    
Version: 7.1CC: cluster-maint, mlisik, tojeline
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: pcs-0.9.140-1.el7 Doc Type: Bug Fix
Doc Text:
Cause: User tries to create a resource with an id that already exists in a CIB. Consequence: pcs produces an invalid CIB, exits with an error and dumps the CIB to a terminal. Fix: Check whether specified resource id already exists. Result: pcs exits gracefully with an explanatory error message.
 Story Points: ---
Clone Of: Environment:
Last Closed: 2015-11-19 09:36:06 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
proposed fix none

Description Radek Steiger 2015-03-05 12:45:50 UTC 
> Description of problem:

If a grouped/cloned/MS resource already exists in a cluster and a new resource, which name is identical to an ID of that group/clone/MS, an invalid CIB is produced instead of a proper error message.

We could get an inspiration from adding a colliding resource ID, where we have a proper error message:
"Error: unable to create resource/fence device 'dummy0', 'dummy0' already exists on this system"


> Version-Release number of selected component (if applicable):

pcs-0.9.137-10.el7


> How reproducible:

Always


> Steps to Reproduce:

1. pcs resource create dummy0 Dummy --clone
2. pcs resource create dummy0-clone Dummy


> Actual results:

Error: Unable to update cib
Call cib_replace failed (-203): Update does not conform to the configured schema
...


> Expected results:

"Error: unable to create resource/fence device 'dummy0-clone', 'dummy0-clone' already exists on this system"
Comment 2 Tomas Jelinek 2015-04-07 09:45:18 UTC 
Created attachment 1011674 [details]
proposed fix
Comment 4 Tomas Jelinek 2015-06-04 14:45:49 UTC 
Before Fix:
[root@rh71-node1 ~]# rpm -q pcs
pcs-0.9.137-13.el7_1.2.x86_64
[root@rh71-node1:~]# pcs resource create dummy dummy --clone
[root@rh71-node1:~]# pcs resource
 Clone Set: dummy-clone [dummy]
     Started: [ rh71-node1 rh71-node2 rh71-node3 ]
[root@rh71-node1:~]# pcs resource create dummy-clone dummy
Error: Unable to update cib
Call cib_replace failed (-203): Update does not conform to the configured schema
...



After Fix:
[root@rh71-node1:~]# rpm -q pcs
pcs-0.9.140-1.el6.x86_64
[root@rh71-node1:~]# pcs resource create dummy dummy --clone
[root@rh71-node1:~]# pcs resource
 Clone Set: dummy-clone [dummy]
     Started: [ rh71-node1 rh71-node2 rh71-node3 ]
[root@rh71-node1:~]# pcs resource create dummy-clone dummy
Error: unable to create resource/fence device 'dummy-clone', 'dummy-clone' already exists on this system
[root@rh71-node1:~]# echo $?
1
Comment 8 errata-xmlrpc 2015-11-19 09:36:06 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2015-2290.html