Bug 1199224

Summary: Qcow probe fails to detect qcow virtual disk
Product: Red Hat CloudForms Management Engine Reporter: Rich Oliveri <roliveri>
Component: SmartState AnalysisAssignee: Rich Oliveri <roliveri>
Status: CLOSED ERRATA QA Contact: Sean Myers <sean.myers>
Severity: high Docs Contact:
Priority: unspecified    
Version: 5.4.0CC: dajohnso, jhardy, jprause, mfeifer, obarenbo, roliveri, sean.myers
Target Milestone: GAKeywords: ZStream
Target Release: 5.3.4   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.3.4.1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1198814 Environment:
Last Closed: 2015-04-29 13:20:13 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1198814    
Bug Blocks:    

Comment 1 CFME Bot 2015-03-05 18:16:11 UTC
New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/c130d908e540a11fdf5da5d12cbcfa8a1a1cac2b

commit c130d908e540a11fdf5da5d12cbcfa8a1a1cac2b
Author:     Richard Oliveri <roliveri>
AuthorDate: Thu Mar 5 11:49:14 2015 -0500
Commit:     Richard Oliveri <roliveri>
CommitDate: Thu Mar 5 11:49:14 2015 -0500

    Force encoding of Qcow magic.
    
    Account for new default string encoding in Ruby 2, by
    forcing the encoding of the qcow magic string.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1198814
    https://bugzilla.redhat.com/show_bug.cgi?id=1199224

 lib/disk/modules/QcowDiskProbe.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment 2 CFME Bot 2015-03-05 18:41:04 UTC
New commit detected on cfme/5.3.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=1aa4d7fa93d6ce9e89235077654697f8d5e48b97

commit 1aa4d7fa93d6ce9e89235077654697f8d5e48b97
Author:     Richard Oliveri <roliveri>
AuthorDate: Thu Mar 5 11:49:14 2015 -0500
Commit:     Richard Oliveri <roliveri>
CommitDate: Thu Mar 5 13:39:00 2015 -0500

    Force encoding of Qcow magic.
    
    Account for new default string encoding in Ruby 2, by
    forcing the encoding of the qcow magic string.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1198814
    https://bugzilla.redhat.com/show_bug.cgi?id=1199224

 lib/disk/modules/QcowDiskProbe.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment 4 Sean Myers 2015-04-21 20:00:03 UTC
There are no reproduction steps and I don't see QcowDiskProbe being used anywhere in the code, so I'm at a loss with regard to verification. Is this code used somewhere in 5.3? If so, where/how?

Thanks.

Comment 5 Rich Oliveri 2015-04-21 20:08:18 UTC
The probes are called by MiqDisk#getDisk to determine the type of disk file. The problem can be reproduced by fleecing a rhev VM that's in qcow format.

Comment 8 errata-xmlrpc 2015-04-29 13:20:13 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-0890.html