Bug 1199263
| Summary: | anaconda crash handling fails if any related package has an epoch due to bad handling of epochs in python-meh | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Adam Williamson <awilliam> |
| Component: | python-meh | Assignee: | Vratislav Podzimek <vpodzime> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | high | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 22 | CC: | danofsatx, mkolman, mruckman, robatino, satellitgo, sgallagh, vpodzime |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | AcceptedBlocker | ||
| Fixed In Version: | python-meh-0.36-1.fc22 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-03-07 00:08:27 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1043121 | ||
|
Description
Adam Williamson
2015-03-05 18:48:59 UTC
For Posterity, the traceback you see when this happens is:
Traceback (most recent call last):
File "/usr/lib64/python2.7/site-packages/pyanaconda/exception.py", line 86, in _main_loop_handleException
super(AnacondaExceptionHandler, self).handleException(dump_info)
File "/usr/lib/python2.7/site-packages/meh/handler.py", line 123, in handleException
responseHash[rc](dump_info.exc_info)
File "/usr/lib/python2.7/site-packages/meh/handler.py", line 223, in runSave
params.update(self.exn.environment_info)
File "/usr/lib/python2.7/site-packages/meh/dump.py", line 263, in environment_info
return self._get_environment_info()
File "/usr/lib/python2.7/site-packages/meh/dump.py", line 241, in _get_environment_info
other_packages = ", ".join(get_other_packages(self))
File "/usr/lib/python2.7/site-packages/meh/dump.py", line 199, in get_other_packages
pkg_info = get_package_and_component(fn)[0]
File "/usr/lib/python2.7/site-packages/meh/dump.py", line 160, in get_package_and_component
header["epoch"].decode("utf-8") if header["epoch"] else "0",
AttributeError: 'long' object has no attribute 'decode'
+1 we really need to be able to have bugs reported. I'm -1 to a blocker. The criterion doesn't mandate that every possible crash can be reported (I realize that's a bit of a fudge, but it's not like we can report a kernel panic or a network failure either...) I'd be +1 to FE though, if RC1 doesn't get green-lit. +1 blocker. sgallagh: we can actually re-do RC1 with this; mkolman is going to do a quick build with the fix for it, and dgilmore is still around to refire the compose. For the record I've tested the fix by hand-editing python-meh in a live image, and it looks good (I also tested that it doesn't break the negative case, where no epoch is involved). +1 blocker, since it does actually violate the criteria and we have a fix and can refire the build. If it was going to lead to us slipping I would have leaned more towards -1 with the same logic as sgallagh. +1. Read Mike's response for the reasoning. After a long conversation on IRC, I'm going to change my vote to +0. I can't make myself believe this is a true blocker, but I'm not going to stand in the way. python-meh-0.36-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/python-meh-0.36-1.fc22 I count +4 (not including myself) here, with votes from QA, releng and dev (sgallagh), so that makes this a blocker. Will file RC1 respin request shortly. The update was pulled into RC3 and I verified the fix in testing. Setting VERIFIED. Thanks a lot for the quick response on this! python-meh-0.36-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. |