Bug 1199388

Summary: glfs_new does not check if volname is NULL
Product: [Community] GlusterFS Reporter: Prashanth Pai <ppai>
Component: libgfapiAssignee: Prashanth Pai <ppai>
Status: CLOSED CURRENTRELEASE QA Contact: Sudhir D <sdharane>
Severity: low Docs Contact:
Priority: low    
Version: mainlineCC: bugs, gluster-bugs
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.7.0 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-05-14 17:29:17 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Prashanth Pai 2015-03-06 05:46:00 UTC
Description of problem:
While using libgfapi-python bindings, a "None" passed as volname would translate to NULL being passed to glfs_new(). This causes segfault.

Expected results:
glfs_new() should error out gracefully with errno set to EINVAL.

Comment 1 Anand Avati 2015-03-06 05:50:15 UTC
REVIEW: http://review.gluster.org/9735 (gfapi: Add NULL check for volname in glfs_new()) posted (#5) for review on master by Prashanth Pai (ppai)

Comment 2 Anand Avati 2015-03-08 17:02:18 UTC
COMMIT: http://review.gluster.org/9735 committed in master by Niels de Vos (ndevos) 
------
commit 9b3c799fa3a5535e189d18200324d912339ac6a6
Author: Prashanth Pai <ppai>
Date:   Tue Feb 24 16:48:20 2015 +0530

    gfapi: Add NULL check for volname in glfs_new()
    
    BUG: 1199388
    Change-Id: I66cb65355504eb47e4392576029a9a5422996a1b
    Signed-off-by: Prashanth Pai <ppai>
    Reviewed-on: http://review.gluster.org/9735
    Reviewed-by: Shyamsundar Ranganathan <srangana>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Niels de Vos <ndevos>

Comment 3 Niels de Vos 2015-05-14 17:29:17 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 4 Niels de Vos 2015-05-14 17:35:52 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 5 Niels de Vos 2015-05-14 17:38:14 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 6 Niels de Vos 2015-05-14 17:46:13 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user