Bug 1199406

Summary: Spurious failures with tests/bugs/geo-replication/bug-877293.t
Product: [Community] GlusterFS Reporter: Pranith Kumar K <pkarampu>
Component: unclassifiedAssignee: Pranith Kumar K <pkarampu>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: mainlineCC: bugs, gluster-bugs, jbyers
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.7.0 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-05-14 17:29:17 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Pranith Kumar K 2015-03-06 07:24:57 UTC
Description of problem:
tests/bugs/geo-replication/bug-877293.t fails spuriously.

    libxlator: Make sure marker_xattr is valid
    
    Problem:
    marker_xattr is allocated only when the op_ret is 0. If the final response is
    a failure, then the marker time is dict_set with key as NULL. this will be
    changed to ref:<address-of-value> by dict_set, so the value won't appear on the
    marker-key when the getxattr_cbk is in dht. So dht unwinds with failure EINVAL.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Anand Avati 2015-03-06 07:29:43 UTC
REVIEW: http://review.gluster.org/9817 (libxlator: Make sure marker_xattr is valid) posted (#1) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 2 Anand Avati 2015-03-07 05:16:31 UTC
REVIEW: http://review.gluster.org/9817 (libxlator: Make sure marker_xattr is valid) posted (#2) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 3 Anand Avati 2015-03-09 10:15:10 UTC
COMMIT: http://review.gluster.org/9817 committed in master by Raghavendra G (rgowdapp) 
------
commit b5e50cd714d105ff7aa1544182f07fb60320710d
Author: Pranith Kumar K <pkarampu>
Date:   Fri Mar 6 12:37:15 2015 +0530

    libxlator: Make sure marker_xattr is valid
    
    Problem:
    marker_xattr is allocated only when the op_ret is 0. If the final response is
    a failure, then the marker time is dict_set with key as NULL. this will be
    changed to ref:<address-of-value> by dict_set, so the value won't appear on the
    marker-key when the getxattr_cbk is in dht. So dht unwinds with failure EINVAL.
    
    Fix:
    Always populate marker_xattr. Fixed dict mem-leak as well.
    
    Change-Id: I1752f277a8852c47b0a2ccce9fd72ee88456ac02
    BUG: 1199406
    Signed-off-by: Pranith Kumar K <pkarampu>
    Reviewed-on: http://review.gluster.org/9817
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Raghavendra G <rgowdapp>
    Tested-by: Raghavendra G <rgowdapp>

Comment 4 Niels de Vos 2015-05-14 17:29:17 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 5 Niels de Vos 2015-05-14 17:35:52 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 6 Niels de Vos 2015-05-14 17:38:14 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 7 Niels de Vos 2015-05-14 17:46:13 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user