Bug 1199523

Summary:	Review Request: perl-Proc-Guard - Process runner with RAII pattern
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Petr Šabata <psabata>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, psabata
Target Milestone:	---	Flags:	psabata: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Proc-Guard-0.06-1.fc23	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-03-09 08:52:09 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Petr Pisar 2015-03-06 14:54:14 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-Proc-Guard/perl-Proc-Guard.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Proc-Guard/perl-Proc-Guard-0.06-1.fc23.src.rpm
Description:
Proc::Guard runs process, and destroys it when the perl script exits.
This is useful for testing code working with server process.

Fedora Account System Username: ppisar

Comment 1 Petr Šabata 2015-03-06 15:32:48 UTC

Note: Move IO::Socket::INET BR to your "optional tests" section; it won't be loaded in case the Test::Requires check fails.

Protip: Remove the `author_tests' call from Makefile.PL; this will let you drop a buildtime dependency you're not using anyway (Module::Install::AuthorTests).

No issues.  Approving.

Comment 2 Petr Pisar 2015-03-06 16:35:46 UTC

New Package SCM Request
=======================
Package Name: perl-Proc-Guard
Short Description: Process runner with RAII pattern
Upstream URL: http://search.cpan.org/dist/Proc-Guard/
Owners: ppisar jplesnik psabata
Branches: 
InitialCC: perl-sig

Comment 3 Gwyn Ciesla 2015-03-06 17:02:46 UTC

Git done (by process-git-requests).

Comment 4 Petr Pisar 2015-03-09 08:52:09 UTC

Thank your for the review and the repository.

I moved the IO::Socket::INET to optional tests.