Bug 1199553 (f22-kde-gtk3-csd)

Summary: kde-settings: gtk3 CSD issues
Product: [Fedora] Fedora Reporter: Rex Dieter <rdieter>
Component: kde-settingsAssignee: Rex Dieter <rdieter>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 22CC: dvratil, jgrulich, jreznik, kevin, ltinkl, mbriza, rdieter, rnovacek, smparrish, than
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: gtk3-3.15.11-1.fc22 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-05-19 15:15:38 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1135100    
Attachments:
Description Flags
gnotes on plasma5 with transparent (csd) border none

Description Rex Dieter 2015-03-06 15:41:09 UTC 
Created attachment 998919 [details]
gnotes on plasma5 with transparent (csd) border

gtk3 apps (with client side decorataions, CSD) currently look a bit wierd on plasma5 (See attachment).

mgraesslin (kwin upstream) suggested some options: we can 

* disable the script the enforces win decorations
* we set a custom theme that sets shadow margins to 0

I asked Workstation WG, and they are ok with either option, though (obviously) prefer the first option.

Fwiw, there's a gnome upstream tracking bug on the topic,
https://bugzilla.gnome.org/show_bug.cgi?id=729721

but I'm not hopeful that it will be resolved any time soon.
Comment 1 Kevin Kofler 2015-03-07 00:39:57 UTC 
> * we set a custom theme that sets shadow margins to 0

That does not really solve the issue. It will remove the ugly margin between the 2 window decorations, but it will NOT fix the fact that there are 2 decorations to begin with, which IMHO is a blocker.

What we really need is for GTK+ to disable CSD under KDE Plasma entirely, something they have refused to do. Failing that, showing only the CSD is the only option we have.
Comment 2 Kevin Kofler 2015-03-07 00:50:41 UTC 
The sad thing is that there was actually a patch to disable CSD under non-GNOME:
https://bugzilla.gnome.org/show_bug.cgi?id=729721#c13
but it got reverted by:
https://git.gnome.org/browse/gtk+/commit/?id=fb9a6bb6d8d6b60b25c9b9853decbcea938f7863
supposedly to prevent showing double borders, but showing double borders is exactly what that "fix" results in!
Comment 3 Kevin Kofler 2015-03-07 00:55:06 UTC 
And the real cause of the double headers (i.e. https://bugzilla.gnome.org/show_bug.cgi?id=727414) was that even with CSD disabled, GTK+ draws a redundant title bar just in case the dialog wants to hide some controls in there (even when it doesn't, see the "Find file" example in the linked bug report).
Comment 4 Rex Dieter 2015-03-10 01:59:14 UTC 
Looks like the gtk3 put the check back after all,
https://git.gnome.org/browse/gtk+/commit/?id=5ced234144ce63decbf5afc8a3517290b9027018

So once that gets into gtk3 packaging and we can test/verify, we can probably close this.
Comment 5 Rex Dieter 2015-03-12 17:35:03 UTC 
https://admin.fedoraproject.org/updates/gtk3-3.15.11-1.fc22

tests good for me, closing.
Comment 6 Rex Dieter 2015-03-12 17:38:19 UTC 
I take it back, the transparent borders are gone, but we're still seeing double win decorations.
Comment 7 Rex Dieter 2015-03-12 18:06:27 UTC 
an Kwin's script "Enforces Window Decorations on GTK+ Window" has no effect, I see double decorations whether it's enabled or not.

I suspect it keyed off the CSD shadow stuff that was recently disabled in gtk3.