Bug 1199634

Yes please, you're welcome. I'm busy at the moment and I don't have time to devote to this in the next few days.

Thanks,
--Simone

Well, now that FreeRDP has been updated to 1.2.0 in Fedora 22 we also need to fix the remaining packages depending on it.

I've updated Remmina, now I need a fix for Guacamole Server. Upstream does not support yet FreeRDP newer than any of the released tarball.

Could you help on that? A simple rebuild of Guacamole Server breaks when compiling RDP support.

Thanks,
--Simone

remmina-1.2.0-0.3.git.b3e339e.fc22, freerdp-1.2.1-0.1.git.6ac7180.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/FEDORA-2015-3632/freerdp-1.2.1-0.1.git.6ac7180.fc22,remmina-1.2.0-0.3.git.b3e339e.fc22

Package remmina-1.2.0-0.3.git.b3e339e.fc22, freerdp-1.2.1-0.1.git.6ac7180.fc22:
* should fix your issue,
* was pushed to the Fedora 22 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing remmina-1.2.0-0.3.git.b3e339e.fc22 freerdp-1.2.1-0.1.git.6ac7180.fc22'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-3632/freerdp-1.2.0-0.7.beta.1.fc22
then log in and leave karma (feedback).

Created attachment 1001523 [details]
partial hack


Hm, that's non-trivial to fix. I wonder if we should stick with a snapshot from just before the svc_plugin and event stuff was removed, and *just* add in the later shadow support?

Here's a patch which goes some way to fixing it, by lifting the (Apache-licensed) svc_plugin code and resurrecting it as part of guacamole. It wants doing properly, but quite frankly if I did it I'd still be cutting and pasting Apache-licensed code from https://github.com/FreeRDP/FreeRDP/commit/986dae429b which shows how to do it, so I might a well be honest about it and take the whole file containing the original version.

Now it's falling over on event stuff, which has also been replaced.

https://glyptodon.org/jira/browse/GUAC-1130

Ok, I think I have this working by reverting to FreeRDP commit 24a752a which is new enough to have freerdp-shadow but old enough to not have most of the API breakage. And fixing up the remainder of the API breakage in guacamole-server.

Btw I note you reformatted and sorted the BuildRequires on the remmina package... but you didn't actually make them comply with the packaging guidelines that say you should require (e.g.) 'pkgconfig(gtk+-3.0)' rather than 'gtk3-devel'

(In reply to David Woodhouse from comment #7)
> Ok, I think I have this working by reverting to FreeRDP commit 24a752a which
> is new enough to have freerdp-shadow but old enough to not have most of the
> API breakage. And fixing up the remainder of the API breakage in
> guacamole-server.

Thanks for all the work on this!

> Btw I note you reformatted and sorted the BuildRequires on the remmina
> package... but you didn't actually make them comply with the packaging
> guidelines that say you should require (e.g.) 'pkgconfig(gtk+-3.0)' rather
> than 'gtk3-devel'

Thanks, I've updated them now.

The only "weird" thing is that now FreeRDP is not again at version 1.2.1 but has gone back to 1.2.0-beta1. The freerdp-devel package now provides "pkgconfig(freerdp) = 1.2.0-beta1" even if the freerdp package is explicitly at 1.2.1.

I'm adding Pavel Alexeev in CC so he knows what's going on.

(In reply to Simone Caronni from comment #8)
> The only "weird" thing is that now FreeRDP is not again at version 1.2.1 but
> has gone back to 1.2.0-beta1. The freerdp-devel package now provides
> "pkgconfig(freerdp) = 1.2.0-beta1" even if the freerdp package is explicitly
> at 1.2.1.

Hm, we *can* fix that without an epoch bump, can't we? The new packages never made it to F22 updates, only updates-testing.

Actually we already have a non-zero epoch, although I can't work out why you did it. A non-zero epoch is ugly, but bumping it from 1 to 2 is definitely not something I'd lose sleep over. Shall we just do that?

(In reply to David Woodhouse from comment #11)
> Actually we already have a non-zero epoch, although I can't work out why you
> did it.

I had committed some code to git when testing 1.1.x in Fedora 20, and another person who required some feature added some commits abd pushed the build into the updates-testing. Going back was the only chance.

> A non-zero epoch is ugly, but bumping it from 1 to 2 is definitely
> not something I'd lose sleep over. Shall we just do that?

Personally I would have left 1.2.1 as version and just coped with the fact that freerdp-devel was providing pkgconfig(freerdp) = 1.2.0-beta1. I'm pretty sure we will update it again in the next months :)

Regarding the build you made on f22, I'm not sure Bodhi/Koji/whatever will allow you to build a package with a lower version/revision; but I never tried.

Package remmina-1.2.0-0.4.git.b3e339e.fc22, guacamole-server-0.9.5-3.fc22, freerdp-1.2.0-0.8.git.24a752a.fc22:
* should fix your issue,
* was pushed to the Fedora 22 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing remmina-1.2.0-0.4.git.b3e339e.fc22 guacamole-server-0.9.5-3.fc22 freerdp-1.2.0-0.8.git.24a752a.fc22'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-3632/guacamole-server-0.9.5-3.fc22,freerdp-1.2.1-0.2.git.24a752a.fc22,remmina-1.2.0-0.4.git.b3e339e.fc22
then log in and leave karma (feedback).

Package remmina-1.2.0-0.4.git.b3e339e.fc22, guacamole-server-0.9.5-3.fc22, freerdp-1.2.0-0.9.git.24a752a.fc22, vinagre-3.15.92-2.fc22:
* should fix your issue,
* was pushed to the Fedora 22 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing remmina-1.2.0-0.4.git.b3e339e.fc22 guacamole-server-0.9.5-3.fc22 freerdp-1.2.0-0.9.git.24a752a.fc22 vinagre-3.15.92-2.fc22'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-3632/freerdp-1.2.0-0.9.git.24a752a.fc22,vinagre-3.15.92-2.fc22,guacamole-server-0.9.5-3.fc22,remmina-1.2.0-0.4.git.b3e339e.fc22
then log in and leave karma (feedback).

remmina-1.2.0-0.4.git.b3e339e.fc22, guacamole-server-0.9.5-3.fc22, freerdp-1.2.0-0.9.git.24a752a.fc22, vinagre-3.15.92-2.fc22 has been pushed to the Fedora 22 stable repository.  If problems still persist, please make note of it in this bug report.