Bug 1199682

Summary: virDomainBlockCopy cannot get a right flag when use libvirt_virDomainBlockCopy
Product: [Fedora] Fedora Reporter: Nir Soffer <nsoffer>
Component: libvirt-pythonAssignee: Daniel Berrangé <berrange>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: urgent Docs Contact:
Priority: high    
Version: 21CC: alitke, amureini, berrange, crobinso, dyuan, eblake, honzhang, jiahu, lhuang, mzhan, phrdina, veillard, virt-bugs, virt-maint
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: libvirt-python-1.2.9-2.fc21 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1155484
: 1209839 (view as bug list) Environment:
Last Closed: 2015-03-23 07:09:49 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1155484    
Bug Blocks: 1185842, 1200718, 1209839    

Comment 1 Nir Soffer 2015-03-07 00:44:24 UTC
Vdsm need this fix in Fedora 21 and Fedora 20 with virt-preview for performing live storage migration between file and block storage domains.

Comment 2 Nir Soffer 2015-03-07 00:59:35 UTC
This fix:

commit a7303a56b5e55c29cb5336c84a89b8347a355770
Author: Pavel Hrdina <phrdina>
Date:   Wed Oct 22 11:10:54 2014 +0200

    flags cannot get right value for blockCopy function
    
    When use blockCopy, flags cannot get a right value, because
    PyArg_ParseTuple want to get 6 parameters and blockCopy only
    pass 5. Flags will get a unpredictable value, this will make
    the function fail with error:
    
    unsupported flags (0x7f6c) in function qemuDomainBlockCopy
    
    Signed-off-by: Luyao Huang <lhuang>

Will be available in 1.2.10, but we need a backport in 1.2.9:

8e09c79 (tag: v1.2.10) fix libvirt headers list
309be0a virDomainBlockCopy: initialize flags to 0
a7303a5 flags cannot get right value for blockCopy function
7aaa02b Fix rest of unsigned integer handling
b3aa7da Fix parsing of 'flags' argument for bulk stats functions
7bfe4e3 Fix function name when parsing arguments in libvirt_virNodeAllocPages
d8b7aa4 Improve error output when use getTime with a nonzero flags.
8feae56 Change the comment in getPyNodeCPUCount method reflecting correct called methods
02cc5d6 setup.py: fix rpm build to return 1 on error
5346d9d sanitytest: define long for python version >= 3
c58c7f3 sanitytest: count with the fact that large enums can be long
09b1570 sanitytest: check for exported enums
c34113f Post-release version bump for new dev cycle
714aa15 (tag: v1.2.9) implement new tunable event

Comment 3 Fedora Update System 2015-03-10 15:44:44 UTC
libvirt-python-1.2.9-2.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/libvirt-python-1.2.9-2.fc21

Comment 4 Fedora Update System 2015-03-13 17:28:10 UTC
Package libvirt-python-1.2.9-2.fc21:
* should fix your issue,
* was pushed to the Fedora 21 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing libvirt-python-1.2.9-2.fc21'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-3814/libvirt-python-1.2.9-2.fc21
then log in and leave karma (feedback).

Comment 5 Fedora Update System 2015-03-23 07:09:49 UTC
libvirt-python-1.2.9-2.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 6 Eric Blake 2015-04-08 12:00:57 UTC
Cole, how easy or hard is this to push the latest F21 bits to fedora-virt-preview for use in F20?

Comment 7 Cole Robinson 2015-04-08 15:38:11 UTC
I pushed the updated libvirt-python to f20 virt-preview now