Bug 1200375

Summary: Artifacts when compositing emblems
Product: [Fedora] Fedora Reporter: Tim Waugh <twaugh>
Component: system-config-printerAssignee: Tim Waugh <twaugh>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 22CC: fedora, jpopelka, mclasen, twaugh
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: system-config-printer-1.5.6-1.fc22 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-03-21 05:03:06 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Screenshot
none
Demonstration
none
Screenshot from demo none

Description Tim Waugh 2015-03-10 12:39:39 UTC
Created attachment 999882 [details]
Screenshot

Description of problem:
The emblems seem to be doubled-up somehow.

Version-Release number of selected component (if applicable):
system-config-printer-1.5.5-2.fc22.x86_64

How reproducible:
100%

Comment 1 Tim Waugh 2015-03-10 13:15:28 UTC
Created attachment 999907 [details]
Demonstration

Here's a small python program to demonstrate that using NEAREST causes artifacts, but using BILINEAR is fine.

Is this a bug in gdk_pixbuf_composite()?

Comment 2 Tim Waugh 2015-03-10 13:17:29 UTC
Created attachment 999908 [details]
Screenshot from demo

Comment 3 Matthias Clasen 2015-03-12 22:47:26 UTC
        default_emblem.composite (copy,
                                  0, 0,
                                  copy.get_width (),
                                  copy.get_height (),
                                  0, 0,
                                  1.0, 1.0,
                                  interptype,
                                  255)

Try replacing copy.get_width/height with default_emblem.get_width/height.
I think that should fix your problem.

Comment 4 Tim Waugh 2015-03-13 12:06:43 UTC
Thanks, now I've read the documentation a few more times I think I understand why they're named dest_width/dest_height even though they are the width and height of the src pixbuf here.

Comment 6 Fedora Update System 2015-03-17 17:51:52 UTC
system-config-printer-1.5.6-1.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/system-config-printer-1.5.6-1.fc22

Comment 7 Fedora Update System 2015-03-18 10:36:21 UTC
Package system-config-printer-1.5.6-1.fc22:
* should fix your issue,
* was pushed to the Fedora 22 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing system-config-printer-1.5.6-1.fc22'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-4114/system-config-printer-1.5.6-1.fc22
then log in and leave karma (feedback).

Comment 8 Fedora Update System 2015-03-21 05:03:06 UTC
system-config-printer-1.5.6-1.fc22 has been pushed to the Fedora 22 stable repository.  If problems still persist, please make note of it in this bug report.