Bug 1200399

Summary: Review Request: rubygem-fog-profitbricks - Module for the 'fog' gem to support ProfitBricks
Product: [Fedora] Fedora Reporter: Vít Ondruch <vondruch>
Component: Package ReviewAssignee: Josef Stribny <jstribny>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: hhorak, jstribny, package-review
Target Milestone: ---Flags: jstribny: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: rubygem-fog-profitbricks-0.0.1-1.fc23 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-03-19 12:05:40 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1200310    
Bug Blocks: 1152158    

Description Vít Ondruch 2015-03-10 13:40:15 UTC 
Spec URL: https://fedorapeople.org/cgit/vondruch/public_git/rubygem-fog-profitbricks.git/tree/rubygem-fog-profitbricks.spec?id=a4acba4bc5ee2d616834a14ac29c9974ba37684e
SRPM URL: http://people.redhat.com/vondruch/rubygem-fog-profitbricks-0.0.1-1.fc23.src.rpm
Description: Module for the 'fog' gem to support ProfitBricks.
Fedora Account System Username: vondruch
Comment 1 Vít Ondruch 2015-03-11 12:43:58 UTC 
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=9203789
Comment 2 Josef Stribny 2015-03-13 07:54:31 UTC 
Taking.
Comment 3 Josef Stribny 2015-03-13 08:00:19 UTC 
rpmlint found some zero-length files:

$ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/rubygem-fog-aws-0.1.1-1.fc23.noarch.rpm rubygem-fog-aws.noarch: W: no-documentation
rubygem-fog-aws.noarch: E: zero-length /usr/share/gems/gems/fog-aws-0.1.1/lib/fog/aws/parsers/dns/create_health_check.rb
rubygem-fog-aws.noarch: E: zero-length /usr/share/gems/gems/fog-aws-0.1.1/lib/fog/aws/models/sns/subscription.rb


otherwise the spec looks good, package builds, installs, runs. Tests are passing =>  APPROVED. Please fix the rpmlint issues before pushing.
Comment 4 Vít Ondruch 2015-03-13 13:11:54 UTC 
New Package SCM Request
=======================
Package Name: rubygem-fog-profitbricks
Short Description: Module for the 'fog' gem to support ProfitBricks
Upstream URL: https://github.com/fog/fog-profitbricks
Owners: vondruch
Branches: 
InitialCC:
Comment 5 Gwyn Ciesla 2015-03-13 13:45:08 UTC 
Git done (by process-git-requests).