Bug 1200856

Summary: nss and nss-softokn will not build on arm, typo in %check
Product: Red Hat Enterprise Linux 7 Reporter: Troy Dawson <tdawson>
Component: nssAssignee: nss-nspr-maint <nss-nspr-maint>
Status: CLOSED ERRATA QA Contact: Alicja Kario <hkario>
Severity: low Docs Contact:
Priority: low    
Version: 7.1CC: emaldona, hkario, kengert, rrelyea, tmraz
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: nss-3.21.0-15.el7 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1335689 (view as bug list) Environment:
Last Closed: 2016-11-04 03:55:15 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1277314, 1335689    
Attachments:
Description Flags
nss.spec changes - in patch format none

Description Troy Dawson 2015-03-11 14:08:35 UTC
Description of problem:
When attempting to build nss-3.16.2.3-5.el7 and nss-softokn-3.16.2.3-9.el7 on a 32 bit arm environment, it always fails %check.
I realize that RHEL 7 isn't supported on the arm architecture, but the failure happens specifically because someone put in a check that was supposed to work on arm, but has a slight typo.

Version-Release number of selected component (if applicable):
nss-3.16.2.3-5.el7
nss-softokn-3.16.2.3-9.el7
Only these versions.  Earlier versions build correctly.

How reproducible:
100% on 32 bit arm.

Steps to Reproduce:
1. rpmbuild -ba nss-softokn-3.16.2.3-9.el7.src.rpm (on a 32 bit arm system)
2. *wait for all the builds and tests to complete*
3.

Actual results:
... build and test output, tests indicate everything passed ...

Unexpected fi

... rest of fail output ...

Expected results:
Finish with built rpms.

Additional info:

===problem code===
else
# test suite is failing on arm and has for a while let's run the test suite but make it non fatal on arm
%ifnarch %{arm}
  if [ ${GREP_EXIT_STATUS:-0} -eq 0 ]; then
    # while a situation in which grep return status is 0 and it doesn't output
    # anything shouldn't happen, set the default to something that is
    # obviously wrong (-1)
    echo "error: test suite had ${TEST_FAILURES:--1} test failure(s)"
    exit 1
  else
    if [ ${GREP_EXIT_STATUS:-0} -eq 2 ]; then
      echo "error: grep has not found log file"
      exit 1
    else
      echo "error: grep failed with exit code: ${GREP_EXIT_STATUS}"
      exit 1
    fi
  fi
%endif
fi
echo "test suite completed"

===solved code===
else
# test suite is failing on arm and has for a while let's run the test suite but make it non fatal on arm
%ifnarch %{arm}
  if [ ${GREP_EXIT_STATUS:-0} -eq 0 ]; then
    # while a situation in which grep return status is 0 and it doesn't output
    # anything shouldn't happen, set the default to something that is
    # obviously wrong (-1)
    echo "error: test suite had ${TEST_FAILURES:--1} test failure(s)"
    exit 1
  else
    if [ ${GREP_EXIT_STATUS:-0} -eq 2 ]; then
      echo "error: grep has not found log file"
      exit 1
    else
      echo "error: grep failed with exit code: ${GREP_EXIT_STATUS}"
      exit 1
    fi
  fi
%else
  echo "We are assuming tests passed on arm."
%endif
fi
echo "test suite completed"

===done===

Comment 14 Elio Maldonado Batiz 2016-04-20 21:06:14 UTC
Created attachment 1149206 [details]
nss.spec changes - in patch format

Comment 22 errata-xmlrpc 2016-11-04 03:55:15 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-2335.html