Bug 1200858

Summary:	Review Request: rubygem-fog-serverlove - Module for the 'fog' gem to support ServerLove
Product:	[Fedora] Fedora	Reporter:	Vít Ondruch <vondruch>
Component:	Package Review	Assignee:	Josef Stribny <jstribny>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	hhorak, jstribny, package-review
Target Milestone:	---	Flags:	jstribny: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	rubygem-fog-serverlove-0.1.1-1.fc23	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-03-19 13:49:52 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1152158

Description Vít Ondruch 2015-03-11 14:15:08 UTC

Spec URL: https://fedorapeople.org/cgit/vondruch/public_git/rubygem-fog-serverlove.git/tree/rubygem-fog-serverlove.spec?id=9ab785bc51da1e63563dbe31ae377eac24169a36
SRPM URL: http://people.redhat.com/vondruch/rubygem-fog-serverlove-0.1.1-1.fc23.src.rpm
Description: This library can be used as a module for `fog` or as standalone provider to use the ServerLove in applications.

Fedora Account System Username: vondruch

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=9204448

Comment 1 Josef Stribny 2015-03-13 08:10:42 UTC

Taking.

Comment 2 Josef Stribny 2015-03-13 08:27:34 UTC

rpmlint:

$ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/rubygem-fog-serverlove-0.1.1-1.fc23.noarch.rpm 
rubygem-fog-serverlove.noarch: W: no-documentation
rubygem-fog-serverlove.noarch: E: zero-length /usr/share/gems/gems/fog-serverlove-0.1.1/lib/fog/serverlove/compute.rb
1 packages and 0 specfiles checked; 1 errors, 1 warnings.

-> lib/fog/serverlove/compute.rb should be deleted (ideally in upstream as well)

Otherwise package builds, installs and runs. Spec looks good, tests are run and passing. Please fix the issue above before pushing. => APPROVED.

Comment 3 Vít Ondruch 2015-03-13 13:20:25 UTC

Thanks for the review.



New Package SCM Request
=======================
Package Name: rubygem-fog-serverlove
Short Description: Module for the 'fog' gem to support ServerLove
Upstream URL: https://github.com/fog/fog-serverlove
Owners: vondruch
Branches: 
InitialCC:

Comment 4 Gwyn Ciesla 2015-03-13 13:48:17 UTC

Git done (by process-git-requests).