Bug 1200866

Summary:	Review Request: perl-ZMQ-LibZMQ4 - Libzmq 4.x wrapper for Perl
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-ZMQ-LibZMQ4-0.01-1.fc25	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-06-20 14:59:11 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1199573
Bug Blocks:

Description Petr Pisar 2015-03-11 14:26:47 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-ZMQ-LibZMQ4/perl-ZMQ-LibZMQ4.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-ZMQ-LibZMQ4/perl-ZMQ-LibZMQ4-0.01-1.fc23.src.rpm
Description:
The ZMQ::LibZMQ4 module is a wrapper of the fourth version of ØMQ message
passing library for Perl.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2016-06-20 13:55:10 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

$ rpm -qp --requires perl-ZMQ-LibZMQ4-0.01-1.fc25.x86_64.rpm | sort | uniq -c
      1 libc.so.6()(64bit)
      1 libc.so.6(GLIBC_2.14)(64bit)
      1 libc.so.6(GLIBC_2.2.5)(64bit)
      1 libc.so.6(GLIBC_2.4)(64bit)
      1 libperl.so.5.24()(64bit)
      1 libzmq.so.5()(64bit)
      1 perl(:MODULE_COMPAT_5.24.0)
      1 perl(Exporter)
      1 perl(XSLoader)
      1 perl(ZMQ::Constants)
      1 perl(base)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
      1 rtld(GNU_HASH)
Binary requires are Ok.

$ rpm -qp --provides perl-ZMQ-LibZMQ4-0.01-1.fc25.x86_64.rpm | sort | uniq -c
      1 perl(ZMQ::LibZMQ4) = 0.01
      1 perl-ZMQ-LibZMQ4 = 0.01-1.fc25
      1 perl-ZMQ-LibZMQ4(x86-64) = 0.01-1.fc25
Binary provides are Ok.

$ rpmlint ./perl-ZMQ-LibZMQ4*
perl-ZMQ-LibZMQ4.src: W: spelling-error Summary(en_US) Libzmq -> Librium
perl-ZMQ-LibZMQ4.x86_64: W: spelling-error Summary(en_US) Libzmq -> Librium
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
Rpmlint is ok

BuildRequires 
FIX: Please add following build-requires
  * coreutils
  * findutils
  * make
  * perl-devel  
  * perl-generators
  * sed


Please correct 'FIX' issue.

Otherwise package is good.
Approved.

Comment 2 Gwyn Ciesla 2016-06-20 14:20:12 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-ZMQ-LibZMQ4

Comment 3 Petr Pisar 2016-06-20 14:59:11 UTC

Thank you for the review and the repository.

I added the missing dependencies.