Bug 1200879

Summary:	initialize child_down_cond conditional variable.
Product:	[Community] GlusterFS	Reporter:	Humble Chirammal <hchiramm>
Component:	libgfapi	Assignee:	Humble Chirammal <hchiramm>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Sudhir D <sdharane>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	mainline	CC:	bugs, gluster-bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	glusterfs-3.7.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-05-15 17:09:20 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Humble Chirammal 2015-03-11 14:52:59 UTC

Description of problem:

currently glfs_new_from_ctx() does not initialize child_down_count
conditional variable, but, glfs_free_from_ctx()
destroy this variable. mnt3udp_get_export_subdir_inode() from mount3
calls glfs_free_from_ctx(), so bound to invite problems. 
This patch avoids the issue.

Version-Release number of selected component (if applicable):

GlusterFS 3.6.2

How reproducible:

N/A

Steps to Reproduce:

N/A

Actual results:

pthread_cond_destroy called without proper init.


Expected results:

It should be initialized.

Additional info:

Comment 1 Anand Avati 2015-03-11 14:54:29 UTC

REVIEW: http://review.gluster.org/9857 (libgfapi: initialize child_down_count cond. variable.) posted (#4) for review on master by Humble Devassy Chirammal (humble.devassy)

Comment 2 Anand Avati 2015-03-12 05:56:54 UTC

REVIEW: http://review.gluster.org/9857 (libgfapi: initialize child_down_count cond. variable.) posted (#5) for review on master by Humble Devassy Chirammal (humble.devassy)

Comment 3 Anand Avati 2015-03-13 19:35:49 UTC

REVIEW: http://review.gluster.org/9857 (libgfapi: initialize child_down_count cond. variable.) posted (#6) for review on master by Humble Devassy Chirammal (humble.devassy)

Comment 4 Anand Avati 2015-03-16 09:43:25 UTC

REVIEW: http://review.gluster.org/9857 (libgfapi: initialize child_down_count cond. variable.) posted (#7) for review on master by Humble Devassy Chirammal (humble.devassy)

Comment 5 Anand Avati 2015-03-16 09:47:11 UTC

COMMIT: http://review.gluster.org/9857 committed in master by Niels de Vos (ndevos) 
------
commit 0ab4cb8174f478e8f725f13e96f608a6186e8384
Author: Humble Devassy Chirammal <hchiramm>
Date:   Wed Mar 11 17:19:42 2015 +0530

    libgfapi: initialize child_down_count cond. variable.
    
    currently glfs_new_from_ctx() does not initialize child_down_count
    conditional variable, but, glfs_free_from_ctx()
    destroy this variable. mnt3udp_get_export_subdir_inode() from mount3
    calls glfs_free_from_ctx(), so bound to invite problems. This patch
    avoids the issue.
    
    Change-Id: I8c1ed83f0b39248edbb78db25c9434274b538e80
    BUG: 1200879
    Signed-off-by: Humble Devassy Chirammal <hchiramm>
    Reviewed-on: http://review.gluster.org/9857
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Niels de Vos <ndevos>

Comment 6 Niels de Vos 2015-05-15 17:09:20 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user