Bug 1201056
Summary: | lighttpd should own /var/www/lighttpd | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Christian Stadelmann <fedora> |
Component: | lighttpd | Assignee: | Gwyn Ciesla <gwync> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 23 | CC: | gs-redhat.com, gwync |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | lighttpd-1.4.41-2.fc25 lighttpd-1.4.41-2.fc24 lighttpd-1.4.41-2.fc23 lighttpd-1.4.41-2.el6 lighttpd-1.4.41-2.el7 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2016-10-12 18:59:42 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Christian Stadelmann
2015-03-11 23:57:39 UTC
This message is a reminder that Fedora 21 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 21. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '21'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 21 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. Still present. This is by design. Why is this necessary? /etc/lighttpd/lighttd.conf does not use this location in Fedora 24, and neither does /etc/lighttpd/conf.d/*. Last time I checked lighttpd was using /var/www/lighttpd as webroot. Additionally, the package ships content in /var/www/lighttpd. One of these is wrong, either shipping and using /var/www/lighttpd or having wrong permissions/ownership on these files. /etc/lighttpd/lighttpd.conf defines var.server_root = "/var/www" and /etc/lighttpd/lighttpd.conf and /etc/lighttpd/conf.d/* use server_root in: server_root + "/cgi-bin..." server_root + "/downloads..." server_root + "/htdocs..." server_root + "/rails..." server_root + "/users..." server_root + "/vhosts..." These are subdirs of /var/www, and perhaps they should all be subdirs of /var/www/lighttpd/, but right now are not. If nothing else is done, /var/www/lighttpd should probably be renamed /htdocs. However, I have what I think is a better suggestion: I would instead suggest that /etc/lighttpd/lighttpd.conf be updated to define var.server_root = "/var/www/lighttpd", and that the lighttpd RPM package be updated to create the various subdirs, with appropriate permissions, including moving the current contents of /var/www/lighttpd/ into /var/www/lighttpd/htdocs/ Interesting. Does lighttpd create those subdirs at runtime or do they need to be created manually after RPM install? (In reply to Jon Ciesla from comment #6) > Interesting. Does lighttpd create those subdirs at runtime or do they need > to be created manually after RPM install? Have a look at https://apps.fedoraproject.org/packages/lighttpd/contents to see what is installed by the RPM (contained in the RPM). I know, I mean, are the subdirs created by the program itself or did you make them? They're not in the RPM, so the solution depends on how the subdirs got there. lighttpd does not create those dirs at startup. Looking at http://pkgs.fedoraproject.org/git/rpms/lighttpd.git, I see that http://pkgs.fedoraproject.org/git/rpms/lighttpd.git changes the document root, but that http://pkgs.fedoraproject.org/git/rpms/lighttpd.git does not. This is missing from the second patch, and the issue raised in this ticket: -server.document-root = server_root + "/htdocs" +server.document-root = server_root + "/lighttpd" (and what should the ownership and permissions be on /var/www/lighttpd/?) (In reply to Jon Ciesla from comment #8) > I know, I mean, are the subdirs created by the program itself or did you > make them? They're not in the RPM, so the solution depends on how the > subdirs got there. I don't care about the subdirs. /var/www/lighttpd is created by the lighttpd package on installation. It should be owned by lighttpd:lighttpd so permissions can be rwx------ for directories and rw------- for files. Users don't have to read /var/www/lighttpd, and my sql database or email server doesn't either. (reposting with updated patch names) Looking at http://pkgs.fedoraproject.org/git/rpms/lighttpd.git, I see that lighttpd-1.4.28-defaultconf.patch changes server.document-root, but that lighttpd-1.4.39-defaultconf.patch does not. The following is missing from the second patch: -server.document-root = server_root + "/htdocs" +server.document-root = server_root + "/lighttpd" Jon: would you review the above notes for packaging with lighttpd 1.4.41? Thanks. Correcting that patch and setting the ownership and permissions as in comment 11 is good with me. If all are in favour I'll push an update. (In reply to Jon Ciesla from comment #14) > Correcting that patch and setting the ownership and permissions as in > comment 11 is good with me. If all are in favour I'll push an update. It's ok for me too. Cool, I'll get this out. lighttpd-1.4.41-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-ce7d07124b lighttpd-1.4.41-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-1fee8eee35 lighttpd-1.4.41-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-cdf61dde70 lighttpd-1.4.41-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-c53b6ee2b2 lighttpd-1.4.41-2.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-e62a847e5c lighttpd-1.4.41-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. lighttpd-1.4.41-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. lighttpd-1.4.41-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. lighttpd-1.4.41-2.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. lighttpd-1.4.41-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. |