Bug 1202432

Summary: [abrt] minimodem: vorbis_block_clear(): minimodem killed by SIGSEGV
Product: [Fedora] Fedora Reporter: Diego <diego.ml>
Component: minimodemAssignee: Jim <kg4sgp>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 20CC: kg4sgp, relrod
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Unspecified   
URL: https://retrace.fedoraproject.org/faf/reports/bthash/c59ecef2a00c867bc83c438be95632a5574dabc6
Whiteboard: abrt_hash:41190fc63383ea842e3621e50134a366690df7a3
Fixed In Version: minimodem-0.20-2.fc20 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-04-07 07:25:56 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
File: backtrace
none
File: cgroup
none
File: core_backtrace
none
File: dso_list
none
File: exploitable
none
File: limits
none
File: maps
none
File: open_fds
none
File: proc_pid_status
none
File: var_log_messages none

Description Diego 2015-03-16 15:27:12 UTC 
Description of problem:
Using minimodem in rx mode with a random input audio file will likely cause segfault. While I understand minimodem would like to have a minimodem tx message as input, segfault is not nice either.

Version-Release number of selected component:
minimodem-0.19-3.fc20

Additional info:
reporter:       libreport-2.2.3
backtrace_rating: 4
cmdline:        minimodem --rx -f Intro.ogg 300
crash_function: vorbis_block_clear
executable:     /usr/bin/minimodem
kernel:         3.18.7-100.fc20.x86_64
runlevel:       N 5
type:           CCpp
uid:            1000

Truncated backtrace:
Thread no. 1 (4 frames)
 #1 vorbis_block_clear at block.c:164
 #2 vorbis_close at ogg_vorbis.c:475
 #3 psf_close at sndfile.c:2518
 #4 simpleaudio_close at simpleaudio.c:175
Comment 1 Diego 2015-03-16 15:27:15 UTC 
Created attachment 1002353 [details]
File: backtrace
Comment 2 Diego 2015-03-16 15:27:16 UTC 
Created attachment 1002354 [details]
File: cgroup
Comment 3 Diego 2015-03-16 15:27:18 UTC 
Created attachment 1002355 [details]
File: core_backtrace
Comment 4 Diego 2015-03-16 15:27:19 UTC 
Created attachment 1002356 [details]
File: dso_list
Comment 5 Diego 2015-03-16 15:27:20 UTC 
Created attachment 1002357 [details]
File: exploitable
Comment 6 Diego 2015-03-16 15:27:21 UTC 
Created attachment 1002358 [details]
File: limits
Comment 7 Diego 2015-03-16 15:27:23 UTC 
Created attachment 1002359 [details]
File: maps
Comment 8 Diego 2015-03-16 15:27:24 UTC 
Created attachment 1002360 [details]
File: open_fds
Comment 9 Diego 2015-03-16 15:27:25 UTC 
Created attachment 1002361 [details]
File: proc_pid_status
Comment 10 Diego 2015-03-16 15:27:26 UTC 
Created attachment 1002362 [details]
File: var_log_messages
Comment 11 Rick Elrod 2015-03-16 18:22:01 UTC 
Yep, I can reproduce this. Will file it upstream, thanks!
Comment 12 Rick Elrod 2015-03-16 19:00:05 UTC 
This actually appears to have been fixed in 0.20, but the updated build I did never got pushed. Whoops! I will rebuild it (the build has since been garbage collected) and submit it for f20 and f21. Thanks again for the report!
Comment 13 Diego 2015-03-17 10:23:56 UTC 
(In reply to Ricky Elrod from comment #12)
> This actually appears to have been fixed in 0.20, but the updated build I
> did never got pushed. Whoops! I will rebuild it (the build has since been
> garbage collected) and submit it for f20 and f21. Thanks again for the
> report!

Yeah, I think the problem is with stereo audio files, as it doesn't crash with mono audio files.
The commit that fixes it should be:
https://github.com/kamalmostafa/minimodem/commit/3c5ac8819d7dd123f4d71afa3061018a0b2da114
Comment 14 Fedora Update System 2015-03-17 14:54:53 UTC 
minimodem-0.20-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/minimodem-0.20-2.fc20
Comment 15 Fedora Update System 2015-03-17 14:58:11 UTC 
minimodem-0.20-2.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/minimodem-0.20-2.fc21
Comment 16 Fedora Update System 2015-04-07 07:25:56 UTC 
minimodem-0.20-2.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 17 Fedora Update System 2015-04-07 07:27:21 UTC 
minimodem-0.20-2.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.